[PATCH] staging: iio: adc: ad7280a: fix 2 checks

[PATCH] staging: iio: adc: ad7280a: fix 2 checks

[Gabriel Capella]

This patch does not change the logic, it only
corrects the checkpatch checks.

The patch fixes 2 checks of type:
"CHECK: spaces preferred around that '-'"

Signed-off-by: Gabriel Capella <gabriel@capella.pro>
---
 drivers/staging/iio/adc/ad7280a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index 58420dcb406d..a4b4f8678c56 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -750,14 +750,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
 }
 
 static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
-		in_voltage-voltage_thresh_low_value,
+		in_voltage - voltage_thresh_low_value,
 		0644,
 		ad7280_read_channel_config,
 		ad7280_write_channel_config,
 		AD7280A_CELL_UNDERVOLTAGE);
 
 static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
-		in_voltage-voltage_thresh_high_value,
+		in_voltage - voltage_thresh_high_value,
 		0644,
 		ad7280_read_channel_config,
 		ad7280_write_channel_config,
-- 
2.17.1 (Apple Git-112)


-- 
Gabriel Capella
gabrielcapella.com
hardwarelivreusp.org
+55 11 98124-5668

Re: [PATCH] staging: iio: adc: ad7280a: fix 2 checks

[Slawomir Stepien]

On paź 06, 2018 13:27, Gabriel Capella wrote:
> This patch does not change the logic, it only
> corrects the checkpatch checks.
> 
> The patch fixes 2 checks of type:
> "CHECK: spaces preferred around that '-'"

I've made the same mistake few days ago. This change is incorrect.
Please see: https://lore.kernel.org/patchwork/patch/635994/.

> Signed-off-by: Gabriel Capella <gabriel@capella.pro>
> ---
>  drivers/staging/iio/adc/ad7280a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index 58420dcb406d..a4b4f8678c56 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -750,14 +750,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
>  }
>  
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> -		in_voltage-voltage_thresh_low_value,
> +		in_voltage - voltage_thresh_low_value,
>  		0644,
>  		ad7280_read_channel_config,
>  		ad7280_write_channel_config,
>  		AD7280A_CELL_UNDERVOLTAGE);
>  
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> -		in_voltage-voltage_thresh_high_value,
> +		in_voltage - voltage_thresh_high_value,
>  		0644,
>  		ad7280_read_channel_config,
>  		ad7280_write_channel_config,

-- 
Slawomir Stepien

Re: [PATCH] staging: iio: adc: ad7280a: fix 2 checks

[Dan Carpenter]

On Sat, Oct 06, 2018 at 10:25:42PM +0200, Slawomir Stepien wrote:
> On paź 06, 2018 13:27, Gabriel Capella wrote:
> > This patch does not change the logic, it only
> > corrects the checkpatch checks.
> > 
> > The patch fixes 2 checks of type:
> > "CHECK: spaces preferred around that '-'"
> 
> I've made the same mistake few days ago. This change is incorrect.
> Please see: https://lore.kernel.org/patchwork/patch/635994/.
>

You could add a comment.  /* do not put spaces around the hyphen.  #checkpatch.pl */

These are the only places which use this style and a lot of people
bump into it.

regards,
dan carpenter

Re: [PATCH] staging: iio: adc: ad7280a: fix 2 checks

[Slawomir Stepien]

On paź 11, 2018 10:32, Dan Carpenter wrote:
> On Sat, Oct 06, 2018 at 10:25:42PM +0200, Slawomir Stepien wrote:
> > On paź 06, 2018 13:27, Gabriel Capella wrote:
> > > This patch does not change the logic, it only
> > > corrects the checkpatch checks.
> > > 
> > > The patch fixes 2 checks of type:
> > > "CHECK: spaces preferred around that '-'"
> > 
> > I've made the same mistake few days ago. This change is incorrect.
> > Please see: https://lore.kernel.org/patchwork/patch/635994/.
> >
> 
> You could add a comment.  /* do not put spaces around the hyphen.  #checkpatch.pl */
> 
> These are the only places which use this style and a lot of people
> bump into it.

Gabriel go ahead if you want to. If not then I would be happy to prepare this
patch.

-- 
Slawomir Stepien

Re: [PATCH] staging: iio: adc: ad7280a: fix 2 checks

[Gabriel Capella]

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

A few minutes ago a sent a patch adding this comment in two different
files.

Thank you for the suggestions.

Em qui, 11 de out de 2018 às 12:32, Slawomir Stepien <sst@poczta.fm>
escreveu:

> On paź 11, 2018 10:32, Dan Carpenter wrote:
> > On Sat, Oct 06, 2018 at 10:25:42PM +0200, Slawomir Stepien wrote:
> > > On paź 06, 2018 13:27, Gabriel Capella wrote:
> > > > This patch does not change the logic, it only
> > > > corrects the checkpatch checks.
> > > >
> > > > The patch fixes 2 checks of type:
> > > > "CHECK: spaces preferred around that '-'"
> > >
> > > I've made the same mistake few days ago. This change is incorrect.
> > > Please see: https://lore.kernel.org/patchwork/patch/635994/.
> > >
> >
> > You could add a comment.  /* do not put spaces around the hyphen.  #
> checkpatch.pl */
> >
> > These are the only places which use this style and a lot of people
> > bump into it.
>
> Gabriel go ahead if you want to. If not then I would be happy to prepare
> this
> patch.
>
> --
> Slawomir Stepien
>


-- 
Gabriel Capella
gabrielcapella.com
hardwarelivreusp.org
+55 11 98124-5668

[-- Attachment #2: Type: text/html, Size: 2629 bytes --]