From: Wei Liu <wei.liu2@citrix.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Paul Durrant" <Paul.Durrant@citrix.com>,
"Wei Liu" <wei.liu2@citrix.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2] x86/vtd: fix IOMMU share PT destruction path
Date: Thu, 11 Oct 2018 09:32:29 +0100 [thread overview]
Message-ID: <20181011083229.b3q74zegdfr6jdum@zion.uk.xensource.com> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D19BDE4CF5@SHSMSX101.ccr.corp.intel.com>
On Thu, Oct 11, 2018 at 08:30:59AM +0000, Tian, Kevin wrote:
> > From: Wei Liu [mailto:wei.liu2@citrix.com]
> > Sent: Thursday, October 11, 2018 4:28 PM
> >
> > On Tue, Oct 09, 2018 at 03:57:08PM +0100, Wei Liu wrote:
> > > Commit 2916951c1 ("mm / iommu: include need_iommu() test in
> > > iommu_use_hap_pt()") included need_iommu() in iommu_use_hap_pt
> > and
> > > 91d4eca7add ("mm / iommu: split need_iommu() into has_iommu_pt()
> > and
> > > need_iommu_pt_sync()") made things finer grain by spliting need_iommu
> > > into three states.
> > >
> > > The destruction path can't use iommu_use_hap_pt because at the point
> > > platform op is called, IOMMU is either already switched to or has
> > > always been in disabled state, and the shared PT test would always be
> > > false.
> > >
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Kevin, can you ack/nack this patch? Staging is currently blocked by a
> > bug which is fixed by this patch.
> >
>
> Sorry I thought I've sent the ack but looks not:
>
> Acked-by: Kevin Tian <kevin.tian@intel.com>
Thank you!
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-10-11 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 14:57 [PATCH v2] x86/vtd: fix IOMMU share PT destruction path Wei Liu
2018-10-09 15:00 ` Paul Durrant
2018-10-11 7:09 ` Roger Pau Monné
2018-10-11 8:27 ` Wei Liu
2018-10-11 8:29 ` Wei Liu
2018-10-11 8:30 ` Tian, Kevin
2018-10-11 8:32 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011083229.b3q74zegdfr6jdum@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=Paul.Durrant@citrix.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.