From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Mylene Josserand <mylene.josserand@bootlin.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hugues Fruchet <hugues.fruchet@st.com>,
Loic Poulain <loic.poulain@linaro.org>,
Samuel Bobrowicz <sam@elite-embedded.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Daniel Mack <daniel@zonque.org>, Jacopo Mondi <jacopo@jmondi.org>,
Maxime Ripard <maxime.ripard@bootlin.com>
Subject: [PATCH v4 00/12] media: ov5640: Misc cleanup and improvements
Date: Thu, 11 Oct 2018 11:20:55 +0200 [thread overview]
Message-ID: <20181011092107.30715-1-maxime.ripard@bootlin.com> (raw)
Hi,
Here is a "small" series that mostly cleans up the ov5640 driver code,
slowly getting rid of the big data array for more understandable code
(hopefully).
The biggest addition would be the clock rate computation at runtime,
instead of relying on those arrays to setup the clock tree
properly. As a side effect, it fixes the framerate that was off by
around 10% on the smaller resolutions, and we now support 60fps.
This also introduces a bunch of new features.
Let me know what you think,
Maxime
Changes from v3:
- Rebased on current Sakari tree
- Fixed an error when changing only the framerate
Changes from v2:
- Rebased on latest Sakari PR
- Fixed the issues reported by Hugues: improper FPS returned for
formats, improper rounding of the FPS, some with his suggestions,
some by simplifying the logic.
- Expanded the clock tree comments based on the feedback from Samuel
Bobrowicz and Loic Poulain
- Merged some of the changes made by Samuel Bobrowicz to fix the
MIPI rate computation, fix the call sites of the
ov5640_set_timings function, the auto-exposure calculation call,
etc.
- Split the patches into smaller ones in order to make it more
readable (hopefully)
Changes from v1:
- Integrated Hugues' suggestions to fix v4l2-compliance
- Fixed the bus width with JPEG
- Dropped the clock rate calculation loops for something simpler as
suggested by Sakari
- Cache the exposure value instead of using the control value
- Rebased on top of 4.17
Maxime Ripard (12):
media: ov5640: Adjust the clock based on the expected rate
media: ov5640: Remove the clocks registers initialization
media: ov5640: Remove redundant defines
media: ov5640: Remove redundant register setup
media: ov5640: Compute the clock rate at runtime
media: ov5640: Remove pixel clock rates
media: ov5640: Enhance FPS handling
media: ov5640: Make the return rate type more explicit
media: ov5640: Make the FPS clamping / rounding more extendable
media: ov5640: Add 60 fps support
media: ov5640: Remove duplicate auto-exposure setup
ov5640: Enforce a mode change when changing the framerate
drivers/media/i2c/ov5640.c | 679 ++++++++++++++++++++-----------------
1 file changed, 374 insertions(+), 305 deletions(-)
--
2.19.1
next reply other threads:[~2018-10-11 16:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 9:20 Maxime Ripard [this message]
2018-10-11 9:20 ` [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate Maxime Ripard
2018-10-15 14:05 ` Hugues FRUCHET
2018-10-16 16:54 ` jacopo mondi
2018-10-17 17:54 ` Sam Bobrowicz
2018-10-17 19:51 ` jacopo mondi
2018-10-18 9:31 ` Maxime Ripard
2018-10-18 10:03 ` jacopo mondi
2018-10-18 20:25 ` Samuel Bobrowicz
2018-10-18 20:15 ` Samuel Bobrowicz
2018-10-18 9:29 ` Maxime Ripard
2018-10-18 13:46 ` jacopo mondi
2018-10-18 16:56 ` Maxime Ripard
2018-10-11 9:20 ` [PATCH v4 02/12] media: ov5640: Remove the clocks registers initialization Maxime Ripard
2018-10-11 9:20 ` [PATCH v4 03/12] media: ov5640: Remove redundant defines Maxime Ripard
2018-10-11 9:20 ` [PATCH v4 04/12] media: ov5640: Remove redundant register setup Maxime Ripard
2018-10-11 9:21 ` [PATCH v4 05/12] media: ov5640: Compute the clock rate at runtime Maxime Ripard
2019-02-21 16:20 ` Benoit Parrot
2019-02-22 14:39 ` Maxime Ripard
2019-02-22 14:54 ` Benoit Parrot
2019-02-22 15:04 ` Maxime Ripard
2019-02-25 9:21 ` Jacopo Mondi
2019-02-25 12:15 ` Jacopo Mondi
2019-02-25 13:06 ` Maxime Ripard
2018-10-11 9:21 ` [PATCH v4 06/12] media: ov5640: Remove pixel clock rates Maxime Ripard
2018-10-11 9:21 ` [PATCH v4 07/12] media: ov5640: Enhance FPS handling Maxime Ripard
2018-10-11 9:21 ` [PATCH v4 08/12] media: ov5640: Make the return rate type more explicit Maxime Ripard
2018-10-11 9:21 ` [PATCH v4 09/12] media: ov5640: Make the FPS clamping / rounding more extendable Maxime Ripard
2018-10-11 9:21 ` [PATCH v4 10/12] media: ov5640: Add 60 fps support Maxime Ripard
2018-10-11 9:21 ` [PATCH v4 11/12] media: ov5640: Remove duplicate auto-exposure setup Maxime Ripard
2018-10-11 9:21 ` [PATCH v4 12/12] ov5640: Enforce a mode change when changing the framerate Maxime Ripard
2018-10-15 13:57 ` Hugues FRUCHET
2018-10-16 7:10 ` Maxime Ripard
2018-10-16 8:45 ` Hugues FRUCHET
2018-10-16 15:57 ` [PATCH v4 00/12] media: ov5640: Misc cleanup and improvements jacopo mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011092107.30715-1-maxime.ripard@bootlin.com \
--to=maxime.ripard@bootlin.com \
--cc=daniel@zonque.org \
--cc=hans.verkuil@cisco.com \
--cc=hugues.fruchet@st.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mchehab@kernel.org \
--cc=mylene.josserand@bootlin.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sam@elite-embedded.com \
--cc=slongerbeam@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.