From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilya Maximets <i.maximets@samsung.com>
Subject: Re: [PATCH v5 01/19] vhost: fix messages results handling
Date: Thu, 11 Oct 2018 12:32:05 +0300
Message-ID: <20181011092940eucas1p1653f28aef02291d7c7aa780bb66f1535~cg_JbJ5iE1007410074eucas1p1Z@eucas1p1.samsung.com>
References: <20181009205426.21219-1-maxime.coquelin@redhat.com>
 <20181009205426.21219-2-maxime.coquelin@redhat.com>
 <CGME20181010072546epcas4p1c4650793aa034668781446742ff3b0d0@epcas4p1.samsung.com>
 <e19c8cba-3af4-4392-3a0a-af9bd5b9b61f@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com,
 nicknickolaev@gmail.com, alejandro.lucero@netronome.com,
 dgilbert@redhat.com, stable@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>, dev@dpdk.org,
 bruce.richardson@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com
 [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 648891B14E
 for <dev@dpdk.org>; Thu, 11 Oct 2018 11:29:43 +0200 (CEST)
Received: from eucas1p2.samsung.com (unknown [182.198.249.207])
 by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id
 20181011092942euoutp02dbfe707254c70855f414589ae7b18d5c~cg_Kxm5Du2600726007euoutp02S
 for <dev@dpdk.org>; Thu, 11 Oct 2018 09:29:42 +0000 (GMT)
In-Reply-To: <e19c8cba-3af4-4392-3a0a-af9bd5b9b61f@redhat.com>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10.10.2018 10:25, Maxime Coquelin wrote:
> Hi Ilya
> 
> On 10/09/2018 10:54 PM, Maxime Coquelin wrote:
>> Return of message handling has now changed to an enum that can
>> take non-negative value that is not zero in case a reply is
>> needed. But the code checking the variable afterwards has not
>> been updated, leading to success messages handling being
>> treated as errors.
>>
>> External post and pre callbacks return type needs also to be
>> changed to the new enum, so that its handling is consistent.
>> This is done in this patch alongside with the convertion of
>> its only user, vhost-crypto backend.
>>
>> Fixes: 0bff510b5ea6 ("vhost: unify message handling function signature")
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Acked-by: Ilya Maximets <i.maximets@samsung.com>
> 
> Sorry, I just notice I forgot to remove your ack from the commit
> message as it has quite changed since the previous version.
> 
> Please let me know if the patch is OK to you.

Hi. Sorry for delay.
Had no time to check it yesterday.
Will take a look at your new v6.

Best regards, Ilya Maximets.

> 
> Regards,
> Maxime