From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9350C32788 for ; Thu, 11 Oct 2018 14:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B66A20841 for ; Thu, 11 Oct 2018 14:17:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B66A20841 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728634AbeJKVor (ORCPT ); Thu, 11 Oct 2018 17:44:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726537AbeJKVor (ORCPT ); Thu, 11 Oct 2018 17:44:47 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58916308A972; Thu, 11 Oct 2018 14:17:24 +0000 (UTC) Received: from redhat.com (ovpn-125-61.rdu2.redhat.com [10.10.125.61]) by smtp.corp.redhat.com (Postfix) with SMTP id DE01C8FC14; Thu, 11 Oct 2018 14:17:15 +0000 (UTC) Date: Thu, 11 Oct 2018 10:17:15 -0400 From: "Michael S. Tsirkin" To: Tiwei Bie Cc: Jason Wang , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, virtio-dev@lists.oasis-open.org, wexu@redhat.com, jfreimann@redhat.com, maxime.coquelin@redhat.com, zhihong.wang@intel.com Subject: Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring Message-ID: <20181011101656-mutt-send-email-mst@kernel.org> References: <20180910030053.GA15645@debian> <20180911053726.GA7472@debian> <20180912121457-mutt-send-email-mst@kernel.org> <20180913085919.GA42049@fbsd1.sh.intel.com> <98d6bd4d-45e2-4207-e961-782f649e0139@redhat.com> <20181010103335-mutt-send-email-mst@kernel.org> <20181011121221.GA27106@debian> <20181011094705-mutt-send-email-mst@kernel.org> <20181011141331.GA11650@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181011141331.GA11650@debian> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 11 Oct 2018 14:17:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 11, 2018 at 10:13:31PM +0800, Tiwei Bie wrote: > On Thu, Oct 11, 2018 at 09:48:48AM -0400, Michael S. Tsirkin wrote: > > On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote: > > > > > But if it's not too late, I second for a OUT_OF_ORDER feature. > > > > > Starting from in order can have much simpler code in driver. > > > > > > > > > > Thanks > > > > > > > > It's tricky to change the flag polarity because of compatibility > > > > with legacy interfaces. Why is this such a big deal? > > > > > > > > Let's teach drivers about IN_ORDER, then if devices > > > > are in order it will get enabled by default. > > > > > > Yeah, make sense. > > > > > > Besides, I have done some further profiling and debugging > > > both in kernel driver and DPDK vhost. Previously I was mislead > > > by a bug in vhost code. I will send a patch to fix that bug. > > > With that bug fixed, the performance of packed ring in the > > > test between kernel driver and DPDK vhost is better now. > > > > OK, if we get a performance gain on the virtio side, we can finally > > upstream it. If you see that please re-post ASAP so we can > > put it in the next kernel release. > > Got it, I will re-post ASAP. > > Thanks! Pls remember to include data on performance gain in the cover letter. > > > > > -- > > MST From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: Re: [PATCH net-next v2 0/5] virtio: support packed ring Date: Thu, 11 Oct 2018 10:17:15 -0400 Message-ID: <20181011101656-mutt-send-email-mst@kernel.org> References: <20180910030053.GA15645@debian> <20180911053726.GA7472@debian> <20180912121457-mutt-send-email-mst@kernel.org> <20180913085919.GA42049@fbsd1.sh.intel.com> <98d6bd4d-45e2-4207-e961-782f649e0139@redhat.com> <20181010103335-mutt-send-email-mst@kernel.org> <20181011121221.GA27106@debian> <20181011094705-mutt-send-email-mst@kernel.org> <20181011141331.GA11650@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jason Wang , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, virtio-dev@lists.oasis-open.org, wexu@redhat.com, jfreimann@redhat.com, maxime.coquelin@redhat.com, zhihong.wang@intel.com To: Tiwei Bie Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Content-Disposition: inline In-Reply-To: <20181011141331.GA11650@debian> List-Id: netdev.vger.kernel.org On Thu, Oct 11, 2018 at 10:13:31PM +0800, Tiwei Bie wrote: > On Thu, Oct 11, 2018 at 09:48:48AM -0400, Michael S. Tsirkin wrote: > > On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote: > > > > > But if it's not too late, I second for a OUT_OF_ORDER feature. > > > > > Starting from in order can have much simpler code in driver. > > > > > > > > > > Thanks > > > > > > > > It's tricky to change the flag polarity because of compatibility > > > > with legacy interfaces. Why is this such a big deal? > > > > > > > > Let's teach drivers about IN_ORDER, then if devices > > > > are in order it will get enabled by default. > > > > > > Yeah, make sense. > > > > > > Besides, I have done some further profiling and debugging > > > both in kernel driver and DPDK vhost. Previously I was mislead > > > by a bug in vhost code. I will send a patch to fix that bug. > > > With that bug fixed, the performance of packed ring in the > > > test between kernel driver and DPDK vhost is better now. > > > > OK, if we get a performance gain on the virtio side, we can finally > > upstream it. If you see that please re-post ASAP so we can > > put it in the next kernel release. > > Got it, I will re-post ASAP. > > Thanks! Pls remember to include data on performance gain in the cover letter. > > > > > -- > > MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-4896-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 73341985CB4 for ; Thu, 11 Oct 2018 14:17:25 +0000 (UTC) Date: Thu, 11 Oct 2018 10:17:15 -0400 From: "Michael S. Tsirkin" Message-ID: <20181011101656-mutt-send-email-mst@kernel.org> References: <20180910030053.GA15645@debian> <20180911053726.GA7472@debian> <20180912121457-mutt-send-email-mst@kernel.org> <20180913085919.GA42049@fbsd1.sh.intel.com> <98d6bd4d-45e2-4207-e961-782f649e0139@redhat.com> <20181010103335-mutt-send-email-mst@kernel.org> <20181011121221.GA27106@debian> <20181011094705-mutt-send-email-mst@kernel.org> <20181011141331.GA11650@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181011141331.GA11650@debian> Subject: Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring To: Tiwei Bie Cc: Jason Wang , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, virtio-dev@lists.oasis-open.org, wexu@redhat.com, jfreimann@redhat.com, maxime.coquelin@redhat.com, zhihong.wang@intel.com List-ID: On Thu, Oct 11, 2018 at 10:13:31PM +0800, Tiwei Bie wrote: > On Thu, Oct 11, 2018 at 09:48:48AM -0400, Michael S. Tsirkin wrote: > > On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote: > > > > > But if it's not too late, I second for a OUT_OF_ORDER feature. > > > > > Starting from in order can have much simpler code in driver. > > > > > > > > > > Thanks > > > > > > > > It's tricky to change the flag polarity because of compatibility > > > > with legacy interfaces. Why is this such a big deal? > > > > > > > > Let's teach drivers about IN_ORDER, then if devices > > > > are in order it will get enabled by default. > > > > > > Yeah, make sense. > > > > > > Besides, I have done some further profiling and debugging > > > both in kernel driver and DPDK vhost. Previously I was mislead > > > by a bug in vhost code. I will send a patch to fix that bug. > > > With that bug fixed, the performance of packed ring in the > > > test between kernel driver and DPDK vhost is better now. > > > > OK, if we get a performance gain on the virtio side, we can finally > > upstream it. If you see that please re-post ASAP so we can > > put it in the next kernel release. > > Got it, I will re-post ASAP. > > Thanks! Pls remember to include data on performance gain in the cover letter. > > > > > -- > > MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org