All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 16/17] x86: introduce new defconfigs for PV and HVM
Date: Fri, 12 Oct 2018 16:34:06 +0100	[thread overview]
Message-ID: <20181012153406.u3qqgyq4pwkqoebk@zion.uk.xensource.com> (raw)
In-Reply-To: <5BC0BB9102000078001F119E@prv1-mh.provo.novell.com>

On Fri, Oct 12, 2018 at 09:19:45AM -0600, Jan Beulich wrote:
> >>> On 04.10.18 at 17:43, <wei.liu2@citrix.com> wrote:
> > They will be used by build tests.
> 
> And is it difficult for the build tests to set these up themselves?

I specifically said "build tests" but not "CI systems".

It wouldn't be very difficult for a CI system to generate these files,
but my idea is that providing these in tree can make things more
convenient for humans -- developers and maintainers.

Suppose you want a contributor to test their changes, instead of writing
"first please generate the following files, and then ...", you just give
them a rune / some runes to reference these files directly. There
doesn't need explaining and no ambiguity will arise. And if there is
disagreement on what work or what doesn't, it would be easy to
reproduce.

To me this is a clear win: a small investment that comes with long term
benefit.

> I don't really like such additions, in particular the neither-PV-nor-
> HVM one (which is otherwise completely useless). At the very
> least that one should gain a comment saying it exists for build
> testing only.
> 

Sure, I can do that.

Wei.

> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-10-12 15:34 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 15:43 [PATCH 00/17] Hi all Wei Liu
2018-10-04 15:43 ` [PATCH 01/17] x86/shadow: put PV L1TF functions under CONFIG_PV Wei Liu
2018-10-08 15:38   ` Jan Beulich
2018-10-04 15:43 ` [PATCH 02/17] x86/mm: make mm.c build with !CONFIG_PV Wei Liu
2018-10-08 16:00   ` Jan Beulich
2018-10-04 15:43 ` [PATCH 03/17] x86: turn is_pv_{, 32bit_}{domain, vcpu} into inline functions Wei Liu
2018-10-12 13:46   ` Jan Beulich
2018-10-04 15:43 ` [PATCH 04/17] x86: introduce is_pv_64bit_{vcpu, domain} Wei Liu
2018-10-12 13:48   ` Jan Beulich
2018-10-04 15:43 ` [PATCH 05/17] x86: make x86_64/traps.c build with !CONFIG_PV Wei Liu
2018-10-12 13:52   ` Jan Beulich
2018-10-04 15:43 ` [PATCH 06/17] x86: provide stub for arch_do_multicall_call Wei Liu
2018-10-12 13:56   ` Jan Beulich
2018-10-04 15:43 ` [PATCH 07/17] x86/traps: put PV code handlers under CONFIG_PV Wei Liu
2018-10-12 14:08   ` Jan Beulich
2018-10-16 16:47     ` Wei Liu
2018-10-04 15:43 ` [PATCH 08/17] x86: make construct_dom0 build with !CONFIG_PV Wei Liu
2018-10-12 14:12   ` Jan Beulich
2018-10-04 15:43 ` [PATCH 09/17] x86/amd: put setting pv_post_outb_hook under CONFIG_PV Wei Liu
2018-10-12 14:14   ` Jan Beulich
2018-10-15 11:19     ` Roger Pau Monné
2018-10-25  9:22       ` Jan Beulich
2018-10-26 20:21         ` Woods, Brian
2018-10-29 11:41         ` Roger Pau Monné
2018-10-04 15:43 ` [PATCH 10/17] x86: provide stub for switch_compat Wei Liu
2018-10-12 14:33   ` Jan Beulich
2018-10-12 14:36     ` Wei Liu
2018-10-04 15:43 ` [PATCH 11/17] x86: provide stubs for entry point Wei Liu
2018-10-12 14:56   ` Jan Beulich
2018-10-15 10:40     ` Wei Liu
2018-10-16 13:22       ` Andrew Cooper
2018-10-04 15:43 ` [PATCH 12/17] x86: connect guest creation with CONFIG_PV Wei Liu
2018-10-12 15:09   ` Jan Beulich
2018-10-16 16:01     ` Wei Liu
2018-10-04 15:43 ` [PATCH 13/17] x86: don't create Dom0 if neither PV nor HVM is available Wei Liu
2018-10-12 15:12   ` Jan Beulich
2018-10-12 15:28     ` Andrew Cooper
2018-10-12 16:02       ` Wei Liu
2018-10-04 15:43 ` [PATCH 14/17] x86: don't report PV support when !CONFIG_PV Wei Liu
2018-10-12 15:13   ` Jan Beulich
2018-10-04 15:43 ` [PATCH 15/17] x86: expose CONFIG_PV Wei Liu
2018-10-12 15:16   ` Jan Beulich
2018-10-16 16:37     ` Wei Liu
2018-10-04 15:43 ` [PATCH 16/17] x86: introduce new defconfigs for PV and HVM Wei Liu
2018-10-12 15:19   ` Jan Beulich
2018-10-12 15:34     ` Wei Liu [this message]
2018-10-12 15:43       ` Jan Beulich
2018-10-12 17:16         ` Wei Liu
2018-10-04 15:43 ` [PATCH 17/17] automation: build Xen with CONFIG_PV and CONFIG_HVM explicitly set Wei Liu
2018-10-07 18:29   ` Doug Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012153406.u3qqgyq4pwkqoebk@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.