From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v3 1/5] bus/fslmc: fix physical addressing
	check
Date: Sat, 13 Oct 2018 21:38:02 +0530
Message-ID: <20181013160759.GA28993@ltp-pvn>
References: <20181009112548.7025-1-shreyansh.jain@nxp.com>
 <20181013122130.22588-1-shreyansh.jain@nxp.com>
 <20181013122130.22588-2-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>, anatoly.burakov@intel.com,
 hemant.agrawal@nxp.com, ferruh.yigit@intel.com, thomas@monjalon.net
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0078.outbound.protection.outlook.com [104.47.34.78])
 by dpdk.org (Postfix) with ESMTP id 6DE592BE3
 for <dev@dpdk.org>; Sat, 13 Oct 2018 18:08:27 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20181013122130.22588-2-shreyansh.jain@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, Oct 13, 2018 at 05:51:26PM +0530, Shreyansh Jain wrote:
> In case RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is enabled, only supported
> class is RTE_IOVA_PA.
>
> Fixes: f7768afac101 ("bus/fslmc: support dynamic IOVA")
> Cc: hemant.agrawal@nxp.com
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
>  drivers/bus/fslmc/fslmc_bus.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
> index 960f55071..19e33caf1 100644
> --- a/drivers/bus/fslmc/fslmc_bus.c
> +++ b/drivers/bus/fslmc/fslmc_bus.c
> @@ -493,6 +493,10 @@ rte_dpaa2_get_iommu_class(void)
>         bool is_vfio_noiommu_enabled = 1;
>         bool has_iova_va;
>
> +#ifdef RTE_LIBRTE_DPAA2_USE_PHYS_IOVA
> +       return RTE_IOVA_PA;
> +#endif
> +

I think you forgot to move it below the device list check as discussed in
previous patchset? :).

>         if (TAILQ_EMPTY(&rte_fslmc_bus.device_list))
>                 return RTE_IOVA_DC;
>
> --
> 2.17.1
>