Re: [PATCH 5/5] qtnfmac: add support for Topaz chipsets

[Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>]

> > +config QTNFMAC_TOPAZ_PCIE
> > +     tristate "Quantenna QSR1000/QSR2000 PCIe support"
> > +     default n
> > +     depends on PCI && CFG80211
> > +     select QTNFMAC
> > +     select FW_LOADER
> > +     select CRC32
> > +     help
> > +       This option adds support for wireless adapters based on Quantenna
> > +       802.11ac QSR1000/QSR2000 (aka Topaz) FullMAC chipset
> > +       running over PCIe.
> > +
> > +       If you choose to build it as a module, two modules will be built:
> > +       qtnfmac.ko and qtnfmac_pcie.ko.

> I'm not really fond of adding a Kconfig option for every supported
> hardware version unless there are very good reasons (memory savings
> etc). So is this really needed?

Yes, the idea was to save some memory building pcie backend for
the requested chip family only.
 
> A much better approach would be to have a generic QTNFMAC_PCIE option
> which can be used to include or exclude all PCI code.

Ok, sounds reasonable. Three Kconfig options for the single qtnfmac_pcie
module is way too much. We will drop chipset specific Kconfig knobs in
v2, keeping single Kconfig option for qtnfmac_pcie backend as a whole.

Thanks,
Sergey