All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@mellanox.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 11/18] vxlan: Add netif_is_vxlan()
Date: Mon, 15 Oct 2018 22:57:48 +0300	[thread overview]
Message-ID: <20181015195748.GA25940@splinter> (raw)
In-Reply-To: <20181015115756.13b6c0da@cakuba.netronome.com>

On Mon, Oct 15, 2018 at 11:57:56AM -0700, Jakub Kicinski wrote:
> On Sat, 13 Oct 2018 17:18:38 +0000, Ido Schimmel wrote:
> > Add the ability to determine whether a netdev is a VxLAN netdev by
> > calling the above mentioned function that checks the netdev's private
> > flags.
> > 
> > This will allow modules to identify netdev events involving a VxLAN
> > netdev and act accordingly. For example, drivers capable of VxLAN
> > offload will need to configure the underlying device when a VxLAN netdev
> > is being enslaved to an offloaded bridge.
> > 
> > Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> > Reviewed-by: Petr Machata <petrm@mellanox.com>
> 
> Is this preferable over
> 
> !strcmp(netdev->rtnl_link_ops->kind, "vxlan")
> 
> which is what TC offloads do?

Using a flag seemed like the more standard way.

That being said, we considered using net_device_ops instead, given we
are about to run out of available private flags, so I don't mind
adopting a technique already employed by another driver.

P.S. Had to Cc netdev again. I think your client somehow messed the Cc
list? I see Cc list in your reply, but with back slashes at the end of
two email addresses.

  reply	other threads:[~2018-10-16  3:44 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13 17:18 [PATCH net-next 00/18] mlxsw: Add VxLAN support Ido Schimmel
2018-10-13 17:18 ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 01/18] mlxsw: spectrum_fid: Allow setting and clearing NVE properties on FID Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 02/18] mlxsw: spectrum_fid: Add APIs to lookup FID without creating it Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 03/18] mlxsw: spectrum_router: Enable local routes promotion to perform NVE decap Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 04/18] mlxsw: spectrum_router: Allow querying VR ID based on table ID Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 05/18] vxlan: Export address checking functions Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 06/18] inet: Refactor INET_ECN_decapsulate() Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 07/18] mlxsw: spectrum_nve: Implement common NVE core Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 08/18] mlxsw: spectrum_nve: Implement VxLAN operations Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 09/18] mlxsw: spectrum_fid: Clear NVE configuration when destroying 802.1D FIDs Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 10/18] mlxsw: spectrum_router: Configure matching local routes for NVE decap Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 11/18] vxlan: Add netif_is_vxlan() Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-15 18:57   ` Jakub Kicinski
2018-10-15 18:57     ` [Bridge] " Jakub Kicinski
2018-10-15 19:57     ` Ido Schimmel [this message]
2018-10-15 20:16       ` Stephen Hemminger
2018-10-15 20:27         ` Ido Schimmel
2018-10-15 20:30           ` Jakub Kicinski
2018-10-15 20:33             ` Stephen Hemminger
2018-10-13 17:18 ` [PATCH net-next 12/18] vxlan: Add switchdev notifications Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 13/18] vxlan: Add vxlan_fdb_find_uc() for FDB querying Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 14/18] vxlan: Support marking RDSTs as offloaded Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 15/18] vxlan: Notify for each remote of a removed FDB entry Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 16/18] bridge: switchdev: Allow clearing FDB entry offload indication Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 17/18] mlxsw: spectrum: Enable VxLAN enslavement to bridges Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel
2018-10-13 17:18 ` [PATCH net-next 18/18] mlxsw: spectrum_switchdev: Add support for VxLAN encapsulation Ido Schimmel
2018-10-13 17:18   ` [Bridge] " Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181015195748.GA25940@splinter \
    --to=idosch@mellanox.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.