Hi all, After merging the netfilter-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: net/ipv4/netfilter/ipt_ECN.c: In function 'set_ect_tcp': net/ipv4/netfilter/ipt_ECN.c:58:28: error: 'IPT_ECN_OP_SET_ECE' undeclared (first use in this function); did you mean 'IPT_ECN_OP_MATCH_ECE'? if ((!(einfo->operation & IPT_ECN_OP_SET_ECE) || ^~~~~~~~~~~~~~~~~~ IPT_ECN_OP_MATCH_ECE net/ipv4/netfilter/ipt_ECN.c:58:28: note: each undeclared identifier is reported only once for each function it appears in net/ipv4/netfilter/ipt_ECN.c:60:28: error: 'IPT_ECN_OP_SET_CWR' undeclared (first use in this function); did you mean 'IPT_ECN_OP_MATCH_CWR'? (!(einfo->operation & IPT_ECN_OP_SET_CWR) || ^~~~~~~~~~~~~~~~~~ IPT_ECN_OP_MATCH_CWR net/ipv4/netfilter/ipt_ECN.c: In function 'ecn_tg': net/ipv4/netfilter/ipt_ECN.c:84:25: error: 'IPT_ECN_OP_SET_IP' undeclared (first use in this function); did you mean 'IPT_ECN_OP_MATCH_IP'? if (einfo->operation & IPT_ECN_OP_SET_IP) ^~~~~~~~~~~~~~~~~ IPT_ECN_OP_MATCH_IP net/ipv4/netfilter/ipt_ECN.c:88:26: error: 'IPT_ECN_OP_SET_ECE' undeclared (first use in this function); did you mean 'IPT_ECN_OP_MATCH_ECE'? if (einfo->operation & (IPT_ECN_OP_SET_ECE | IPT_ECN_OP_SET_CWR) && ^~~~~~~~~~~~~~~~~~ IPT_ECN_OP_MATCH_ECE net/ipv4/netfilter/ipt_ECN.c:88:47: error: 'IPT_ECN_OP_SET_CWR' undeclared (first use in this function); did you mean 'IPT_ECN_OP_MATCH_CWR'? if (einfo->operation & (IPT_ECN_OP_SET_ECE | IPT_ECN_OP_SET_CWR) && ^~~~~~~~~~~~~~~~~~ IPT_ECN_OP_MATCH_CWR net/ipv4/netfilter/ipt_ECN.c: In function 'ecn_tg_check': net/ipv4/netfilter/ipt_ECN.c:101:25: error: 'IPT_ECN_OP_MASK' undeclared (first use in this function); did you mean 'IPT_ECN_IP_MASK'? if (einfo->operation & IPT_ECN_OP_MASK) ^~~~~~~~~~~~~~~ IPT_ECN_IP_MASK net/ipv4/netfilter/ipt_ECN.c:107:27: error: 'IPT_ECN_OP_SET_ECE' undeclared (first use in this function); did you mean 'IPT_ECN_OP_MATCH_ECE'? if ((einfo->operation & (IPT_ECN_OP_SET_ECE|IPT_ECN_OP_SET_CWR)) && ^~~~~~~~~~~~~~~~~~ IPT_ECN_OP_MATCH_ECE net/ipv4/netfilter/ipt_ECN.c:107:46: error: 'IPT_ECN_OP_SET_CWR' undeclared (first use in this function); did you mean 'IPT_ECN_OP_MATCH_CWR'? if ((einfo->operation & (IPT_ECN_OP_SET_ECE|IPT_ECN_OP_SET_CWR)) && ^~~~~~~~~~~~~~~~~~ IPT_ECN_OP_MATCH_CWR Caused by commit 25038aaf0cbf ("UAPI: netfilter: Fix symbol collision issues [ver #2]") I used the netfilter-next tree from next-20181015 for today. -- Cheers, Stephen Rothwell