From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7A01C04EBD for ; Tue, 16 Oct 2018 15:21:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2E87208B3 for ; Tue, 16 Oct 2018 15:21:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2E87208B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727211AbeJPXMg (ORCPT ); Tue, 16 Oct 2018 19:12:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:40766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbeJPXMf (ORCPT ); Tue, 16 Oct 2018 19:12:35 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFE2B2086E; Tue, 16 Oct 2018 15:21:38 +0000 (UTC) Date: Tue, 16 Oct 2018 11:21:36 -0400 From: Steven Rostedt To: Jiri Olsa Cc: lkml , Tzvetomir Stoyanov , "Herton R. Krzesinski" Subject: Re: [PATCH 01/10] tools lib traceevent: Use LDFLAGS in the build commands Message-ID: <20181016112136.3a72a452@gandalf.local.home> In-Reply-To: <20181016150614.21260-2-jolsa@kernel.org> References: <20181016150614.21260-1-jolsa@kernel.org> <20181016150614.21260-2-jolsa@kernel.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Oct 2018 17:06:06 +0200 Jiri Olsa wrote: > So user could specify outside LDFLAGS values. > > Cc: Tzvetomir Stoyanov (VMware) > Cc: Steven Rostedt > Signed-off-by: Jiri Olsa > --- > tools/lib/traceevent/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile > index 0b4e833088a4..e535073c94ce 100644 > --- a/tools/lib/traceevent/Makefile > +++ b/tools/lib/traceevent/Makefile > @@ -174,7 +174,7 @@ $(TE_IN): force > $(Q)$(MAKE) $(build)=libtraceevent > > $(OUTPUT)libtraceevent.so.$(EVENT_PARSE_VERSION): $(TE_IN) > - $(QUIET_LINK)$(CC) --shared $^ -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@ > + $(QUIET_LINK)$(CC) --shared $(LDFLAGS) $^ -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@ > @ln -sf $(@F) $(OUTPUT)libtraceevent.so > @ln -sf $(@F) $(OUTPUT)libtraceevent.so.$(EP_VERSION) > > @@ -193,7 +193,7 @@ $(PLUGINS_IN): force > $(Q)$(MAKE) $(build)=$(plugin_obj) > > $(OUTPUT)%.so: $(OUTPUT)%-in.o > - $(QUIET_LINK)$(CC) $(CFLAGS) -shared -nostartfiles -o $@ $^ > + $(QUIET_LINK)$(CC) -shared $(LDFLAGS) -nostartfiles -o $@ $^ I'm guessing that the CFLAGS are not needed here, but shouldn't that also be mentioned in the change log? -- Steve > > define make_version.h > (echo '/* This file is automatically generated. Do not modify. */'; \