From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors Date: Tue, 16 Oct 2018 16:28:09 +0300 Message-ID: <20181016132809.GF9144@intel.com> References: <20181016094045.23021-1-boris.brezillon@bootlin.com> <20181016125743.GZ31561@phenom.ffwll.local> <20181016151045.76944938@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 533DF6E22C for ; Tue, 16 Oct 2018 13:28:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Boris Brezillon , gordon@raspberrypi.org, dri-devel , eben@raspberrypi.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMDM6MTI6NTRQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIE9jdCAxNiwgMjAxOCBhdCAzOjEwIFBNIEJvcmlzIEJyZXppbGxvbgo+ IDxib3Jpcy5icmV6aWxsb25AYm9vdGxpbi5jb20+IHdyb3RlOgo+ID4KPiA+IEhpIERhbmllbCwK PiA+Cj4gPiBPbiBUdWUsIDE2IE9jdCAyMDE4IDE0OjU3OjQzICswMjAwCj4gPiBEYW5pZWwgVmV0 dGVyIDxkYW5pZWxAZmZ3bGwuY2g+IHdyb3RlOgo+ID4KPiA+ID4gT24gVHVlLCBPY3QgMTYsIDIw MTggYXQgMTE6NDA6NDVBTSArMDIwMCwgQm9yaXMgQnJlemlsbG9uIHdyb3RlOgo+ID4gPiA+IFRo ZSBIVlMgYmxvY2sgaXMgc3VwcG9zZWQgdG8gZmlsbCB0aGUgcGl4ZWx2YWx2ZSBGSUZPcyBmYXN0 IGVub3VnaCB0bwo+ID4gPiA+IG1lZXQgdGhlIHJlcXVlc3RlZCBmcmFtZXJhdGUuIFRoZSBwcm9i bGVtIGlzLCB0aGUgSFZTIGFuZCBtZW1vcnkgYnVzCj4gPiA+ID4gYmFuZHdpZHRocyBhcmUgbGlt aXRlZCwgYW5kIGlmIHdlIGRvbid0IHRha2UgdGhlc2UgbGltaXRhdGlvbnMgaW50bwo+ID4gPiA+ IGFjY291bnQgd2UgbWlnaHQgZW5kIHVwIHdpdGggSFZTIHVuZGVyZmxvdyBlcnJvcnMuCj4gPiA+ ID4KPiA+ID4gPiBUaGlzIHBhdGNoIGlzIHRyeWluZyB0byBtb2RlbCB0aGUgcGVyLXBsYW5lIEhW UyBhbmQgbWVtb3J5IGJ1cyBiYW5kd2lkdGgKPiA+ID4gPiBjb25zdW1wdGlvbiBhbmQgdGFrZSBh IGRlY2lzaW9uIGF0IGF0b21pY19jaGVjaygpIHRpbWUgd2hldGhlciB0aGUKPiA+ID4gPiBlc3Rp bWF0ZWQgbG9hZCB3aWxsIGZpdCBpbiB0aGUgSFZTIGFuZCBtZW1idXMgYnVkZ2V0Lgo+ID4gPiA+ Cj4gPiA+ID4gTm90ZSB0aGF0IHdlIHRha2UgYW4gZXh0cmEgbWFyZ2luIG9uIHRoZSBtZW1vcnkg YnVzIGNvbnN1bXB0aW9uIHRvIGxldAo+ID4gPiA+IHRoZSBzeXN0ZW0gcnVuIHNtb290aGx5IHdo ZW4gb3RoZXIgYmxvY2tzIGFyZSBkb2luZyBoZWF2eSB1c2Ugb2YgdGhlCj4gPiA+ID4gbWVtb3J5 IGJ1cy4gU2FtZSBnb2VzIGZvciB0aGUgSFZTIGxpbWl0LCBleGNlcHQgdGhlIG1hcmdpbiBpcyBz bWFsbGVyIGluCj4gPiA+ID4gdGhpcyBjYXNlLCBzaW5jZSB0aGUgSFZTIGlzIG5vdCB1c2VkIGJ5 IGV4dGVybmFsIGNvbXBvbmVudHMuCj4gPiA+ID4KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBCb3Jp cyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBib290bGluLmNvbT4KPiA+ID4gPiAtLS0KPiA+ ID4gPiBUaGlzIGxvZ2ljIGhhcyBiZWVuIHZhbGlkYXRlZCB1c2luZyBhIHNpbXBsZSBzaGVsbCBz Y3JpcHQgYW5kCj4gPiA+ID4gc29tZSBpbnN0cnVtZW50YXRpb24gaW4gdGhlIFZDNCBkcml2ZXI6 Cj4gPiA+ID4KPiA+ID4gPiAtIGNhcHR1cmUgdW5kZXJmbG93IGVycm9ycyBhdCB0aGUgSFZTIGxl dmVsIGFuZCBleHBvc2UgYSBkZWJ1Z2ZzIGZpbGUKPiA+ID4gPiAgIHJlcG9ydGluZyB0aG9zZSBl cnJvcnMKPiA+ID4gPiAtIGFkZCBkZWJ1Z2ZzIGZpbGVzIHRvIGV4cG9zZSB3aGVuIGF0b21pY19j aGVjayBmYWlscyBiZWNhdXNlIG9mIHRoZQo+ID4gPiA+ICAgSFZTIG9yIG1lbWJ1cyBsb2FkIGxp bWl0YXRpb24gb3Igd2hlbiBpdCBmYWlscyBmb3Igb3RoZXIgcmVhc29ucwo+ID4gPiA+Cj4gPiA+ ID4gVGhlIGJyYW5jaCBjb250YWluaW5nIHRob3NlIG1vZGlmaWNhdGlvbiBpcyBhdmFpbGFibGUg aGVyZSBbMV0sIGFuZCB0aGUKPiA+ID4gPiBzY3JpcHQgKHdoaWNoIGlzIGludGVybmFsbHkgdXNp bmcgbW9kZXRlc3QpIGlzIGhlcmUgWzJdIChwbGVhc2Ugbm90ZQo+ID4gPiA+IHRoYXQgSSdtIGJh ZCBhdCB3cml0aW5nIHNoZWxsIHNjcmlwdHMgOi0pKS4KPiA+ID4gPgo+ID4gPiA+IE5vdGUgdGhh dCB0aG9zZSBtb2RpZmljYXRpb24gdGVuZCB0byBvdmVyLWVzdGltYXRlIHRoZSBsb2FkLCBhbmQg dGh1cwo+ID4gPiA+IHJlamVjdCBzZXR1cHMgdGhhdCBtaWdodCBoYXZlIHByZXZpb3VzbHkgd29y a2VkLCBzbyB3ZSBtaWdodCB3YW50IHRvCj4gPiA+ID4gYWRqdXN0IHRoZSBsaW1pdHMgdG8gYXZv aWQgdGhhdC4KPiA+ID4gPgo+ID4gPiA+IFsxXWh0dHBzOi8vZ2l0aHViLmNvbS9iYnJlemlsbG9u L2xpbnV4L3RyZWUvdmM0L2h2cy1iYW5kd2lkdGgtZXZhbAo+ID4gPiA+IFsyXWh0dHBzOi8vZ2l0 aHViLmNvbS9iYnJlemlsbG9uL3ZjNC1odnMtYmFuZHdpZHRoLXRlc3QKPiA+ID4KPiA+ID4gQW55 IGludGVyZXN0IGluIHVzaW5nIGlndCB0byB0ZXN0IHRoaXMgc3R1ZmY/IFdlIGhhdmUgYXQgbGVh c3QgYSBidW5jaCBvZgo+ID4gPiB0ZXN0cyBhbHJlYWR5IGluIHRoZXJlIHRoYXQgdHJ5IGFsbCBr aW5kcyBvZiBwbGFuZSBzZXR1cHMuIEFuZCB3ZSB1c2UKPiA+ID4gdGhvc2UgdG8gaHVudCBmb3Ig dW5kZXJydW5zIG9uIGk5MTUgaHcuCj4gPiA+Cj4gPiA+IFdydCB1bmRlcnJ1biByZXBvcnRpbmc6 IE9uIGk5MTUgd2UganVzdCBkdW1wIHRoZW0gaW50byBkbWVzZyBhdCB0aGUgZXJyb3IKPiA+ID4g bGV2ZWwsIHVzaW5nIERSTV9FUlJPUiwgcGx1cyBhIHRyYWNlcG9pbnQuIFNlZSBlLmcuCj4gPiA+ IGludGVsX3BjaF9maWZvX3VuZGVycnVuX2lycV9oYW5kbGVyKCkuIElmIHRoZXJlJ3MgaW50ZXJl c3Qgd2UgY291bGQKPiA+ID4gcGVyaGFwcyBleHRyYWN0IHRoaXMgaW50byBzb21ldGhpbmcgY29t bW9uLCBzaW1pbGFyIHRvIHdoYXQgd2FzIGRvbmUgd2l0aAo+ID4gPiBjcmMgc3VwcG9ydCBhbHJl YWR5Lgo+ID4KPiA+IFNvdW5kcyBsaWtlIGEgZ29vZCBpZGVhLiBJJ2xsIGhhdmUgYSBsb29rIGF0 IHdoYXQncyBkb25lIGluIHRoZSBpbnRlbAo+ID4gZHJpdmVyIGFuZCB3aWxsIGNoZWNrIGhvdyBm ZWFzaWJsZSB0aGlzIGlzIHRvIGhhdmUgYSBjb21tb24KPiA+IGluZnJhc3RydWN0dXJlIHRvIHRl c3QgdGhhdCBpbiBpZ3QuCj4gPgo+ID4gVGhhbmtzIGZvciB0aGUgcG9pbnRlcnMuCj4gPgo+ID4K PiA+ID4gPiArc3RhdGljIGludCB2YzRfbG9hZF90cmFja2VyX2F0b21pY19jaGVjayhzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPiA+ID4gK3sKPiA+ID4gPiArICAgc3RydWN0IGRy bV9wbGFuZV9zdGF0ZSAqb2xkX3BsYW5lX3N0YXRlLCAqbmV3X3BsYW5lX3N0YXRlOwo+ID4gPiA+ ICsgICBzdHJ1Y3QgdmM0X2RldiAqdmM0ID0gdG9fdmM0X2RldihzdGF0ZS0+ZGV2KTsKPiA+ID4g PiArICAgc3RydWN0IHZjNF9sb2FkX3RyYWNrZXJfc3RhdGUgKmxvYWRfc3RhdGU7Cj4gPiA+ID4g KyAgIHN0cnVjdCBkcm1fcHJpdmF0ZV9zdGF0ZSAqcHJpdl9zdGF0ZTsKPiA+ID4gPiArICAgc3Ry dWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gPiA+ID4gKyAgIGludCByZXQsIGk7Cj4gPiA+ID4gKwo+ ID4gPgo+ID4gPiBZb3UncmUgbWlzc2luZyB0aGUgbW9kZXNldCBsb2NraW5nIGZvciB2YzQtPmxv YWRfdHJhY2tlci4gU2VlIHRoZQo+ID4gPiBrZXJuZWxkb2MgZm9yIGRybV9hdG9taWNfZ2V0X3By aXZhdGVfb2JqX3N0YXRlKCkuCj4gPgo+ID4gSG0sIEkgbWlzc2VkIHRoaXMgcGFydCBvZiB0aGUg ZG9jLCBhbmQgSSB0aG91Z2h0IHdlIHdlcmUgcHJvdGVjdGVkIGJ5Cj4gPiB0aGUgbW9kZXNldCBs b2NrLgo+ID4KPiA+ID4gUHJvYmFibHkgYSBnb29kIHRpbWUgdG8KPiA+ID4gaW1wbGVtZW50IHRo ZSBsb2NraW5nIHJlZmFjdG9yaW5nIGlkZWEgSSBoYXZlIGFuZCBqdXN0IGltcGxlbWVudCBhIHBl cgo+ID4gPiBwcml2YXRlX29iaiBsb2NrLCBhbmQgcmVtb3ZlIGFsbCB0aGUgYWQtaG9jIGxvY2tp bmcgZnJvbSBhbGwgdGhlIGNhbGxlcnM/Cj4gPgo+ID4gTGV0IG1lIHNlZSBpZiBJIGdldCBpdCBj b3JyZWN0bHkuIFlvdSB3YW50IHRvIGFkZCBhIGxvY2sgdG8gdGhlCj4gPiBkcm1fcHJpdmF0ZV9v Ymogc3RydWN0LCByaWdodD8KPiAKPiBZdXAsIHBsdXMgYXV0b21hdGljYWxseSBncmFiIHRoYXQg bG9jayBpbiBnZXRfcHJpdmF0ZV9vYmpfc3RhdGUsIGFuZAo+IHRoZW4gZHJvcCB0aGUgbm93IHN1 cGVyZmx1b3VzIGxvY2tpbmcgZnJvbSBhbGwgdGhlIGNhbGxlcnMuCgpZb3UgbWVhbiB0aGlzPwpo dHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvMjA1OTQzLwoKLS0gClZpbGxl IFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK