From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:39874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbeJPVvv (ORCPT ); Tue, 16 Oct 2018 17:51:51 -0400 Date: Tue, 16 Oct 2018 16:01:12 +0200 From: Greg KH To: Roman Gushchin Cc: "akpm@linux-foundation.org" , "hannes@cmpxchg.org" , "mhocko@suse.com" , "torvalds@linux-foundation.org" , "viro@zeniv.linux.org.uk" , "stable@vger.kernel.org" Subject: Re: FAILED: patch "[PATCH] mm: treat indirectly reclaimable memory as free in overcommit" failed to apply to 4.16-stable tree Message-ID: <20181016140112.GE20256@kroah.com> References: <1526132159220203@kroah.com> <20180514104553.GA28956@castle> <20181011142746.GE9507@kroah.com> <20181011210409.GA4320@tower.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181011210409.GA4320@tower.DHCP.thefacebook.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Oct 11, 2018 at 09:04:17PM +0000, Roman Gushchin wrote: > On Thu, Oct 11, 2018 at 04:27:46PM +0200, Greg KH wrote: > > On Mon, May 14, 2018 at 11:46:00AM +0100, Roman Gushchin wrote: > > > On Sat, May 12, 2018 at 03:35:59PM +0200, gregkh@linuxfoundation.org wrote: > > > > > > > > The patch below does not apply to the 4.16-stable tree. > > > > If someone wants it applied there, or to any other stable or longterm > > > > tree, then please email the backport, including the original git commit > > > > id to . > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Hi, Greg! > > > > > > This patch is a part of the following patchset: > > > 7aaf77272358 mm: don't show nr_indirectly_reclaimable in /proc/vmstat > > > d79f7aa496fc mm: treat indirectly reclaimable memory as free in overcommit logic > > > f1782c9bc547 dcache: account external names as indirectly reclaimable memory > > > 034ebf65c3c2 mm: treat indirectly reclaimable memory as available in MemAvailable > > > eb59254608bc mm: introduce NR_INDIRECTLY_RECLAIMABLE_BYTES > > > > > > It should be backported as a whole. It applies cleanly on 4.16-stable, > > > and with a minor trivial adjustment to 4.14-stable. > > > > Sorry for the long delay, digging out of my stable backlog... > > > > Anyway, is this still needed for 4.14-stable? > > There is a security issue, which these patches are closing. It allows to cause > a system-wide memory allocation failure, if overcommit logic is enabled and > it's possible to create negative dentries (e.g. asking httpd for non-existing > files). The issue is very old and exists in most stable branches, so Idk how > bad is to leave it open in 4.14. > Anyway, please, let me know if I can help somehow. Ok, all now queued up, let's see how it goes :) thanks, greg k-h