From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 16 Oct 2018 11:17:27 -0400 From: Mike Snitzer To: Damien Le Moal Cc: linux-block@vger.kernel.org, Jens Axboe , linux-scsi@vger.kernel.org, "Martin K . Petersen" , dm-devel@redhat.com, Christoph Hellwig , Matias Bjorling Subject: Re: [PATCH v4 10/11] block: add a report_zones method Message-ID: <20181016151727.GA26807@redhat.com> References: <20181012100850.23316-1-damien.lemoal@wdc.com> <20181012100850.23316-11-damien.lemoal@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20181012100850.23316-11-damien.lemoal@wdc.com> List-ID: On Fri, Oct 12 2018 at 6:08am -0400, Damien Le Moal wrote: > From: Christoph Hellwig > > Dispatching a report zones command through the request queue is a major > pain due to the command reply payload rewriting necessary. Given that > blkdev_report_zones() is executing everything synchronously, implement > report zones as a block device file operation instead, allowing major > simplification of the code in many places. > > sd, null-blk, dm-linear and dm-flakey being the only block device > drivers supporting exposing zoned block devices, these drivers are > modified to provide the device side implementation of the > report_zones() block device file operation. > > For device mappers, a new report_zones() target type operation is > defined so that the upper block layer calls blkdev_report_zones() can > be propagated down to the underlying devices of the dm targets. > Implementation for this new operation is added to the dm-linear and > dm-flakey targets. > > Signed-off-by: Christoph Hellwig > [Damien] > * Changed method block_device argument to gendisk > * Various bug fixes and improvements > * Added support for null_blk, dm-linear and dm-flakey. > Signed-off-by: Damien Le Moal > Reviewed-by: Hannes Reinecke Reviewed-by: Mike Snitzer From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH v4 10/11] block: add a report_zones method Date: Tue, 16 Oct 2018 11:17:27 -0400 Message-ID: <20181016151727.GA26807@redhat.com> References: <20181012100850.23316-1-damien.lemoal@wdc.com> <20181012100850.23316-11-damien.lemoal@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181012100850.23316-11-damien.lemoal@wdc.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Damien Le Moal Cc: Jens Axboe , linux-scsi@vger.kernel.org, "Martin K . Petersen" , linux-block@vger.kernel.org, dm-devel@redhat.com, Christoph Hellwig , Matias Bjorling List-Id: linux-scsi@vger.kernel.org On Fri, Oct 12 2018 at 6:08am -0400, Damien Le Moal wrote: > From: Christoph Hellwig > > Dispatching a report zones command through the request queue is a major > pain due to the command reply payload rewriting necessary. Given that > blkdev_report_zones() is executing everything synchronously, implement > report zones as a block device file operation instead, allowing major > simplification of the code in many places. > > sd, null-blk, dm-linear and dm-flakey being the only block device > drivers supporting exposing zoned block devices, these drivers are > modified to provide the device side implementation of the > report_zones() block device file operation. > > For device mappers, a new report_zones() target type operation is > defined so that the upper block layer calls blkdev_report_zones() can > be propagated down to the underlying devices of the dm targets. > Implementation for this new operation is added to the dm-linear and > dm-flakey targets. > > Signed-off-by: Christoph Hellwig > [Damien] > * Changed method block_device argument to gendisk > * Various bug fixes and improvements > * Added support for null_blk, dm-linear and dm-flakey. > Signed-off-by: Damien Le Moal > Reviewed-by: Hannes Reinecke Reviewed-by: Mike Snitzer