From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes
Date: Tue, 16 Oct 2018 15:27:48 -0700 [thread overview]
Message-ID: <20181016152748.28b6df15a0410447c3abdc2a@linux-foundation.org> (raw)
In-Reply-To: <20181016084923.GH5819@techsingularity.net>
On Tue, 16 Oct 2018 09:49:23 +0100 Mel Gorman <mgorman@techsingularity.net> wrote:
> > Can we do this?
> >
> > --- a/mm/workingset.c~mm-workingset-add-vmstat-counter-for-shadow-nodes-fix
> > +++ a/mm/workingset.c
> > @@ -377,6 +377,8 @@ void workingset_update_node(struct radix
> > * already where they should be. The list_empty() test is safe
> > * as node->private_list is protected by the i_pages lock.
> > */
> > + WARN_ON_ONCE(!irqs_disabled()); /* For __inc_lruvec_page_state */
> > +
> > if (node->count && node->count == node->exceptional) {
> > if (list_empty(&node->private_list)) {
> > list_lru_add(&shadow_nodes, &node->private_list);
>
> Note that for whatever reason, I've observed that irqs_disabled() is
> actually quite an expensive call. I'm not saying the warning is a bad
> idea but it should not be sprinkled around unnecessary and may be more
> suitable as a debug option.
Yup, it is now VM_WARN_ON_ONCE().
next prev parent reply other threads:[~2018-10-16 22:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 18:47 [PATCH 0/4] mm: workingset & shrinker fixes Johannes Weiner
2018-10-09 18:47 ` [PATCH 1/4] mm: workingset: don't drop refault information prematurely fix Johannes Weiner
2018-10-10 0:55 ` Rik van Riel
2018-10-09 18:47 ` [PATCH 2/4] mm: workingset: use cheaper __inc_lruvec_state in irqsafe node reclaim Johannes Weiner
2018-10-10 0:55 ` Rik van Riel
2018-10-09 18:47 ` [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes Johannes Weiner
2018-10-09 22:04 ` Andrew Morton
2018-10-10 14:02 ` Johannes Weiner
2018-10-09 22:08 ` Andrew Morton
2018-10-10 15:05 ` Johannes Weiner
2018-10-16 8:49 ` Mel Gorman
2018-10-16 22:27 ` Andrew Morton [this message]
2018-10-09 18:47 ` [PATCH 4/4] mm: zero-seek shrinkers Johannes Weiner
2018-10-09 22:15 ` Andrew Morton
2018-10-09 22:17 ` Andrew Morton
2018-10-10 1:03 ` Rik van Riel
2018-10-10 15:15 ` Johannes Weiner
2018-10-12 13:48 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016152748.28b6df15a0410447c3abdc2a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=riel@redhat.com \
--subject='Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.