All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Align cpu map events properly.
Date: Tue, 16 Oct 2018 12:29:25 -0300	[thread overview]
Message-ID: <20181016152925.GD3849@kernel.org> (raw)
In-Reply-To: <20181011.224655.716771175766946817.davem@davemloft.net>

Em Thu, Oct 11, 2018 at 10:46:55PM -0700, David Miller escreveu:
> The size of the resulting cpu map can be smaller than a multiple
> of sizeof(u64), resulting in SIGBUS on cpus like Sparc as the
> next event will not be aligned properly.
> 
> Fixes: 6c872901af07 ("perf cpu_map: Add cpu_map event synthesize function")
> Signed-off-by: David S. Miller <davem@davemloft.net>

Thanks, applied to perf/urgent.

- Arnaldo
 
> diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> index 0cd42150f712..0988eb3b844b 100644
> --- a/tools/perf/util/event.c
> +++ b/tools/perf/util/event.c
> @@ -1081,6 +1081,7 @@ void *cpu_map_data__alloc(struct cpu_map *map, size_t *size, u16 *type, int *max
>  	}
>  
>  	*size += sizeof(struct cpu_map_data);
> +	*size = PERF_ALIGN(*size, sizeof(u64));
>  	return zalloc(*size);
>  }
>  

  reply	other threads:[~2018-10-16 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12  5:46 [PATCH] perf: Align cpu map events properly David Miller
2018-10-16 15:29 ` Arnaldo Carvalho de Melo [this message]
2018-10-18  6:19 ` [tip:perf/urgent] perf cpu_map: Align cpu map synthesized " tip-bot for David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181016152925.GD3849@kernel.org \
    --to=acme@kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.