From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v6 1/2] bus/pci: harmonize and document rte_pci_read_config return value Date: Wed, 17 Oct 2018 11:57:38 +0100 Message-ID: <20181017105737.GA22712@bricha3-MOBL.ger.corp.intel.com> References: <20180827165240.28322-1-bluca@debian.org> <20180828101240.12597-1-bluca@debian.org> <1539770338.25451.7.camel@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Luca Boccassi Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8F87E1B136 for ; Wed, 17 Oct 2018 12:57:42 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1539770338.25451.7.camel@debian.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 17, 2018 at 10:58:58AM +0100, Luca Boccassi wrote: > On Tue, 2018-08-28 at 11:12 +0100, Luca Boccassi wrote: > > On Linux, rte_pci_read_config on success returns the number of read > > bytes, but on BSD it returns 0. > > Document the return values, and have BSD behave as Linux does. > > > > At least one case (bnx2x PMD) treats 0 as an error, so the change > > makes sense also for that. > > > > Signed-off-by: Luca Boccassi > > --- Acked-by: Bruce Richardson