From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [PATCH bpf-next 0/3] improve and fix barriers for walking perf rb Date: Wed, 17 Oct 2018 12:03:01 -0300 Message-ID: <20181017150301.GC4041@redhat.com> References: <20181017144156.16639-1-daniel@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: alexei.starovoitov@gmail.com, peterz@infradead.org, paulmck@linux.vnet.ibm.com, will.deacon@arm.com, yhs@fb.com, john.fastabend@gmail.com, netdev@vger.kernel.org To: Daniel Borkmann Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55722 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727047AbeJQW7K (ORCPT ); Wed, 17 Oct 2018 18:59:10 -0400 Content-Disposition: inline In-Reply-To: <20181017144156.16639-1-daniel@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: Em Wed, Oct 17, 2018 at 04:41:53PM +0200, Daniel Borkmann escreveu: > This set first adds smp_* barrier variants to tools infrastructure > and in a second step updates perf and libbpf to make use of them. > For details, please see individual patches, thanks! > > Arnaldo, if there are no objections, could this be routed via bpf-next > with Acked-by's due to later dependencies in libbpf? Alternatively, > I could also get the 2nd patch out during merge window, but perhaps > it's okay to do in one go as there shouldn't be much conflict in perf. Right, when updating kernel/events/ring_buffer.c the corresponding code in tools/ should've been changed :-) Acked-by: Arnaldo Carvalho de Melo - Arnaldo > Thanks! > > Daniel Borkmann (3): > tools: add smp_* barrier variants to include infrastructure > tools, perf: use smp_{rmb,mb} barriers instead of {rmb,mb} > bpf, libbpf: use proper barriers in perf ring buffer walk > > tools/arch/arm64/include/asm/barrier.h | 10 ++++++++++ > tools/arch/x86/include/asm/barrier.h | 9 ++++++--- > tools/include/asm/barrier.h | 11 +++++++++++ > tools/lib/bpf/libbpf.c | 25 +++++++++++++++++++------ > tools/perf/util/mmap.h | 5 +++-- > 5 files changed, 49 insertions(+), 11 deletions(-) > > -- > 2.9.5