From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: ipmr: fix unresolved entry dumps Date: Thu, 18 Oct 2018 16:46:29 -0700 (PDT) Message-ID: <20181018.164629.99095073835498552.davem@davemloft.net> References: <20181017193434.11383-1-nikolay@cumulusnetworks.com> <20181017.223629.857704876875928943.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nikolay@cumulusnetworks.com, netdev@vger.kernel.org To: dsahern@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:42916 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726784AbeJSHtu (ORCPT ); Fri, 19 Oct 2018 03:49:50 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Thu, 18 Oct 2018 09:16:17 -0600 > On 10/17/18 11:36 PM, David Miller wrote: >> From: Nikolay Aleksandrov >> Date: Wed, 17 Oct 2018 22:34:34 +0300 >> >>> If the skb space ends in an unresolved entry while dumping we'll miss >>> some unresolved entries. The reason is due to zeroing the entry counter >>> between dumping resolved and unresolved mfc entries. We should just >>> keep counting until the whole table is dumped and zero when we move to >>> the next as we have a separate table counter. >>> >>> Reported-by: Colin Ian King >>> Fixes: 8fb472c09b9d ("ipmr: improve hash scalability") >>> Signed-off-by: Nikolay Aleksandrov >> >> Applied and queued up for -stable. >> > > FYI: on the net to net-next merge, those 2 lines were moved to > mr_table_dump. Thanks for the heads up.