From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH v5 0/6] ethdev port freeing Date: Thu, 18 Oct 2018 03:23:56 +0200 Message-ID: <20181018012402.1240-1-thomas@monjalon.net> References: <20180907233929.21950-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, ophirmu@mellanox.com, bernard.iremonger@intel.com, rahul.lakkireddy@chelsio.com To: ferruh.yigit@intel.com, arybchenko@solarflare.com Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8BD045F62 for ; Thu, 18 Oct 2018 03:24:07 +0200 (CEST) In-Reply-To: <20180907233929.21950-1-thomas@monjalon.net> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function rte_eth_dev_detach() is freeing a port and its underlying rte_device object. The issue is that we may have several ports associated to the same rte_device. The right replacement is to free the port, and free the rte_device if no more ports. At ethdev level, the public function for port freeing is rte_eth_dev_close(). The only miss is rte_eth_dev_release_port() to free all port resources. This patchset does a cleanup by moving as much ethdev data freeing as possible in an unique function rte_eth_dev_release_port(), and call this function in rte_eth_dev_close(). Changes in v5: - fix testpmd for detaching multi-ports device - fix testpmd for detaching only stopped ports - add a release note about closed port freeing and state - fix some doxygen comments in rte_eth_dev_data - improve doxygen of rte_eth_dev_release_port() - fix data freeing in some drivers Changes in v4: - do not free data fields which are not dynamically allocated blocks - remove rte_eth_dev_release_port_secondary() - remove testpmd check to detach without closing Changes in v3: - free queues, MAC addresses and private structure in rte_eth_dev_release_port. Thomas Monjalon (5): app/testpmd: allow detaching a port not closed ethdev: fix doxygen comments of shared data fields ethdev: free all common data when releasing port ethdev: remove release function for secondary process ethdev: complete closing of port Wisam Jaddo (1): app/testpmd: fix ports list after removing several at once app/test-pmd/testpmd.c | 64 +++++++++++++---------- doc/guides/rel_notes/release_18_11.rst | 4 ++ drivers/net/af_packet/rte_eth_af_packet.c | 11 ++-- drivers/net/ark/ark_ethdev.c | 1 - drivers/net/avf/avf_ethdev.c | 3 -- drivers/net/avp/avp_ethdev.c | 5 -- drivers/net/axgbe/axgbe_ethdev.c | 3 -- drivers/net/bnxt/bnxt_ethdev.c | 8 --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++-- drivers/net/cxgbe/cxgbe_main.c | 16 +----- drivers/net/cxgbe/cxgbevf_main.c | 9 +--- drivers/net/dpaa/dpaa_ethdev.c | 10 ---- drivers/net/dpaa2/dpaa2_ethdev.c | 10 ---- drivers/net/e1000/em_ethdev.c | 3 -- drivers/net/e1000/igb_ethdev.c | 6 --- drivers/net/enetc/enetc_ethdev.c | 4 +- drivers/net/failsafe/failsafe.c | 6 ++- drivers/net/failsafe/failsafe_ops.c | 2 + drivers/net/fm10k/fm10k_ethdev.c | 8 --- drivers/net/i40e/i40e_ethdev.c | 3 -- drivers/net/i40e/i40e_ethdev_vf.c | 3 -- drivers/net/i40e/i40e_vf_representor.c | 5 +- drivers/net/ixgbe/ixgbe_ethdev.c | 9 ---- drivers/net/ixgbe/ixgbe_vf_representor.c | 5 +- drivers/net/kni/rte_eth_kni.c | 7 +-- drivers/net/liquidio/lio_ethdev.c | 3 -- drivers/net/mlx4/mlx4.c | 9 +++- drivers/net/mlx5/mlx5.c | 13 +++-- drivers/net/mvneta/mvneta_ethdev.c | 16 ++---- drivers/net/mvpp2/mrvl_ethdev.c | 16 ++---- drivers/net/netvsc/hn_ethdev.c | 20 +++---- drivers/net/null/rte_eth_null.c | 7 ++- drivers/net/octeontx/octeontx_ethdev.c | 31 +++++------ drivers/net/pcap/rte_eth_pcap.c | 19 ++++--- drivers/net/qede/qede_ethdev.c | 5 -- drivers/net/ring/rte_eth_ring.c | 6 +-- drivers/net/sfc/sfc_ethdev.c | 3 -- drivers/net/softnic/rte_eth_softnic.c | 10 ++-- drivers/net/szedata2/rte_eth_szedata2.c | 1 - drivers/net/tap/rte_eth_tap.c | 11 +++- drivers/net/vhost/rte_eth_vhost.c | 15 ++---- drivers/net/virtio/virtio_ethdev.c | 3 -- drivers/net/virtio/virtio_user_ethdev.c | 3 -- drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 -- lib/librte_ethdev/rte_ethdev.c | 45 +++++----------- lib/librte_ethdev/rte_ethdev.h | 3 +- lib/librte_ethdev/rte_ethdev_core.h | 38 ++++++++------ lib/librte_ethdev/rte_ethdev_driver.h | 23 +++----- lib/librte_ethdev/rte_ethdev_pci.h | 17 ------ lib/librte_ethdev/rte_ethdev_version.map | 7 --- 50 files changed, 196 insertions(+), 347 deletions(-) -- 2.19.0