From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Michael Schmitz <schmitzmic@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: add Buddha PATA controller driver
Date: Thu, 18 Oct 2018 15:12:08 +0200 [thread overview]
Message-ID: <20181018131210eucas1p14a11ec7555ca9ef3003387f1985326e6~ethZ7giWB0310803108eucas1p1X@eucas1p1.samsung.com> (raw)
In-Reply-To: <20181018124118.GA10376@infradead.org>
On 10/18/2018 02:41 PM, Christoph Hellwig wrote:
>> +static int __init pata_buddha_init_one(void)
>> +{
>> + struct zorro_dev *z = NULL;
>> +
>> + while ((z = zorro_find_device(ZORRO_WILDCARD, z))) {
>
> I'm not really an m68k expert, but shouldn't this implement a
> struct zorro_driver instead? (or maybe two of them as xsurf
> seems sufficiently different).
I didn't want to introduce too many changes over old IDE's
driver in the initial version of the libata driver as
I can't test them myself. Once the new driver is verified
to work I plan to convert it into proper Zorro_driver.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2018-10-18 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181018122951eucas1p2be43dc17df8d2c754e771785b3ad7457@eucas1p2.samsung.com>
2018-10-18 12:29 ` [PATCH] ata: add Buddha PATA controller driver Bartlomiej Zolnierkiewicz
2018-10-18 12:32 ` John Paul Adrian Glaubitz
2018-10-18 22:40 ` Michael Schmitz
2018-10-18 12:41 ` Christoph Hellwig
2018-10-18 13:12 ` Bartlomiej Zolnierkiewicz [this message]
2018-10-18 14:03 ` Geert Uytterhoeven
2018-10-18 23:49 ` Michael Schmitz
2018-10-25 19:38 ` John Paul Adrian Glaubitz
2018-10-31 10:06 ` John Paul Adrian Glaubitz
2018-11-01 4:53 ` Michael Schmitz
2018-11-01 7:30 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20181018131210eucas1p14a11ec7555ca9ef3003387f1985326e6~ethZ7giWB0310803108eucas1p1X@eucas1p1.samsung.com' \
--to=b.zolnierkie@samsung.com \
--cc=axboe@kernel.dk \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.