From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gD9K5-0005Fo-07 for mharc-grub-devel@gnu.org; Thu, 18 Oct 2018 10:30:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD9K2-0005ES-ED for grub-devel@gnu.org; Thu, 18 Oct 2018 10:30:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gD9Jy-0005uu-Ce for grub-devel@gnu.org; Thu, 18 Oct 2018 10:30:46 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:48868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gD9Jy-0005qX-1n for grub-devel@gnu.org; Thu, 18 Oct 2018 10:30:42 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9IESxre108780; Thu, 18 Oct 2018 14:30:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=xrbA3PFvP6TAx1OulZk4tdZAKsgYOKGgGz35Zl9sIDM=; b=gcQQ1Od98ZGfwFhmp7A+vSEsrdKeq4ni5/y8ljTsLwe1SBHXdHnyJJPfSdlvPlZ8KWrf vEbmOdnXMdieffwzZjQLUEdCCobD9noCC03QthEc7t35wvVsN8D87bG+jemWvOaQXyiK 2CEO4eTXiel4045MmkkK63JqSPDZFqoglHDj/f8en6dqUQeehLt7o5TtYss0VeFvvMzC qAOW2PFezrObehiS9ssIcblRsRb4ZxfZLAM4uaVfNJWCgxyB/AntnPYiN8TvuQp0R1tr S02TwJ3Ucn85cBVBmLJZRk8UcpboHX8n7BlcRfVO7h28iybgtZ8VoxIftDssuVjwdxjM QQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2n384uf2jr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Oct 2018 14:30:39 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9IEUcw2026013 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Oct 2018 14:30:39 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9IEUcJN011484; Thu, 18 Oct 2018 14:30:38 GMT Received: from olila.i.net-space.pl (/10.175.199.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 18 Oct 2018 07:30:37 -0700 Date: Thu, 18 Oct 2018 16:30:33 +0200 From: Daniel Kiper To: Juergen Gross Cc: grub-devel@gnu.org, xen-devel@lists.xen.org, phcoder@gmail.com, hans@knorrie.org Subject: Re: [PATCH v2 02/18] loader/linux: support passing rsdp address via boot params Message-ID: <20181018143033.GF4549@olila.i.net-space.pl> References: <20181009110317.6022-1-jgross@suse.com> <20181009110317.6022-3-jgross@suse.com> <20181018141323.GB4549@olila.i.net-space.pl> <7e26afb1-8319-9224-aba7-f4e047444818@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e26afb1-8319-9224-aba7-f4e047444818@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9049 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810180126 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.86 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 14:30:47 -0000 On Thu, Oct 18, 2018 at 04:18:26PM +0200, Juergen Gross wrote: > On 18/10/2018 16:13, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:01PM +0200, Juergen Gross wrote: > >> Xen PVH guests will have the RSDP at an arbitrary address. Support that > >> by passing the RSDP address via the boot parameters to Linux. > >> > >> The new protocol version 2.14 requires to set version to 0x8000 ored > >> with the actually use protocol version (the minimum of the kernel > >> supplied protocol version and the grub2 supported protocol version) > >> if 2.14 or higher are in effect. > >> > >> Signed-off-by: Juergen Gross > >> --- > >> V2: add oring 0x8000 to version field > >> --- > >> grub-core/loader/i386/linux.c | 9 +++++++++ > >> include/grub/i386/linux.h | 5 ++++- > >> 2 files changed, 13 insertions(+), 1 deletion(-) > >> > >> diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux.c > >> index 4eab55a2d..f96309476 100644 > >> --- a/grub-core/loader/i386/linux.c > >> +++ b/grub-core/loader/i386/linux.c > >> @@ -35,6 +35,7 @@ > >> #include > >> #include > >> #include > >> +#include > > > > Probably this change belongs to another patch. > > I don't think so. You do not add anything to this header here and out of the blue you include it in this file. So, why it is needed here? > >> GRUB_MOD_LICENSE ("GPLv3+"); > >> > >> @@ -750,6 +751,14 @@ grub_cmd_linux (grub_command_t cmd __attribute__ ((unused)), > >> prot_init_space = page_align (prot_size) * 3; > >> } > >> > >> +#ifdef GRUB_KERNEL_USE_RSDP_ADDR > >> + if (grub_le_to_cpu16 (lh.version) >= 0x020e) > >> + lh.acpi_rsdp_addr = grub_le_to_cpu64 (grub_rsdp_addr); > >> +#endif > > > > It seems to me that this belongs to patch #8. Does not it? > > No, it is a generic new interface. > > It will be used by PVH first, but can be used in other environments, > too. I do not like this much but if you want me to get it you have to put a blurb in the commit message why this is not enabled here. And when it will be enabled... Daniel