From: Slawomir Stepien <sst@poczta.fm>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 1/1] staging: iio: adc: ad7280a: use crc8.h API to build crc table
Date: Thu, 18 Oct 2018 20:06:01 +0200 [thread overview]
Message-ID: <20181018180601.GA32323@x220.localdomain> (raw)
In-Reply-To: <ef781380-2306-fb2a-8a9c-f95b23e59b0e@metafoo.de>
On paź 18, 2018 19:31, Lars-Peter Clausen wrote:
> On 10/18/2018 01:49 PM, Slawomir Stepien wrote:
> > The custom build function ad7280_crc8_build_table is not needed. The
> > crc8_populate_msb function from linux/crc8.h will build the same crc
> > table.
> >
> > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
>
> This looks good, thanks.
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thank you.
> I supposed the code could be improved a bit further in a follow up patch by
> only having one global table since it will be the same for all instances.
Yes that's a good idea.
How should I proceed? v3 or a separate commit based on the changes in this
commit? I think separate commit will be better, so I can make a good commit
message...or maybe put it all in a patch series with your ack added to this
change? Sorry I don't know the rules in such cases.
--
Slawomir Stepien
next prev parent reply other threads:[~2018-10-18 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 11:49 [PATCH v2 1/1] staging: iio: adc: ad7280a: use crc8.h API to build crc table Slawomir Stepien
2018-10-18 17:31 ` Lars-Peter Clausen
2018-10-18 18:06 ` Slawomir Stepien [this message]
2018-10-18 18:08 ` Lars-Peter Clausen
2018-10-18 18:09 ` Slawomir Stepien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018180601.GA32323@x220.localdomain \
--to=sst@poczta.fm \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.