All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alexander Graf" <agraf@suse.de>, "Rob Herring" <robh@kernel.org>,
	libvir-list@redhat.com, "Richard Henderson" <rth@twiddle.net>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Eric Blake" <eblake@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	qemu-arm@nongnu.org,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael Walle" <michael@walle.cc>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	qemu-ppc@nongnu.org,
	"Xiao Guangrong" <xiaoguangrong.eric@gmail.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [Qemu-devel] [PULL 43/45] net: stellaris_enet: add a reset method
Date: Thu, 18 Oct 2018 17:04:20 -0300	[thread overview]
Message-ID: <20181018200422.4358-44-ehabkost@redhat.com> (raw)
In-Reply-To: <20181018200422.4358-1-ehabkost@redhat.com>

From: Cédric Le Goater <clg@kaod.org>

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20181001063803.22330-11-clg@kaod.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/net/stellaris_enet.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c
index 3ee1e0f8a4..b3375ebb45 100644
--- a/hw/net/stellaris_enet.c
+++ b/hw/net/stellaris_enet.c
@@ -457,8 +457,10 @@ static const MemoryRegionOps stellaris_enet_ops = {
     .endianness = DEVICE_NATIVE_ENDIAN,
 };
 
-static void stellaris_enet_reset(stellaris_enet_state *s)
+static void stellaris_enet_reset(DeviceState *dev)
 {
+    stellaris_enet_state *s =  STELLARIS_ENET(dev);
+
     s->mdv = 0x80;
     s->rctl = SE_RCTL_BADCRC;
     s->im = SE_INT_PHY | SE_INT_MD | SE_INT_RXER | SE_INT_FOV | SE_INT_TXEMP
@@ -487,8 +489,6 @@ static void stellaris_enet_realize(DeviceState *dev, Error **errp)
     s->nic = qemu_new_nic(&net_stellaris_enet_info, &s->conf,
                           object_get_typename(OBJECT(dev)), dev->id, s);
     qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a);
-
-    stellaris_enet_reset(s);
 }
 
 static Property stellaris_enet_properties[] = {
@@ -501,6 +501,7 @@ static void stellaris_enet_class_init(ObjectClass *klass, void *data)
     DeviceClass *dc = DEVICE_CLASS(klass);
 
     dc->realize = stellaris_enet_realize;
+    dc->reset = stellaris_enet_reset;
     dc->props = stellaris_enet_properties;
     dc->vmsd = &vmstate_stellaris_enet;
 }
-- 
2.18.0.rc1.1.g3f1ff2140

  parent reply	other threads:[~2018-10-18 20:10 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 20:03 [Qemu-devel] [PULL 00/45] Machine queue, 2018-10-18 Eduardo Habkost
2018-10-18 20:03 ` [Qemu-devel] [PULL 01/45] hostmem-file: fixed the memory leak while get pmem path Eduardo Habkost
2018-10-21 17:37   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 02/45] vl.c deprecate incorrect CPUs topology Eduardo Habkost
2018-10-21 17:38   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 03/45] vl:c: make sure that sockets are calculated correctly in '-smp X' case Eduardo Habkost
2018-10-23 15:06   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 04/45] numa: Fix QMP command set-numa-node error handling Eduardo Habkost
2018-10-23 15:07   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 05/45] trace-events: Fix copy/paste typo Eduardo Habkost
2018-10-23 15:08   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 06/45] hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events Eduardo Habkost
2018-10-23 15:09   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 07/45] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init Eduardo Habkost
2018-10-23 15:10   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 08/45] hw/ssi/xilinx_spi: " Eduardo Habkost
2018-10-23 15:11   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 09/45] hw/sh4/sh_pci: " Eduardo Habkost
2018-10-23 15:12   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 10/45] hw/pci-host/bonito: " Eduardo Habkost
2018-10-23 15:14   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 11/45] hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method Eduardo Habkost
2018-10-18 20:03 ` [Qemu-devel] [PULL 12/45] hw/mips/gt64xxx_pci: Mark as bridge device Eduardo Habkost
2018-10-23 15:16   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 13/45] hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device' Eduardo Habkost
2018-10-18 20:03 ` [Qemu-devel] [PULL 14/45] hw/alpha/typhoon: Remove unuseful code Eduardo Habkost
2018-10-23 15:18   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 15/45] hw/hppa/dino: " Eduardo Habkost
2018-10-23 15:18   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 16/45] hw/mips/malta: " Eduardo Habkost
2018-10-23 15:19   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 17/45] machine: fix a typo Eduardo Habkost
2018-10-23 15:20   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 18/45] memory-device: fix alignment error message Eduardo Habkost
2018-10-23 15:20   ` David Gibson
2018-10-18 20:03 ` [Qemu-devel] [PULL 19/45] memory-device: fix error message when hinted address is too small Eduardo Habkost
2018-10-18 20:03 ` [Qemu-devel] [PULL 20/45] memory-device: improve "range conflicts" error message Eduardo Habkost
2018-10-18 20:03 ` [Qemu-devel] [PULL 21/45] pc-dimm: pass PCDIMMDevice to pc_dimm_.*plug Eduardo Habkost
2018-10-18 20:03 ` [Qemu-devel] [PULL 22/45] memory-device: use memory device terminology in error messages Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 23/45] memory-device: introduce separate config option Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 24/45] memory-device: forward errors in get_region_size()/get_plugged_size() Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 25/45] memory-device: document MemoryDeviceClass Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 26/45] memory-device: add and use memory_device_get_region_size() Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 27/45] memory-device: factor out get_memory_region() from pc-dimm Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 28/45] memory-device: drop get_region_size() Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 29/45] memory-device: add device class function set_addr() Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 30/45] memory-device: complete factoring out pre_plug handling Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 31/45] memory-device: complete factoring out plug handling Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 32/45] memory-device: complete factoring out unplug handling Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 33/45] memory-device: trace when pre_plugging/plugging/unplugging Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 34/45] net: etraxfs_eth: convert SysBus init method to a realize method Eduardo Habkost
2018-10-23 15:22   ` David Gibson
2018-10-18 20:04 ` [Qemu-devel] [PULL 35/45] net: etraxfs_eth: add a reset method Eduardo Habkost
2018-10-18 20:04 ` [Qemu-devel] [PULL 36/45] net: lan9118: convert SysBus init method to a realize method Eduardo Habkost
2018-10-23 15:23   ` David Gibson
2018-10-18 20:04 ` [Qemu-devel] [PULL 37/45] net: lance: " Eduardo Habkost
2018-10-23 15:24   ` David Gibson
2018-10-18 20:04 ` [Qemu-devel] [PULL 38/45] net: milkymist_minimac2: " Eduardo Habkost
2018-10-23 15:24   ` David Gibson
2018-10-18 20:04 ` [Qemu-devel] [PULL 39/45] net: mipsnet: " Eduardo Habkost
2018-10-23 15:25   ` David Gibson
2018-10-18 20:04 ` [Qemu-devel] [PULL 40/45] net: opencores_eth: " Eduardo Habkost
2018-10-23 15:25   ` David Gibson
2018-10-18 20:04 ` [Qemu-devel] [PULL 41/45] net: smc91c111: " Eduardo Habkost
2018-10-23 15:25   ` David Gibson
2018-10-18 20:04 ` [Qemu-devel] [PULL 42/45] net: stellaris_enet: " Eduardo Habkost
2018-10-23 15:26   ` David Gibson
2018-10-18 20:04 ` Eduardo Habkost [this message]
2018-10-18 20:04 ` [Qemu-devel] [PULL 44/45] net: xgmac: " Eduardo Habkost
2018-10-23 15:26   ` David Gibson
2018-10-18 20:04 ` [Qemu-devel] [PULL 45/45] numa: Clean up error reporting in parse_numa() Eduardo Habkost
2018-10-23 15:27   ` David Gibson
2018-10-19 14:12 ` [Qemu-devel] [PULL 00/45] Machine queue, 2018-10-18 Peter Maydell
2018-10-19 17:00   ` Philippe Mathieu-Daudé
2018-10-19 17:55     ` Philippe Mathieu-Daudé
2018-10-19 18:44   ` Eduardo Habkost
2018-10-19 19:53     ` Igor Mammedov
2018-10-19 20:23       ` Eduardo Habkost
2018-10-20 10:27         ` Philippe Mathieu-Daudé
2018-10-22  9:00         ` Igor Mammedov
2018-10-22 15:02           ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181018200422.4358-44-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=agraf@suse.de \
    --cc=alistair@alistair23.me \
    --cc=amarkovic@wavecomp.com \
    --cc=armbru@redhat.com \
    --cc=atar4qemu@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=clg@kaod.org \
    --cc=crosthwaite.peter@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=eblake@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=libvir-list@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=michael@walle.cc \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=robh@kernel.org \
    --cc=rth@twiddle.net \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.