All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-mm@kvack.org
Subject: Re: [PATCH] userfaultfd: disable irqs when taking the waitqueue lock
Date: Fri, 19 Oct 2018 08:30:54 +0200	[thread overview]
Message-ID: <20181019063054.GA28667@lst.de> (raw)
In-Reply-To: <20181018155611.42b9977ba08419b7869619c5@linux-foundation.org>

On Thu, Oct 18, 2018 at 03:56:11PM -0700, Andrew Morton wrote:
> On Thu, 18 Oct 2018 17:41:01 +0200 Christoph Hellwig <hch@lst.de> wrote:
> 
> > userfaultfd contains howe-grown locking of the waitqueue lock,
> > and does not disable interrupts.  This relies on the fact that
> > no one else takes it from interrupt context and violates an
> > invariat of the normal waitqueue locking scheme.  With aio poll
> > it is easy to trigger other locks that disable interrupts (or
> > are called from interrupt context).
> 
> So...  this is needed in 4.19.x but not earlier?  Or something else?

Yes.

      reply	other threads:[~2018-10-19  6:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 15:41 [PATCH] userfaultfd: disable irqs when taking the waitqueue lock Christoph Hellwig
2018-10-18 22:56 ` Andrew Morton
2018-10-19  6:30   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181019063054.GA28667@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.