From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/4] drm/i915/fbdev: Use an ordinary worker to avoid async deadlock Date: Fri, 19 Oct 2018 10:23:54 +0200 Message-ID: <20181019082354.GU31561@phenom.ffwll.local> References: <20181015111742.17681-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D4CD6E15C for ; Fri, 19 Oct 2018 08:23:58 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id c22-v6so30665212edc.4 for ; Fri, 19 Oct 2018 01:23:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181015111742.17681-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTUsIDIwMTggYXQgMTI6MTc6MzlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFdlIHRyeSB0byBhdm9pZCBhIGRlYWRsb2NrIG9mIHN5bmNocm9uaXppbmcgdGhlIGFz eW5jIGZiZGV2IHRhc2sgYnkKPiBza2lwcGluZyB0aGUgc3luY2hyb25pc2F0aW9uIGZyb20gdGhl IGFzeW5jIHdvcmtlciwgYnV0IHRoYXQgcHJldmVudHMgdXMKPiBmcm9tIHVzaW5nIGFuIGFzeW5j IHdvcmtlciBmb3IgdGhlIGRldmljZSBwcm9iZS4gQXMgd2UgaGF2ZSBvdXIgb3duCj4gYmFycmll ciBhbmQgZG8gbm90IHJlbHkgb24gdGhlIGdsb2JhbCBhc3luYyBmbHVzaCwgd2UgY2FuIHNpbXBs eSByZXBsYWNlCj4gdGhlIGFzeW5jIHRhc2sgd2l0aCBhbiBleHBsaWNpdCB3b3JrZXIuCj4gCj4g UmVmZXJlbmNlczogMzY2ZTM5YjRkMmM1ICgiZHJtL2k5MTU6IFRlYXIgZG93biBmYmRldiBpZiBp bml0aWFsaXphdGlvbiBmYWlscyIpCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+CgpEb2VzIHRoaXMgbm93IG1lYW4gdGhhdCBmYmRldiBzZXR1 cCBsYWdzIGJlaGluZCBtb2R1bGUgbG9hZD8gQWZhaXVpIHRoYXQKd2lsbCBhbm5veSB1c2Vyc3Bh Y2UsIHdoaWNoIGFzc3VtZXMgdGhhdCBvbmNlIHRoZSBrbXMgZHJpdmVyIGlzIGxvYWRlZCwKZmJk ZXYgd29ya3MuIE9yIGF0IGxlYXN0IEkgaGF2ZSB2YWd1ZSBtZW1vcmllcyBvZiBwYWlucyBpbiB0 aGlzIGFyZWEuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oICAgfCAgMyArLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYyB8IDM1 ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDE4IGlu c2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o Cj4gaW5kZXggM2RlYTdhMWJkYTdmLi4xNWJiZjYwNDcyNGQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaAo+IEBAIC0yNSw3ICsyNSw2IEBACj4gICNpZm5kZWYgX19JTlRFTF9EUlZfSF9f Cj4gICNkZWZpbmUgX19JTlRFTF9EUlZfSF9fCj4gIAo+IC0jaW5jbHVkZSA8bGludXgvYXN5bmMu aD4KPiAgI2luY2x1ZGUgPGxpbnV4L2kyYy5oPgo+ICAjaW5jbHVkZSA8bGludXgvaGRtaS5oPgo+ ICAjaW5jbHVkZSA8bGludXgvc2NoZWQvY2xvY2suaD4KPiBAQCAtMjA3LDggKzIwNiw4IEBAIHN0 cnVjdCBpbnRlbF9mYmRldiB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmZiOwo+ICAJ c3RydWN0IGk5MTVfdm1hICp2bWE7Cj4gIAl1bnNpZ25lZCBsb25nIHZtYV9mbGFnczsKPiAtCWFz eW5jX2Nvb2tpZV90IGNvb2tpZTsKPiAgCWludCBwcmVmZXJyZWRfYnBwOwo+ICsJc3RydWN0IHdv cmtfc3RydWN0IHdvcms7Cj4gIH07Cj4gIAo+ICBzdHJ1Y3QgaW50ZWxfZW5jb2RlciB7Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gaW5kZXggMjQ4MGM3ZDZlZGVlLi4yNjVjYzk0N2Fl ZGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiBAQCAtMjQsNyArMjQsNiBA QAo+ICAgKiAgICAgRGF2aWQgQWlybGllCj4gICAqLwo+ICAKPiAtI2luY2x1ZGUgPGxpbnV4L2Fz eW5jLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2tl cm5lbC5oPgo+ICAjaW5jbHVkZSA8bGludXgvY29uc29sZS5oPgo+IEBAIC02NjYsNiArNjY1LDE2 IEBAIHN0YXRpYyB2b2lkIGludGVsX2ZiZGV2X3N1c3BlbmRfd29ya2VyKHN0cnVjdCB3b3JrX3N0 cnVjdCAqd29yaykKPiAgCQkJCXRydWUpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBpbnRlbF9m YmRldl9pbml0aWFsX2NvbmZpZyhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gK3sKPiArCXN0 cnVjdCBpbnRlbF9mYmRldiAqaWZiZGV2ID0gY29udGFpbmVyX29mKHdvcmssIHR5cGVvZigqaWZi ZGV2KSwgd29yayk7Cj4gKwo+ICsJLyogRHVlIHRvIHBlY3VsaWFyIGluaXQgb3JkZXIgd3J0IHRv IGhwZCBoYW5kbGluZyB0aGlzIGlzIHNlcGFyYXRlLiAqLwo+ICsJaWYgKGRybV9mYl9oZWxwZXJf aW5pdGlhbF9jb25maWcoJmlmYmRldi0+aGVscGVyLAo+ICsJCQkJCSBpZmJkZXYtPnByZWZlcnJl ZF9icHApKQo+ICsJCWludGVsX2ZiZGV2X3VucmVnaXN0ZXIodG9faTkxNShpZmJkZXYtPmhlbHBl ci5kZXYpKTsKPiArfQo+ICsKPiAgaW50IGludGVsX2ZiZGV2X2luaXQoc3RydWN0IGRybV9kZXZp Y2UgKmRldikKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShkZXYpOwo+IEBAIC02NzksNiArNjg4LDggQEAgaW50IGludGVsX2ZiZGV2X2luaXQoc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPiAgCWlmIChpZmJkZXYgPT0gTlVMTCkKPiAgCQlyZXR1cm4g LUVOT01FTTsKPiAgCj4gKwlJTklUX1dPUksoJmlmYmRldi0+d29yaywgaW50ZWxfZmJkZXZfaW5p dGlhbF9jb25maWcpOwo+ICsKPiAgCWRybV9mYl9oZWxwZXJfcHJlcGFyZShkZXYsICZpZmJkZXYt PmhlbHBlciwgJmludGVsX2ZiX2hlbHBlcl9mdW5jcyk7Cj4gIAo+ICAJaWYgKCFpbnRlbF9mYmRl dl9pbml0X2Jpb3MoZGV2LCBpZmJkZXYpKQo+IEBAIC02OTgsMTYgKzcwOSw2IEBAIGludCBpbnRl bF9mYmRldl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAlyZXR1cm4gMDsKPiAgfQo+ ICAKPiAtc3RhdGljIHZvaWQgaW50ZWxfZmJkZXZfaW5pdGlhbF9jb25maWcodm9pZCAqZGF0YSwg YXN5bmNfY29va2llX3QgY29va2llKQo+IC17Cj4gLQlzdHJ1Y3QgaW50ZWxfZmJkZXYgKmlmYmRl diA9IGRhdGE7Cj4gLQo+IC0JLyogRHVlIHRvIHBlY3VsaWFyIGluaXQgb3JkZXIgd3J0IHRvIGhw ZCBoYW5kbGluZyB0aGlzIGlzIHNlcGFyYXRlLiAqLwo+IC0JaWYgKGRybV9mYl9oZWxwZXJfaW5p dGlhbF9jb25maWcoJmlmYmRldi0+aGVscGVyLAo+IC0JCQkJCSBpZmJkZXYtPnByZWZlcnJlZF9i cHApKQo+IC0JCWludGVsX2ZiZGV2X3VucmVnaXN0ZXIodG9faTkxNShpZmJkZXYtPmhlbHBlci5k ZXYpKTsKPiAtfQo+IC0KPiAgdm9pZCBpbnRlbF9mYmRldl9pbml0aWFsX2NvbmZpZ19hc3luYyhz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZmJkZXYgKmlmYmRl diA9IHRvX2k5MTUoZGV2KS0+ZmJkZXY7Cj4gQEAgLTcxNSwxNyArNzE2LDE2IEBAIHZvaWQgaW50 ZWxfZmJkZXZfaW5pdGlhbF9jb25maWdfYXN5bmMoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAg CWlmICghaWZiZGV2KQo+ICAJCXJldHVybjsKPiAgCj4gLQlpZmJkZXYtPmNvb2tpZSA9IGFzeW5j X3NjaGVkdWxlKGludGVsX2ZiZGV2X2luaXRpYWxfY29uZmlnLCBpZmJkZXYpOwo+ICsJc2NoZWR1 bGVfd29yaygmaWZiZGV2LT53b3JrKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaW50ZWxfZmJk ZXZfc3luYyhzdHJ1Y3QgaW50ZWxfZmJkZXYgKmlmYmRldikKPiAgewo+IC0JaWYgKCFpZmJkZXYt PmNvb2tpZSkKPiArCWlmICghUkVBRF9PTkNFKGlmYmRldi0+d29yay5mdW5jKSkKPiAgCQlyZXR1 cm47Cj4gIAo+IC0JLyogT25seSBzZXJpYWxpc2VzIHdpdGggYWxsIHByZWNlZGluZyBhc3luYyBj YWxscywgaGVuY2UgKzEgKi8KPiAtCWFzeW5jX3N5bmNocm9uaXplX2Nvb2tpZShpZmJkZXYtPmNv b2tpZSArIDEpOwo+IC0JaWZiZGV2LT5jb29raWUgPSAwOwo+ICsJZmx1c2hfd29yaygmaWZiZGV2 LT53b3JrKTsKPiArCWlmYmRldi0+d29yay5mdW5jID0gTlVMTDsKPiAgfQo+ICAKPiAgdm9pZCBp bnRlbF9mYmRldl91bnJlZ2lzdGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiBAQCAtNzM2LDggKzczNiw3IEBAIHZvaWQgaW50ZWxfZmJkZXZfdW5yZWdpc3RlcihzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJcmV0dXJuOwo+ICAKPiAgCWNhbmNlbF93 b3JrX3N5bmMoJmRldl9wcml2LT5mYmRldl9zdXNwZW5kX3dvcmspOwo+IC0JaWYgKCFjdXJyZW50 X2lzX2FzeW5jKCkpCj4gLQkJaW50ZWxfZmJkZXZfc3luYyhpZmJkZXYpOwo+ICsJaW50ZWxfZmJk ZXZfc3luYyhpZmJkZXYpOwo+ICAKPiAgCWRybV9mYl9oZWxwZXJfdW5yZWdpc3Rlcl9mYmkoJmlm YmRldi0+aGVscGVyKTsKPiAgfQo+IC0tIAo+IDIuMTkuMQo+IAo+IF9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=