From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 391DEECDE43 for ; Fri, 19 Oct 2018 13:19:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09E4421470 for ; Fri, 19 Oct 2018 13:19:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09E4421470 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-btrfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727387AbeJSVZV (ORCPT ); Fri, 19 Oct 2018 17:25:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:56884 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727377AbeJSVZV (ORCPT ); Fri, 19 Oct 2018 17:25:21 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1B604AEE5 for ; Fri, 19 Oct 2018 13:19:14 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 82B35DAF50; Fri, 19 Oct 2018 15:19:07 +0200 (CEST) Date: Fri, 19 Oct 2018 15:19:06 +0200 From: David Sterba To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 5/6] btrfs: qgroup: Use delayed subtree rescan for balance Message-ID: <20181019131906.GG16290@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org References: <20181018111729.11128-1-wqu@suse.com> <20181018111729.11128-6-wqu@suse.com> <20181019131234.GF16290@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181019131234.GF16290@twin.jikos.cz> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Oct 19, 2018 at 03:12:34PM +0200, David Sterba wrote: > On Thu, Oct 18, 2018 at 07:17:28PM +0800, Qu Wenruo wrote: > > +free_out: > > + kfree(block); > > + free_extent_buffer(reloc_eb); > > +out: > > + if (ret < 0) { > > + btrfs_err_rl(fs_info, > > + "failed to account subtree at bytenr %llu: %d", > > + file_eb->start, ret); > > There's a trailing space at the end of the line and git-am does not let > me apply the patch without manual intervetion. Please clean the patch > before sending next time, thanks. And when I take the git branch instead and rebase it to a recent commit the same problem arises as it's from git-apply.