From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Starkey Subject: Re: [PATCH v5 5/9] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0 Date: Fri, 19 Oct 2018 14:21:46 +0100 Message-ID: <20181019132146.GD78@DESKTOP-E1NTVVP.localdomain> References: <20181019105752.17741-1-alexandru-cosmin.gheorghe@arm.com> <20181019105752.17741-6-alexandru-cosmin.gheorghe@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0080.outbound.protection.outlook.com [104.47.0.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id E00D56E38A for ; Fri, 19 Oct 2018 13:21:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181019105752.17741-6-alexandru-cosmin.gheorghe@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru Gheorghe Cc: charles.xu@arm.com, nd@arm.com, matt.szczesiak@arm.com, airlied@linux.ie, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, maxime.ripard@bootlin.com, david.garbett@arm.com, seanpaul@chromium.org, lisa.wu@arm.com, daniel.vetter@ffwll.ch, malidp@foss.arm.com, ayan.halder@arm.com, james.qian.wang@arm.com List-Id: dri-devel@lists.freedesktop.org SGkgQWxleCwKCk9uIEZyaSwgT2N0IDE5LCAyMDE4IGF0IDExOjU3OjQ4QU0gKzAxMDAsIEFsZXhh bmRydSBHaGVvcmdoZSB3cm90ZToKPkZvciBmb3JtYXRzIHRoYXQgYXJlIHN1cHBvcnRlZCBvbmx5 IHdpdGggbm9uLWxpbmVhciBtb2RpZmllcnMgaXQKPmRvZXNuJ3QgbWFrZSB0byBtdWNoIHNlbnNl IHRvIGRlZmluZSBjcHAgb3IgY2hhcl9wZXJfYmxvY2ssIHNvIHRoYXQKPndpbGwgYmUgc2V0IHRv IDAuCj4KPlRoaXMgcGF0Y2ggYWRkcyBhIHJlc3RyaWN0aW9uIHRvIGZvcmNlIGhhdmluZyBhIG1v ZGlmaWVyIGF0dGFjaGVkIHdoZW4KPmNwcC9jaGFyX3Blcl9ibG9jayBpcyAwLCBhbmQgdG8gYnlw YXNzIGNoZWNraW5nIHRoZSBwaXRjaCByZXN0cmljdGlvbi4KPgo+VGhpcyBoYWQgYmVlbiBkaXNj dXNzZWQgaGVyZS4KPlsxXSBodHRwczovL3Blb3BsZS5mcmVlZGVza3RvcC5vcmcvfmNicmlsbC9k cmktbG9nLz9jaGFubmVsPWRyaS1kZXZlbCZoaWdobGlnaHRfbmFtZXM9JmRhdGU9MjAxOC0wOS0x MyZzaG93X2h0bWw9dHJ1ZQo+Cj5TaWduZWQtb2ZmLWJ5OiBBbGV4YW5kcnUgR2hlb3JnaGUgPGFs ZXhhbmRydS1jb3NtaW4uZ2hlb3JnaGVAYXJtLmNvbT4KPi0tLQo+IGRyaXZlcnMvZ3B1L2RybS9k cm1fZnJhbWVidWZmZXIuYyB8IDcgKysrKysrLQo+IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKPgo+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZnJhbWVidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+aW5kZXgg NmFjYThhMWNjZGI2Li5lMzQ2ZDBhZDkyZTAgMTAwNjQ0Cj4tLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2ZyYW1lYnVmZmVyLmMKPisrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIu Ywo+QEAgLTE5NSw4ICsxOTUsMTMgQEAgc3RhdGljIGludCBmcmFtZWJ1ZmZlcl9jaGVjayhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LAo+IAlmb3IgKGkgPSAwOyBpIDwgaW5mby0+bnVtX3BsYW5lczsg aSsrKSB7Cj4gCQl1bnNpZ25lZCBpbnQgd2lkdGggPSBmYl9wbGFuZV93aWR0aChyLT53aWR0aCwg aW5mbywgaSk7Cj4gCQl1bnNpZ25lZCBpbnQgaGVpZ2h0ID0gZmJfcGxhbmVfaGVpZ2h0KHItPmhl aWdodCwgaW5mbywgaSk7Cj4rCQl1bnNpZ25lZCBpbnQgYmxvY2tfc2l6ZSA9IGluZm8tPmNoYXJf cGVyX2Jsb2NrW2ldOwo+IAkJdTY0IG1pbl9waXRjaCA9IGRybV9mb3JtYXRfaW5mb19taW5fcGl0 Y2goaW5mbywgaSwgd2lkdGgpOwo+Cj4rCQlpZiAoIWJsb2NrX3NpemUgJiYgKHItPm1vZGlmaWVy W2ldID09IERSTV9GT1JNQVRfTU9EX0xJTkVBUikpIHsKPisJCQlEUk1fREVCVUdfS01TKCJGb3Jt YXQgcmVxdWlyZXMgbm9uLWxpbmVhciBtb2RpZmllciBmb3IgcGxhbmUgJWRcbiIsIGkpOwo+KwkJ CXJldHVybiAtRUlOVkFMOwo+KwkJfQoKWW91IGNvdWxkIHByb2JhYmx5IG1vdmUgdGhhdCBibGFu ayBsaWtlIGZyb20gUGF0Y2ggMiB0byBoZXJlIDstKQpPdGhlcndpc2UgTEdUTToKClJldmlld2Vk IEJ5OiBCcmlhbiBTdGFya2V5IDxicmlhbi5zdGFya2V5QGFybS5jb20+Cgo+IAkJaWYgKCFyLT5o YW5kbGVzW2ldKSB7Cj4gCQkJRFJNX0RFQlVHX0tNUygibm8gYnVmZmVyIG9iamVjdCBoYW5kbGUg Zm9yIHBsYW5lICVkXG4iLCBpKTsKPiAJCQlyZXR1cm4gLUVJTlZBTDsKPkBAIC0yMDgsNyArMjEz LDcgQEAgc3RhdGljIGludCBmcmFtZWJ1ZmZlcl9jaGVjayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LAo+IAkJaWYgKCh1aW50NjRfdCkgaGVpZ2h0ICogci0+cGl0Y2hlc1tpXSArIHItPm9mZnNldHNb aV0gPiBVSU5UX01BWCkKPiAJCQlyZXR1cm4gLUVSQU5HRTsKPgo+LQkJaWYgKHItPnBpdGNoZXNb aV0gPCBtaW5fcGl0Y2gpIHsKPisJCWlmIChibG9ja19zaXplICYmIHItPnBpdGNoZXNbaV0gPCBt aW5fcGl0Y2gpIHsKPiAJCQlEUk1fREVCVUdfS01TKCJiYWQgcGl0Y2ggJXUgZm9yIHBsYW5lICVk XG4iLCByLT5waXRjaGVzW2ldLCBpKTsKPiAJCQlyZXR1cm4gLUVJTlZBTDsKPiAJCX0KPi0tIAo+ Mi4xOC4wCj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==