From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 3/8] drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v4. Date: Fri, 19 Oct 2018 20:14:03 +0300 Message-ID: <20181019171403.GU9144@intel.com> References: <20181018115134.9061-1-maarten.lankhorst@linux.intel.com> <20181018115134.9061-4-maarten.lankhorst@linux.intel.com> <20181018160030.GM9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id A98EB6E4FD for ; Fri, 19 Oct 2018 17:14:06 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMTksIDIwMTggYXQgMDQ6MjI6MjlQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTgtMTAtMTggb20gMTg6MDAgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBUaHUsIE9jdCAxOCwgMjAxOCBhdCAwMTo1MToyOVBNICswMjAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBUbyBtYWtlIE5WMTIgd29ya2luZyBvbiBpY2wsIHdlIG5lZWQg dG8gdXBkYXRlIDIgcGxhbmVzIHNpbXVsdGFuZW91c2x5Lgo+ID4+IEkndmUgY2hvc2VuIHRvIGRv IHRoaXMgaW4gdGhlIENSVEMgc3RlcCBhZnRlciBwbGFuZSB2YWxpZGF0aW9uIGlzIGRvbmUsCj4g Pj4gc28gd2Uga25vdyB3aGF0IHBsYW5lcyBhcmUgKGluKXZpc2libGUuIFRoZSBsaW5rZWQgWSBw bGFuZSB3aWxsIGdldAo+ID4+IHVwZGF0ZWQgaW4gaW50ZWxfcGxhbmVfdXBkYXRlX3BsYW5lc19v bl9jcnRjKCksIGJ5IHRoZSBjYWxsIHRvCj4gPj4gdXBkYXRlX3NsYXZlLCB3aGljaCBnZXRzIHRo ZSBtYXN0ZXIncyBwbGFuZV9zdGF0ZSBhcyBhcmd1bWVudC4KPiA+Pgo+ID4+IFRoZSBsaW5rIHJl cXVpcmVzIGJvdGggcGxhbmVzIGZvciBhdG9taWNfdXBkYXRlIHRvIHdvcmssCj4gPj4gc28gbWFr ZSBzdXJlIHNrbF9kZGJfYWRkX2FmZmVjdGVkX3BsYW5lcygpIGFkZHMgYm90aCBzdGF0ZXMuCj4g Pj4KPiA+PiBDaGFuZ2VzIHNpbmNlIHYxOgo+ID4+IC0gSW50cm9kdWNlIGljbF9pc19udjEyX3lf cGxhbmUoKSwgaW5zdGVhZCBvZiBoYXJkY29kaW5nIHNwcml0ZSBudW1iZXJzLgo+ID4+IC0gUHV0 IGFsbCB0aGUgc3RhdGUgdXBkYXRpbmcgbG9naW4gaW4gaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNr X3dpdGhfc3RhdGUoKS4KPiA+PiAtIENsZWFuIHVwIGNoYW5nZXMgaW4gaW50ZWxfcGxhbmVfYXRv bWljX2NoZWNrKCkuCj4gPj4gQ2hhbmdlcyBzaW5jZSB2MjoKPiA+PiAtIEZpeCBpbnRlbF9hdG9t aWNfZ2V0X29sZF9wbGFuZV9zdGF0ZSgpIHRvIGFjdHVhbGx5IHJldHVybiBvbGQgc3RhdGUuCj4g Pj4gLSBNb3ZlIHZpc2liaWxpdHkgY2hhbmdlcyB0byBwcmVwYXJhdGlvbiBwYXRjaC4KPiA+PiAt IE9ubHkgdHJ5IHRvIGZpbmQgYSBZIHBsYW5lIG9uIGdlbjExLCBlYXJsaWVyIHBsYXRmb3JtcyBv bmx5IHJlcXVpcmUKPiA+PiAgIGEgc2luZ2xlIHBsYW5lLgo+ID4+IENoYW5nZXMgc2luY2UgdjM6 Cj4gPj4gLSBGaXggY2hlY2twYXRjaCB3YXJuaW5nIGFib3V0IHRvX2ludGVsX2NydGMoKSB1c2Fn ZS4KPiA+PiAtIEFkZCBhZmZlY3RlZCBwbGFuZXMgZnJvbSBpY2xfYWRkX2xpbmtlZF9wbGFuZXMo KSBiZWZvcmUgY2hlY2tfcGxhbmVzKCksCj4gPj4gICBpdCdzIGEgY2xlYW5lciB3YXkgdG8gZG8g dGhpcy4gKFZpbGxlKQo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3Qg PG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMgfCA3NCArKysrKysrKysrKysrKysr LS0tLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jICAgICAgfCA4 MSArKysrKysrKysrKysrKysrKysrKysrKwo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcnYuaCAgICAgICAgICB8IDUzICsrKysrKysrKysrKysrKwo+ID4+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wbS5jICAgICAgICAgICB8IDEyICsrKy0KPiA+PiAgNCBmaWxlcyBjaGFu Z2VkLCAyMDIgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+ID4+IGluZGV4IGI5NTdhZDYzY2Q4 Ny4uMTU0ZWEzZGMzNDRmIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2F0b21pY19wbGFuZS5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YXRvbWljX3BsYW5lLmMKPiA+PiBAQCAtMTIyLDcgKzEyMiwxMSBAQCBpbnQgaW50ZWxfcGxhbmVf YXRvbWljX2NoZWNrX3dpdGhfc3RhdGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9s ZF9jcnRjXwo+ID4+ICAJY3J0Y19zdGF0ZS0+bnYxMl9wbGFuZXMgJj0gfkJJVChpbnRlbF9wbGFu ZS0+aWQpOwo+ID4+ICAJaW50ZWxfc3RhdGUtPmJhc2UudmlzaWJsZSA9IGZhbHNlOwo+ID4+ICAK PiA+PiAtCS8qIElmIHRoaXMgaXMgYSBjdXJzb3IgcGxhbmUsIG5vIGZ1cnRoZXIgY2hlY2tzIGFy ZSBuZWVkZWQuICovCj4gPj4gKwkvKiBEZXN0cm95IHRoZSBsaW5rICovCj4gPj4gKwlpbnRlbF9z dGF0ZS0+bGlua2VkX3BsYW5lID0gTlVMTDsKPiA+PiArCWludGVsX3N0YXRlLT5zbGF2ZSA9IGZh bHNlOwo+ID4+ICsKPiA+PiArCS8qIElmIHRoaXMgaXMgYSBjdXJzb3Igb3IgWSBwbGFuZSwgbm8g ZnVydGhlciBjaGVja3MgYXJlIG5lZWRlZC4gKi8KPiA+PiAgCWlmICghaW50ZWxfc3RhdGUtPmJh c2UuY3J0YyAmJiAhb2xkX3BsYW5lX3N0YXRlLT5iYXNlLmNydGMpCj4gPj4gIAkJcmV0dXJuIDA7 Cj4gPj4gIAo+ID4+IEBAIC0xNDMsMjcgKzE0Nyw0NCBAQCBpbnQgaW50ZWxfcGxhbmVfYXRvbWlj X2NoZWNrX3dpdGhfc3RhdGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRj Xwo+ID4+ICAJCQkJCSAgICAgICBzdGF0ZSk7Cj4gPj4gIH0KPiA+PiAgCj4gPj4gLXN0YXRpYyBp bnQgaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4+ IC0JCQkJICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm5ld19wbGFuZV9zdGF0ZSkKPiA+PiAr c3RhdGljIGludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFuZSAqZHJt X3BsYW5lLAo+ID4+ICsJCQkJICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm5ld19kcm1fcGxh bmVfc3RhdGUpCj4gPiBNeSBuZXcgY3VubmluZyBwbGFuZSBpcyB0byBjYWxsIHRoZXNlIF9wbGFu ZSwgX25ld19wbGFuZV9zdGF0ZSBldGMuCj4gPiBJdCBzaG91bGQgZGlzY291cmFnZSBwZW9wbGUg ZnJvbSB1c2luZyB0aGVtIGFuZCB0aGUgYWxpYXNpbmcKPiA+IGludGVsXyB0eXBlcyBhdCB0aGUg c2FtZSB0aW1lLiBBbmQgaXQgYXZvaWRzIHBvbGx1dGluZyB0aGUgbmFtZXNwYWNlCj4gPiBmb3Ig dGhpbmdzIHdlIGRvbid0IHJlYWxseSB3YW50IHRvIHVzZS4gCj4gPgo+ID4gSSBhbHJlYWR5IHNu dWNrIGluIHNvbWUgdXNlcyBvZiB0aGlzIDspCj4gPgo+ID4+ICB7Cj4gPj4gLQlzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqc3RhdGUgPSBuZXdfcGxhbmVfc3RhdGUtPnN0YXRlOwo+ID4+IC0JY29u c3Qgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqb2xkX3BsYW5lX3N0YXRlID0KPiA+PiAtCQlkcm1f YXRvbWljX2dldF9vbGRfcGxhbmVfc3RhdGUoc3RhdGUsIHBsYW5lKTsKPiA+PiAtCXN0cnVjdCBk cm1fY3J0YyAqY3J0YyA9IG5ld19wbGFuZV9zdGF0ZS0+Y3J0YyA/OiBvbGRfcGxhbmVfc3RhdGUt PmNydGM7Cj4gPj4gLQljb25zdCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRl Owo+ID4+IC0Jc3RydWN0IGRybV9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZTsKPiA+PiAtCj4g Pj4gLQluZXdfcGxhbmVfc3RhdGUtPnZpc2libGUgPSBmYWxzZTsKPiA+PiArCXN0cnVjdCBpbnRl bF9hdG9taWNfc3RhdGUgKnN0YXRlID0KPiA+PiArCQl0b19pbnRlbF9hdG9taWNfc3RhdGUobmV3 X2RybV9wbGFuZV9zdGF0ZS0+c3RhdGUpOwo+ID4+ICsJc3RydWN0IGludGVsX3BsYW5lICpwbGFu ZSA9IHRvX2ludGVsX3BsYW5lKGRybV9wbGFuZSk7Cj4gPj4gKwljb25zdCBzdHJ1Y3QgaW50ZWxf cGxhbmVfc3RhdGUgKm9sZF9wbGFuZV9zdGF0ZSA9Cj4gPj4gKwkJaW50ZWxfYXRvbWljX2dldF9v bGRfcGxhbmVfc3RhdGUoc3RhdGUsIHBsYW5lKTsKPiA+PiArCXN0cnVjdCBpbnRlbF9wbGFuZV9z dGF0ZSAqbmV3X3BsYW5lX3N0YXRlID0KPiA+PiArCQl0b19pbnRlbF9wbGFuZV9zdGF0ZShuZXdf ZHJtX3BsYW5lX3N0YXRlKTsKPiA+PiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0KPiA+PiAr CQl0b19pbnRlbF9jcnRjKG5ld19wbGFuZV9zdGF0ZS0+YmFzZS5jcnRjID86Cj4gPj4gKwkJCSAg ICAgIG9sZF9wbGFuZV9zdGF0ZS0+YmFzZS5jcnRjKTsKPiA+PiArCWNvbnN0IHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZTsKPiA+PiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpuZXdfY3J0Y19zdGF0ZTsKPiA+PiArCXN0cnVjdCBpbnRlbF9wbGFuZSAqbGlua2VkID0g b2xkX3BsYW5lX3N0YXRlLT5saW5rZWRfcGxhbmU7Cj4gPj4gKwo+ID4+ICsJaWYgKGxpbmtlZCAm JiAhY3J0Yykgewo+ID4+ICsJCWNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqb2xkX2xp bmtlZF9zdGF0ZSA9Cj4gPj4gKwkJCWludGVsX2F0b21pY19nZXRfb2xkX3BsYW5lX3N0YXRlKHN0 YXRlLCBsaW5rZWQpOwo+ID4gUGxhbmUgd2l0aG91dCBhIGNydGMgdGhhdCBoYXBwZW5zIHRvIGhh dmUgYSBsaW5rZWQgcGxhbmUKPiA+IGF0dGFjaGVkIHRvIGl0Li4uCj4gPgo+ID4gSSBndWVzcyB0 aGF0IGltcGxpZXMgdGhhdCAncGxhbmUnIGhlcmUgaXMgdGhlIHNsYXZlIGFuZAo+ID4gaXQgd2Fz IGFscmVhZHkgYWN0aXZlIGR1cmluZyB0aGUgcHJldmlvdXMgc3RhdGUgKG90aGVyd2lzZQo+ID4g aXQgd291bGQgbm90IGhhdmUgYmVlbiBsaW5rZWQgdG8gdGhlIG90aGVyIHBsYW5lKS4gU28gdGhh dAo+ID4gbWVhbnMgdGhlIG1hc3RlciBwbGFuZSBtdXN0IGhhdmUgYSB2YWxpZCBjcnRjIGluIGl0 cyBvbGQKPiA+IHBsYW5lIHN0YXRlLgo+ID4KPiA+IERpZCBJIGRlY29kZSB0aGF0IGNvcnJlY3Rs eT8KPiBDb3JyZWN0Lgo+ID4gTWF5YmUgd2hhdCB3ZSB3YW50IHRvIGRvIGhlcmUgaXMgdG8ganVz dCBhbHdheXMgY2xlYXIgdGhlCj4gPiBhY3RpdmVfcGxhbmVzIGJpdCBmb3IgdGhlIHNsYXZlIGlu IHRoZSBtYXN0ZXIgcGxhbmUncwo+ID4gb2xkIGNydGMncyBuZXcgY3J0YyBzdGF0ZSAocXVpdGUg dGhlIG1vdXRoZnVsKSwgYW5kIHRoZW4KPiA+IHJ1biB0aHJvdWdoIHRoZSBub3JtYWwgY2hlY2tf cGxhbmUgc3R1ZmYgZm9yIHRoZSBzbGF2ZQo+ID4gd2l0aCBpdHMgb3duIGNydGMgKGlmIGl0IGhh cyBvbmUpLiBJbiBwcmFjdGljZSBpdCBkb2Vzbid0Cj4gPiByZWFsbHkgbWFrZSBhbnkgZGlmZmVy ZW5jZSBJIHN1cHBvc2Ugc2luY2Ugb3VyIHBsYW5lcwo+ID4gY2FuJ3QgbW92ZSBiZXR3ZWVuIGNy dGNzLCBidXQgbG9naWNhbGx5IGl0IHdvdWxkIG1ha2UKPiA+IG1vcmUgc2Vuc2UgdG8gbWUuCj4g RXZlbiBpZiB3ZSBjb3VsZCBtb3ZlIHBsYW5lcyzCoCB3ZSBjYW4ndCBtb3ZlIHBsYW5lcyBiZXR3 ZWVuIENSVEMncyBpbiBhIHNpbmdsZSBhdG9taWMgY29tbWl0Lgo+IEZpcnN0IGNvbWVzIHRoZSBk aXNhYmxpbmcsIHRoZW4gY29tZXMgdGhlIG1vdmluZy4KPiAKPiBJIHRoaW5rIGl0J3MgbGVzcyBv ZiBhIG1lc3Mgb2YgZG9pbmcgaXQgdGhpcyB3YXksIGl0IGtlZXBzIGludGVsX3BsYW5lX2F0b21p Y19jaGVja193aXRoX3N0YXRlKCkgb2J2aW91cy4KCkl0J3MgcmF0aGVyIG5vbi1vYnZpb3VzLiBJ IGhhZCB0byB0aGluayBhYm91dCBpdCBmb3IgYSB3aGlsZS4KCkkgdGhpbmsgaXQgd291bGQgYmUg bXVjaCBjbGVhcmVyIHRvIGtlZXAgaXQgYWxsIGluIG9uZSBzZWxmCmNvbnRhaW5lZCBmdW5jdGlv biBpbnN0ZWFkIG9mIHNwcmVhZGluZyBpdCBhY3Jvc3Mgc2V2ZXJhbApmdW5jdGlvbnMuCgpyZW1v dmVfcGxhbmVfbGluaygpCnsKCWlmIChwbGFuZV9zdGF0ZS0+bGlua2VkICYmIHBsYW5lX3N0YXRl LT5zbGF2ZSkgewoJCW9sZF9saW5rZWRfc3RhdGUgPSBnZXRfb2xkX3BsYW5lX3N0YXRlKHBsYW5l X3N0YXRlLT5saW5rZWQpOwoJCW5ld19jcnRjX3N0YXRlID0gZ2V0X25ld19jcnRjX3N0YXRlKG9s ZF9saW5rZWRfc3RhdGUtPmNydGMpOwoJCW5ld19jcnRjX3N0YXRlLT5hY3RpdmVfcGxhbmVzICY9 IH5CSVQocGxhbmUtPmlkKTsKCX0KCglwbGFuZV9zdGF0ZS0+bGlua2VkID0gTlVMTDsKCXBsYW5l X3N0YXRlLT5zbGF2ZSA9IGZhbHNlOwp9CgpvciBzb21ldGhpbmcuCgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=