* [Buildroot] [PATCH 1/1] postgresql: disable spinlock support for riscv64
@ 2018-10-20 20:22 Fabrice Fontaine
2018-10-20 21:58 ` Thomas Petazzoni
2018-10-21 14:37 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2018-10-20 20:22 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/postgresql/postgresql.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
index 540e1540ca..8b3fd6f439 100644
--- a/package/postgresql/postgresql.mk
+++ b/package/postgresql/postgresql.mk
@@ -29,7 +29,7 @@ ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
POSTGRESQL_CONF_OPTS += --disable-thread-safety
endif
-ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_xtensa),y)
+ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_RISCV_64)$(BR2_xtensa),y)
POSTGRESQL_CONF_OPTS += --disable-spinlocks
endif
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] postgresql: disable spinlock support for riscv64
2018-10-20 20:22 [Buildroot] [PATCH 1/1] postgresql: disable spinlock support for riscv64 Fabrice Fontaine
@ 2018-10-20 21:58 ` Thomas Petazzoni
2018-10-21 9:32 ` Mark Corbin
2018-10-21 14:37 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2018-10-20 21:58 UTC (permalink / raw)
To: buildroot
Hello,
+Mark Corbin in Cc.
On Sat, 20 Oct 2018 22:22:19 +0200, Fabrice Fontaine wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> -ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_xtensa),y)
> +ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_RISCV_64)$(BR2_xtensa),y)
Any reason for doing that only for riscv64 and not for RISC-V
entirely ? Does PostgreSQL has a spinlock implementation for RISC-V 32
but not RISC-V 64 ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] postgresql: disable spinlock support for riscv64
2018-10-20 21:58 ` Thomas Petazzoni
@ 2018-10-21 9:32 ` Mark Corbin
0 siblings, 0 replies; 4+ messages in thread
From: Mark Corbin @ 2018-10-21 9:32 UTC (permalink / raw)
To: buildroot
Hello Thomas
On 20/10/2018 22:58, Thomas Petazzoni wrote:
> Hello,
>
> +Mark Corbin in Cc.
>
> On Sat, 20 Oct 2018 22:22:19 +0200, Fabrice Fontaine wrote:
>> Fixes:
>> - http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> -ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_xtensa),y)
>> +ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_RISCV_64)$(BR2_xtensa),y)
> Any reason for doing that only for riscv64 and not for RISC-V
> entirely ? Does PostgreSQL has a spinlock implementation for RISC-V 32
> but not RISC-V 64 ?
PostgreSQL does not have any support for RISC-V architecture, so I it?
makes sense to use BR2_riscv here instead of BR2_RISCV_64.
Regards
Mark
>
> Thanks,
>
> Thomas
--
*Mark Corbin*
Embedded Operating Systems Lead
Phone: +44 1590 610184?????Mobile: +44 7765 703479
Email: mark.corbin at embecosm.com
<mailto:mark.corbin@embecosm.com>?????Web: https://www.embecosm.com
Embecosm Logo
Embecosm Ltd., Palamos House #208, 66/67 High Street, Lymington, SO41
9AL, UK
Company No. 6577021 (England & Wales).
--
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181021/4451036c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logo.png
Type: image/png
Size: 8442 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181021/4451036c/attachment.png>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] postgresql: disable spinlock support for riscv64
2018-10-20 20:22 [Buildroot] [PATCH 1/1] postgresql: disable spinlock support for riscv64 Fabrice Fontaine
2018-10-20 21:58 ` Thomas Petazzoni
@ 2018-10-21 14:37 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-10-21 14:37 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 20 Oct 2018 22:22:19 +0200, Fabrice Fontaine wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/postgresql/postgresql.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I've changed the condition to use BR2_riscv instead of BR2_RISCV_64,
and then applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-21 14:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-20 20:22 [Buildroot] [PATCH 1/1] postgresql: disable spinlock support for riscv64 Fabrice Fontaine
2018-10-20 21:58 ` Thomas Petazzoni
2018-10-21 9:32 ` Mark Corbin
2018-10-21 14:37 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.