All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/2] slirp: Add sanity check for str option length
Date: Sun, 21 Oct 2018 21:22:45 +0200	[thread overview]
Message-ID: <20181021192244.ep6kyqjvmt4xytyk@function> (raw)
In-Reply-To: <20180914072616.17771-2-famz@redhat.com>

Hello,

Fam Zheng, le ven. 14 sept. 2018 15:26:15 +0800, a ecrit:
> When user provides a long domainname or hostname that doesn't fit in the
> DHCP packet, we mustn't overflow the response packet buffer. Instead,
> report errors, following the g_warning() in the slirp->vdnssearch
> branch.
> 
> Also check the strlen against 256 when initializing slirp, which limit
> is also from the protocol where one byte represents the string length.
> This gives an early error before the warning which is harder to notice
> or diagnose.

Applied to my tree, thanks!

Samuel

  reply	other threads:[~2018-10-21 19:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14  7:26 [Qemu-devel] [PATCH v3 0/2] slirp: Add support for RFC2132 TFTP server name Fam Zheng
2018-09-14  7:26 ` [Qemu-devel] [PATCH v3 1/2] slirp: Add sanity check for str option length Fam Zheng
2018-10-21 19:22   ` Samuel Thibault [this message]
2018-09-14  7:26 ` [Qemu-devel] [PATCH v3 2/2] slirp: Implement RFC2132 TFTP server name Fam Zheng
2018-10-21 19:25   ` Samuel Thibault
2018-10-22 13:01     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181021192244.ep6kyqjvmt4xytyk@function \
    --to=samuel.thibault@gnu.org \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.