All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] thermal: bcm2835: enable hwmon explicitly
@ 2018-10-21 21:58 ` matthias.bgg at kernel.org
  0 siblings, 0 replies; 8+ messages in thread
From: matthias.bgg @ 2018-10-21 21:58 UTC (permalink / raw)
  To: rui.zhang, edubezval, daniel.lezcano, f.fainelli, rjui, sbranden,
	bcm-kernel-feedback-list, eric, stefan.wahren
  Cc: geert+renesas, pmladek, matthias.bgg, linux-pm, linux-rpi-kernel,
	linux-arm-kernel, linux-kernel, Matthias Brugger

From: Matthias Brugger <mbrugger@suse.com>

By defaul of-based thermal driver do not enable hwmon.
This patch does this explicitly, so that the temperature can be read
through the common hwmon sysfs.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
 drivers/thermal/broadcom/bcm2835_thermal.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
index 23ad4f9f2143..24b006a95142 100644
--- a/drivers/thermal/broadcom/bcm2835_thermal.c
+++ b/drivers/thermal/broadcom/bcm2835_thermal.c
@@ -27,6 +27,8 @@
 #include <linux/platform_device.h>
 #include <linux/thermal.h>
 
+#include "../thermal_hwmon.h"
+
 #define BCM2835_TS_TSENSCTL			0x00
 #define BCM2835_TS_TSENSSTAT			0x04
 
@@ -275,6 +277,15 @@ static int bcm2835_thermal_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, tz);
 
+	/*
+	 * Thermal_zone doesn't enable hwmon as default,
+	 * enable it here
+	 */
+	tz->tzp->no_hwmon = false;
+	err = thermal_add_hwmon_sysfs(tz);
+	if (err)
+		goto err_tz;
+
 	bcm2835_thermal_debugfs(pdev);
 
 	return 0;
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] thermal: bcm2835: enable hwmon explicitly
@ 2018-10-21 21:58 ` matthias.bgg at kernel.org
  0 siblings, 0 replies; 8+ messages in thread
From: matthias.bgg at kernel.org @ 2018-10-21 21:58 UTC (permalink / raw)
  To: linux-arm-kernel

From: Matthias Brugger <mbrugger@suse.com>

By defaul of-based thermal driver do not enable hwmon.
This patch does this explicitly, so that the temperature can be read
through the common hwmon sysfs.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
 drivers/thermal/broadcom/bcm2835_thermal.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
index 23ad4f9f2143..24b006a95142 100644
--- a/drivers/thermal/broadcom/bcm2835_thermal.c
+++ b/drivers/thermal/broadcom/bcm2835_thermal.c
@@ -27,6 +27,8 @@
 #include <linux/platform_device.h>
 #include <linux/thermal.h>
 
+#include "../thermal_hwmon.h"
+
 #define BCM2835_TS_TSENSCTL			0x00
 #define BCM2835_TS_TSENSSTAT			0x04
 
@@ -275,6 +277,15 @@ static int bcm2835_thermal_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, tz);
 
+	/*
+	 * Thermal_zone doesn't enable hwmon as default,
+	 * enable it here
+	 */
+	tz->tzp->no_hwmon = false;
+	err = thermal_add_hwmon_sysfs(tz);
+	if (err)
+		goto err_tz;
+
 	bcm2835_thermal_debugfs(pdev);
 
 	return 0;
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] thermal: bcm2835: enable hwmon explicitly
  2018-10-21 21:58 ` matthias.bgg at kernel.org
@ 2018-10-23 12:01   ` Stefan Wahren
  -1 siblings, 0 replies; 8+ messages in thread
From: Stefan Wahren @ 2018-10-23 12:01 UTC (permalink / raw)
  To: matthias.bgg, rui.zhang, edubezval, daniel.lezcano, f.fainelli,
	rjui, sbranden, bcm-kernel-feedback-list, eric
  Cc: geert+renesas, pmladek, matthias.bgg, linux-pm, linux-rpi-kernel,
	linux-arm-kernel, linux-kernel, Matthias Brugger

Hi Matthias,

> matthias.bgg@kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben:
> 
> 
> From: Matthias Brugger <mbrugger@suse.com>
> 
> By defaul of-based thermal driver do not enable hwmon.
> This patch does this explicitly, so that the temperature can be read
> through the common hwmon sysfs.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

I'm just curious which board and config did you use for your tests?

Regards
Stefan

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] thermal: bcm2835: enable hwmon explicitly
@ 2018-10-23 12:01   ` Stefan Wahren
  0 siblings, 0 replies; 8+ messages in thread
From: Stefan Wahren @ 2018-10-23 12:01 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Matthias,

> matthias.bgg at kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben:
> 
> 
> From: Matthias Brugger <mbrugger@suse.com>
> 
> By defaul of-based thermal driver do not enable hwmon.
> This patch does this explicitly, so that the temperature can be read
> through the common hwmon sysfs.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

I'm just curious which board and config did you use for your tests?

Regards
Stefan

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] thermal: bcm2835: enable hwmon explicitly
  2018-10-23 12:01   ` Stefan Wahren
@ 2018-10-23 21:20     ` Matthias Brugger
  -1 siblings, 0 replies; 8+ messages in thread
From: Matthias Brugger @ 2018-10-23 21:20 UTC (permalink / raw)
  To: Stefan Wahren, matthias.bgg, rui.zhang, edubezval,
	daniel.lezcano, f.fainelli, rjui, sbranden,
	bcm-kernel-feedback-list, eric
  Cc: geert+renesas, pmladek, linux-pm, linux-rpi-kernel,
	linux-arm-kernel, linux-kernel, Matthias Brugger

Hi Stefan,

On 23/10/2018 14:01, Stefan Wahren wrote:
> Hi Matthias,
> 
>> matthias.bgg@kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben:
>>
>>
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> By defaul of-based thermal driver do not enable hwmon.
>> This patch does this explicitly, so that the temperature can be read
>> through the common hwmon sysfs.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> 
> Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
> 
> I'm just curious which board and config did you use for your tests?
> 

I use the RPi3 B+. I suppose when asking about the config, you want to know if I
also enable the RASPBERRYPI_HWMON, yes I enable that as well. Actually this
patch is for openSUSE Leap. You can find the whole config (if you are
interested) here:
https://kernel.suse.com/cgit/kernel-source/tree/config/arm64/default?h=SLE15

Regards,
Matthias

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] thermal: bcm2835: enable hwmon explicitly
@ 2018-10-23 21:20     ` Matthias Brugger
  0 siblings, 0 replies; 8+ messages in thread
From: Matthias Brugger @ 2018-10-23 21:20 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Stefan,

On 23/10/2018 14:01, Stefan Wahren wrote:
> Hi Matthias,
> 
>> matthias.bgg at kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben:
>>
>>
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> By defaul of-based thermal driver do not enable hwmon.
>> This patch does this explicitly, so that the temperature can be read
>> through the common hwmon sysfs.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> 
> Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
> 
> I'm just curious which board and config did you use for your tests?
> 

I use the RPi3 B+. I suppose when asking about the config, you want to know if I
also enable the RASPBERRYPI_HWMON, yes I enable that as well. Actually this
patch is for openSUSE Leap. You can find the whole config (if you are
interested) here:
https://kernel.suse.com/cgit/kernel-source/tree/config/arm64/default?h=SLE15

Regards,
Matthias

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] thermal: bcm2835: enable hwmon explicitly
  2018-10-21 21:58 ` matthias.bgg at kernel.org
@ 2018-11-07 19:04   ` Stefan Wahren
  -1 siblings, 0 replies; 8+ messages in thread
From: Stefan Wahren @ 2018-11-07 19:04 UTC (permalink / raw)
  To: matthias.bgg, rui.zhang, edubezval, daniel.lezcano
  Cc: pmladek, Matthias Brugger, eric, geert+renesas,
	bcm-kernel-feedback-list, linux-pm, linux-kernel, rjui, sbranden,
	f.fainelli, linux-rpi-kernel, matthias.bgg, linux-arm-kernel

Hi Rui,
hi Eduardo,
hi Daniel,

> matthias.bgg@kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben:
> 
> 
> From: Matthias Brugger <mbrugger@suse.com>
> 
> By defaul of-based thermal driver do not enable hwmon.
> This patch does this explicitly, so that the temperature can be read
> through the common hwmon sysfs.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---

any objections except of the missing t in default?

Stefan

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] thermal: bcm2835: enable hwmon explicitly
@ 2018-11-07 19:04   ` Stefan Wahren
  0 siblings, 0 replies; 8+ messages in thread
From: Stefan Wahren @ 2018-11-07 19:04 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Rui,
hi Eduardo,
hi Daniel,

> matthias.bgg at kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben:
> 
> 
> From: Matthias Brugger <mbrugger@suse.com>
> 
> By defaul of-based thermal driver do not enable hwmon.
> This patch does this explicitly, so that the temperature can be read
> through the common hwmon sysfs.
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---

any objections except of the missing t in default?

Stefan

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-11-07 19:05 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-21 21:58 [PATCH] thermal: bcm2835: enable hwmon explicitly matthias.bgg
2018-10-21 21:58 ` matthias.bgg at kernel.org
2018-10-23 12:01 ` Stefan Wahren
2018-10-23 12:01   ` Stefan Wahren
2018-10-23 21:20   ` Matthias Brugger
2018-10-23 21:20     ` Matthias Brugger
2018-11-07 19:04 ` Stefan Wahren
2018-11-07 19:04   ` Stefan Wahren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.