From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48BDBC67863 for ; Mon, 22 Oct 2018 05:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECE262083A for ; Mon, 22 Oct 2018 05:29:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="BdSpz0C0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECE262083A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727492AbeJVNq1 (ORCPT ); Mon, 22 Oct 2018 09:46:27 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:43654 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727256AbeJVNq1 (ORCPT ); Mon, 22 Oct 2018 09:46:27 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9M5O3Zc045947; Mon, 22 Oct 2018 05:27:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=E5A5za2rA0Pq3Zdyo64Eq27B5Okgep/ng7sHNHSVEI4=; b=BdSpz0C0mJAeNQ16naL5sn07x6cLTkKOc+zbmlTykuw4hMAaDVdXcmuP/gYCJRx+Lsih 2OgbzmxsM0mec3D+BNUkF0K4nbwu2WXUZ6abzRHKawqKjlS5dvFsGrT9YixDrJJPHwUX 4X3rOyhRP+YnffXOSHnhjyDUvzLZC/Dr/zvjj+AqIdBFiPrkwj3eGlFdwZ9epLh96zdJ zvORdKKeuN73c7+pWQ4kutGPCjXO9/ZEcmI8KKIOu8jQVI9vk1C8uKgYKqd45TeEuHPK rt5Anx+ZefyS1NDN02mwhzaSdRHqf2B9bqvTc7REToo1mNWP2rcSMMvbJnQ1eOrDbLUE hw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2n7ustv77g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Oct 2018 05:27:48 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w9M5RfF6028321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Oct 2018 05:27:41 GMT Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9M5RT25027049; Mon, 22 Oct 2018 05:27:31 GMT Received: from mwanda (/129.205.6.86) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 21 Oct 2018 22:27:28 -0700 Date: Mon, 22 Oct 2018 08:27:01 +0300 From: Dan Carpenter To: Joe Perches Cc: Greg Kroah-Hartman , Miguel Ojeda , linux-kernel@vger.kernel.org, Andreas Dilger , Masahiro Yamada , Michal Marek , Steven Rostedt , Mauro Carvalho Chehab , Olof Johansson , Konstantin Ryabitsev , "David S . Miller" , Andrey Ryabinin , Kees Cook , Thomas Gleixner , Ingo Molnar , Paul Lawrence , Sandipan Das , Andrey Konovalov , David Woodhouse , Will Deacon , Philippe Ombredanne , Paul Burton , David Rientjes , Willy Tarreau , Martin Sebor , Christopher Li , Jonathan Corbet , "Theodore Ts'o" , Geert Uytterhoeven , Rasmus Villemoes , Arnd Bergmann , Dominique Martinet , Stefan Agner , Luc Van Oostenryck , Nick Desaulniers , Andrew Morton , Linus Torvalds , linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org, linux-sparse@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH 0/2] Compiler Attributes: __fallthrough Message-ID: <20181022052700.a6v3d6t43kot6yso@mwanda> References: <20181021171414.22674-1-miguel.ojeda.sandonis@gmail.com> <20181021182926.GB6683@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9053 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810220051 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 21, 2018 at 11:52:21AM -0700, Joe Perches wrote: > On Sun, 2018-10-21 at 19:29 +0100, Greg Kroah-Hartman wrote:i > > On Sun, Oct 21, 2018 at 07:14:12PM +0200, Miguel Ojeda wrote: > > > These are two patches are meant to go on top of the rest of the compiler > > > attributes series on: > > > > > > https://github.com/ojeda/linux/tree/compiler-attributes > > > > > > which will be sent to Greg for the next merge window. > > > > > > Please review them and let me know! (specially if someone is against > > > __fallthrough for some reason :-). > > > > Will this work with all of the static tools that are currently looking > > for the comment instead? > > Does anyone have a list of the static tools that > use comment style fallthrough notations? > It would only be CPPcheck I think. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 0/2] Compiler Attributes: __fallthrough Date: Mon, 22 Oct 2018 08:27:01 +0300 Message-ID: <20181022052700.a6v3d6t43kot6yso@mwanda> References: <20181021171414.22674-1-miguel.ojeda.sandonis@gmail.com> <20181021182926.GB6683@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches Cc: Greg Kroah-Hartman , Miguel Ojeda , linux-kernel@vger.kernel.org, Andreas Dilger , Masahiro Yamada , Michal Marek , Steven Rostedt , Mauro Carvalho Chehab , Olof Johansson , Konstantin Ryabitsev , "David S . Miller" , Andrey Ryabinin , Kees Cook , Thomas Gleixner , Ingo Molnar , Paul Lawrence , Sandipan Das , Andrey Konovalov List-Id: linux-sparse@vger.kernel.org On Sun, Oct 21, 2018 at 11:52:21AM -0700, Joe Perches wrote: > On Sun, 2018-10-21 at 19:29 +0100, Greg Kroah-Hartman wrote:i > > On Sun, Oct 21, 2018 at 07:14:12PM +0200, Miguel Ojeda wrote: > > > These are two patches are meant to go on top of the rest of the compiler > > > attributes series on: > > > > > > https://github.com/ojeda/linux/tree/compiler-attributes > > > > > > which will be sent to Greg for the next merge window. > > > > > > Please review them and let me know! (specially if someone is against > > > __fallthrough for some reason :-). > > > > Will this work with all of the static tools that are currently looking > > for the comment instead? > > Does anyone have a list of the static tools that > use comment style fallthrough notations? > It would only be CPPcheck I think. regards, dan carpenter