From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gEZ1B-0000GT-4q for mharc-grub-devel@gnu.org; Mon, 22 Oct 2018 08:09:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEZ15-0000FX-Ej for grub-devel@gnu.org; Mon, 22 Oct 2018 08:09:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEZ12-0004tj-85 for grub-devel@gnu.org; Mon, 22 Oct 2018 08:09:03 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:35262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gEZ11-0004s4-SK for grub-devel@gnu.org; Mon, 22 Oct 2018 08:09:00 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9MC3vOA129774; Mon, 22 Oct 2018 12:08:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=/pB5g7SPzVGOfWSsftM79zZXL6Me1f/xztLE3lxC8Nk=; b=a2snBRtqMJKtKcTplLzq8zsb9raJuTNC4dJ+7dU6XOfTHTb3FeWMmm0XaBkeiY3ppdLr rclNST3YyKSsQPa2uPkwYzI4kQBVM0xd9p7nVdVkbf+oKNb4UVUHj7ASJilckPJos/Jo VvF3DBC1K2JpOjHwLEjmaEcSMBfSQmeNekGOtbzr2Br2XIvFPGbIJAiS1cxNyjhrLUo3 T1dS4kQ4eY99VKZNHwbUzJAfdcQbcR3lmU+629kaoGeoHpvv5aW0h7/xoJhRXPgS5DWV 6D1K8xiUr4oWuhmd+DuvAkkg/reifVpuxS44Tt7GSAonWKLd3w/jJvHiLgQ4LyhSOeTg qg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2n7w0qdxuu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Oct 2018 12:08:57 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9MC8vSE005321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Oct 2018 12:08:57 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9MC8uUr014401; Mon, 22 Oct 2018 12:08:57 GMT Received: from olila.i.net-space.pl (/10.175.186.189) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 22 Oct 2018 05:08:56 -0700 Date: Mon, 22 Oct 2018 14:08:52 +0200 From: Daniel Kiper To: Juergen Gross Cc: grub-devel@gnu.org, xen-devel@lists.xen.org, phcoder@gmail.com, hans@knorrie.org Subject: Re: [PATCH v2 13/18] xen: init memory regions for PVH Message-ID: <20181022120852.GI4548@olila.i.net-space.pl> References: <20181009110317.6022-1-jgross@suse.com> <20181009110317.6022-14-jgross@suse.com> <20181022113139.GC4548@olila.i.net-space.pl> <478b4b66-2218-d475-19c8-24237355e4c6@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <478b4b66-2218-d475-19c8-24237355e4c6@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9053 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=434 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810220106 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 12:09:08 -0000 On Mon, Oct 22, 2018 at 01:43:53PM +0200, Juergen Gross wrote: > On 22/10/2018 13:31, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 01:03:12PM +0200, Juergen Gross wrote: > >> Add all usable memory regions to grub memory management and add the > >> needed mmap iterate code. > > > > I am missing a few words why this patch is needed. Especially why > > grub_machine_mmap_iterate() has to belong to this patch. However, > > I think that it should be introduced by patch in which > > grub_machine_mmap_iterate() is used at some point. > > That would again lead to one giant PVH patch which you didn't like. > > grub_machine_mmap_iterate() is being used by grub common code like > grub-core/lib/relocator.c or grub-core/mmap/mmap.c > > grub_machine_mmap_iterate() belongs into this patch as it is the > main user of the memory map introduced here. OK, let's leave it here. Though commit message has to be updated accordingly. Daniel