From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH v6 0/7] replace attach/detach functions Date: Mon, 22 Oct 2018 14:31:03 +0200 Message-ID: <20181022123110.5733-1-thomas@monjalon.net> References: <20181007222554.4886-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, wisamm@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, bernard.iremonger@intel.com To: dev@dpdk.org Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E47C44CA7 for ; Mon, 22 Oct 2018 14:31:16 +0200 (CEST) In-Reply-To: <20181007222554.4886-1-thomas@monjalon.net> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The functions for EAL attach/detach had already some replacements, so they are removed. The functions for ethdev attach/detach are removed and replaced thanks to a new ethdev iterator working with devargs. rte_eth_dev_attach(devargs, &port_id) is replaced by: rte_dev_probe(devargs); RTE_ETH_FOREACH_MATCHING_DEV(port_id, devargs, &iterator) { do what you want with the new port_id } The biggest benefit is to be able to manage devargs string matching several ports to probe. Changes in v6: - improve testpmd logs - update testpmd port_status when detaching multiple ports Changes in v5: - check double detach in testpmd Changes in v4: - fix compilation (due to stricter checks in v3) Changes in v3 - after Andrew's review: - coding rules compliance - stricter checks for snprintf - rte_eth_iterator_free() becomes rte_eth_iterator_cleanup() - add rte_eth_iterator_cleanup in .map Changes in v2 - after Andrew's review: - return only 0 or -1 in vdev_dev_match() - fix freeing of strings in the iterator - add rte_eth_iterator_free() - tolerate extra parameters from old syntax - add more comments - separate contributing guide patch Thomas Monjalon (7): bus/vdev: add iteration filter on name ethdev: add iterator to match devargs input ethdev: allow iterating with pure class filter doc: replace doxygen example in contribution guide ethdev: remove deprecated attach/detach functions eal: remove deprecated attach/detach functions app/testpmd: check not detaching device twice app/test-pmd/testpmd.c | 43 +++- doc/guides/contributing/documentation.rst | 15 +- doc/guides/prog_guide/index.rst | 1 - .../prog_guide/port_hotplug_framework.rst | 106 --------- doc/guides/rel_notes/deprecation.rst | 12 - doc/guides/rel_notes/release_18_11.rst | 12 + drivers/bus/vdev/vdev_params.c | 19 +- drivers/net/virtio/virtio_user_ethdev.c | 1 - lib/librte_eal/common/eal_common_dev.c | 53 ----- lib/librte_eal/common/include/rte_common.h | 6 + lib/librte_eal/common/include/rte_dev.h | 27 --- lib/librte_eal/rte_eal_version.map | 2 - lib/librte_ethdev/ethdev_private.c | 10 +- lib/librte_ethdev/ethdev_private.h | 6 + lib/librte_ethdev/rte_class_eth.c | 9 +- lib/librte_ethdev/rte_ethdev.c | 223 +++++++++++------- lib/librte_ethdev/rte_ethdev.h | 110 ++++++--- lib/librte_ethdev/rte_ethdev_version.map | 5 +- 18 files changed, 322 insertions(+), 338 deletions(-) delete mode 100644 doc/guides/prog_guide/port_hotplug_framework.rst -- 2.19.0