All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Young <sean@mess.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Torbjorn Jansson <torbjorn.jansson@mbox200.swipnet.se>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] media: rc: cec devices do not have a lirc chardev
Date: Mon, 22 Oct 2018 14:17:27 +0100	[thread overview]
Message-ID: <20181022131727.yf5e6gorccs3m6w7@gofer.mess.org> (raw)
In-Reply-To: <20181022122842.mvrvpfyaflvmtbf6@gofer.mess.org>

On Mon, Oct 22, 2018 at 01:28:42PM +0100, Sean Young wrote:
> On Mon, Oct 22, 2018 at 12:30:29PM +0100, Hans Verkuil wrote:
> > On 10/22/2018 11:14 AM, Sean Young wrote:
> > > Would you be able to test the following patch please?
> > 
> > Sean,
> > 
> > I think you should be able to test this with the vivid driver. Load the vivid driver,
> > run:
> > 
> > cec-ctl --tv; cec-ctl -d1 --playback
> > 
> > Then:
> > 
> > cec-ctl -d1 -t0 --user-control-pressed ui-cmd=F5
> 
> Ah, thanks. That will help with testing/reproducing.
>  
> > That said, I tried this, but it doesn't crash for me, but perhaps I need to run
> > some RC command first...
> 
> Hmm I think those commands should be enough. It probably needs
> CONFIG_DEBUG_SPINLOCK to detect the uninitialized spinlock. I'm trying it now.

Yes, that turned out to work. With CONFIG_DEBUG_SPINLOCK on, it goes bang
every time. With the patch, the problem goes away.

Without CONFIG_DEBUG_SPINLOCK we're going into undefined behaviour, so 
Torbjorn you're only seeing the oops occassionally (and which is why it has
not been observed or reported before).

Thanks,

Sean

  parent reply	other threads:[~2018-10-22 21:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-20 13:26 cec kernel oops with pulse8 usb cec adapter Torbjorn Jansson
2018-10-20 21:12 ` Hans Verkuil
2018-10-22  8:59   ` Sean Young
2018-10-22  9:44     ` Torbjorn Jansson
2018-10-22 10:14       ` [PATCH] media: rc: cec devices do not have a lirc chardev Sean Young
2018-10-22 10:14         ` Sean Young
2018-10-22 11:30         ` Hans Verkuil
2018-10-22 12:28           ` Sean Young
2018-10-22 12:28             ` Sean Young
2018-10-22 12:44             ` Torbjorn Jansson
2018-10-22 13:17             ` Sean Young [this message]
2018-11-14 12:18               ` Torbjorn Jansson
2018-11-14 13:00     ` cec kernel oops with pulse8 usb cec adapter Torbjorn Jansson
2018-11-14 13:23       ` Hans Verkuil
2018-11-14 16:22         ` Torbjorn Jansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181022131727.yf5e6gorccs3m6w7@gofer.mess.org \
    --to=sean@mess.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torbjorn.jansson@mbox200.swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.