From: Ali Alnubani <alialnu@mellanox.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: [PATCH] devtools: disable coloring of git-log output
Date: Tue, 23 Oct 2018 08:52:30 +0000 [thread overview]
Message-ID: <20181023085217.18548-1-alialnu@mellanox.com> (raw)
Colored git-log outputs will have escape characters
appended to hashes, causing check-git-log.sh to fail
with `error: malformed object name ?[33m<hash>?[m` when doing
`git tag -l --contains <colored_hash>`.
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
devtools/git-log-fixes.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index e37ee2260..464b0a41a 100755
--- a/devtools/git-log-fixes.sh
+++ b/devtools/git-log-fixes.sh
@@ -94,7 +94,7 @@ stable_tag () # <hash>
fi
}
-git log --oneline --reverse $range |
+git log --no-color --oneline --reverse $range |
while read id headline ; do
origins=$(origin_filter $id)
stable=$(stable_tag $id)
--
2.19.1
next reply other threads:[~2018-10-23 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 8:52 Ali Alnubani [this message]
2018-11-18 23:01 ` [PATCH] devtools: disable coloring of git-log output Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023085217.18548-1-alialnu@mellanox.com \
--to=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.