From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 3/4] net: phy-c45: Implement
 reset/suspend/resume callbacks
Date: Tue, 23 Oct 2018 14:38:41 +0200
Message-ID: <20181023123841.GA21149@lunn.ch>
References: <cover.1540204182.git.joabreu@synopsys.com>
 <b65cd0978587224eb1496ad60d224394525b8ba6.1540204183.git.joabreu@synopsys.com>
 <20181022122839.GB24112@lunn.ch>
 <8114f345-0efb-9a64-b867-2cfe2fba09ab@synopsys.com>
 <20181022154851.GA1492@n2100.armlinux.org.uk>
 <f8cd48a0-2cf5-5718-a6a6-1e9824834720@gmail.com>
 <943a6194-001a-d6a0-84ba-b93b728ce64b@synopsys.com>
 <20181023102023.GM30658@n2100.armlinux.org.uk>
 <d7abcce6-e935-8897-0307-8c5a8afd0990@synopsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <joao.pinto@synopsys.com>
To: Jose Abreu <jose.abreu@synopsys.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:41114 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727514AbeJWVCH (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 23 Oct 2018 17:02:07 -0400
Content-Disposition: inline
In-Reply-To: <d7abcce6-e935-8897-0307-8c5a8afd0990@synopsys.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> If it's okay for Generic 10G driver I can submit only this and
> manually reset PHY in stmmac driver so that I don't need to
> implement custom PHY driver ...

Hi Jose

That is a bad idea. What happens when somebody uses a different PHY
which uses a different reset sequence? Please keep with the
abstraction. Anything touching the PHY needs to be in a PHY driver, or
phylib.

   Andrew