From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Simplify has_sagv Date: Tue, 23 Oct 2018 12:05:30 -0700 Message-ID: <20181023190530.GK5342@intel.com> References: <874ldeh4vi.fsf@intel.com> <20181022165744.11788-1-rodrigo.vivi@intel.com> <87in1tdt38.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C0CE6E229 for ; Tue, 23 Oct 2018 19:05:34 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87in1tdt38.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjMsIDIwMTggYXQgMTA6MjM6MzlBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gTW9uLCAyMiBPY3QgMjAxOCwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50 ZWwuY29tPiB3cm90ZToKPiA+IExldCdzIGFkZCBhIHBsYXRmb3JtIGhhc19zYWd2IGluc3RlYWQg b2YgaGF2aW5nIGEgZnVsbAo+ID4gZnVuY3Rpb24gdGhhdCBoYW5kbGUgcGxhdGZvcm0gYnkgcGxh dGZvcm0uCj4gPgo+ID4gVGhlIHNwZWNpYWxseSBjYXNlIGZvciBTS0wgZm9yIG5vdCBjb250cm9s bGVkIHNhZ3YKPiA+IGlzIGFscmVhZHkgdGFrZW4gY2FyZSBpbnNpZGUgaW50ZWxfZW5hYmxlX3Nh Z3YsIHNvIHRoZXJlJ3MKPiA+IG5vIG5lZWQgdG8gZHVwbGljYXRlIHRoZSBjaGVjayBoZXJlLgo+ ID4KPiA+IHYyOiBHbyBvbmUgc3RlcCBmdXJ0aGVyIGFuZCByZW1vdmUgc2tsIHNwZWNpYWwgY2Fz ZS4gKEphbmkpCj4gPgo+ID4gdjM6IFNlcGFyYXRlIHJ1bnRpbWUgc3RhdHVzIGhhbmRsZSBmcm9t IGhhc19zYWd2IGZsYWcuIChKYW5pKQo+ID4KPiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAaW50ZWwuY29tPgo+ID4gQ2M6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50 ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50 ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAg ICAgICB8ICAxICsKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jICAgICAgICAg IHwgIDEgKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmggfCAg MSArCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyAgICAgICAgICB8IDI5ICsr KysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9u cygrKSwgMTkgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiBp bmRleCAzMDE3ZWYwMzdmZWQuLjliOThjZWIyZDAyOSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmgKPiA+IEBAIC0yNjUwLDYgKzI2NTAsNyBAQCBpbnRlbF9pbmZvKGNvbnN0IHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAjZGVmaW5lIEhBU19EREkoZGV2X3By aXYpCQkgKChkZXZfcHJpdiktPmluZm8uaGFzX2RkaSkKPiA+ICAjZGVmaW5lIEhBU19GUEdBX0RC R19VTkNMQUlNRUQoZGV2X3ByaXYpICgoZGV2X3ByaXYpLT5pbmZvLmhhc19mcGdhX2RiZykKPiA+ ICAjZGVmaW5lIEhBU19QU1IoZGV2X3ByaXYpCQkgKChkZXZfcHJpdiktPmluZm8uaGFzX3BzcikK PiA+ICsjZGVmaW5lIEhBU19TQUdWKGRldl9wcml2KQkJICgoZGV2X3ByaXYpLT5pbmZvLmhhc19z YWd2KQo+ID4gIAo+ID4gICNkZWZpbmUgSEFTX1JDNihkZXZfcHJpdikJCSAoKGRldl9wcml2KS0+ aW5mby5oYXNfcmM2KQo+ID4gICNkZWZpbmUgSEFTX1JDNnAoZGV2X3ByaXYpCQkgKChkZXZfcHJp diktPmluZm8uaGFzX3JjNnApCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9wY2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiA+IGluZGV4IDQ0 ZTc0NTkyMWFjMS4uMGIwOTE1NWVhYjYyIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9wY2kuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2ku Ywo+ID4gQEAgLTQ2NSw2ICs0NjUsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGludGVsX2Rldmlj ZV9pbmZvIGludGVsX2NoZXJyeXZpZXdfaW5mbyA9IHsKPiA+ICAJLmhhc19jc3IgPSAxLCBcCj4g PiAgCS5oYXNfZ3VjID0gMSwgXAo+ID4gIAkuaGFzX2lwYyA9IDEsIFwKPiA+ICsJLmhhc19zYWd2 ID0gMSwgXAo+ID4gIAkuZGRiX3NpemUgPSA4OTYKPiA+ICAKPiA+ICAjZGVmaW5lIFNLTF9QTEFU Rk9STSBcCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNl X2luZm8uaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmgKPiA+IGlu ZGV4IGFmNzAwMjY0MGNkZi4uZTc3YzhiNjI3ODNmIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uaAo+ID4gQEAgLTExNyw2ICsxMTcsNyBAQCBlbnVtIGlu dGVsX3BwZ3R0IHsKPiA+ICAJZnVuYyhod3NfbmVlZHNfcGh5c2ljYWwpOyBcCj4gPiAgCWZ1bmMo b3ZlcmxheV9uZWVkc19waHlzaWNhbCk7IFwKPiA+ICAJZnVuYyhzdXBwb3J0c190dik7IFwKPiA+ ICsJZnVuYyhoYXNfc2Fndik7IFwKPiA+ICAJZnVuYyhoYXNfaXBjKTsKPiA+ICAKPiA+ICAjZGVm aW5lIEdFTl9NQVhfU0xJQ0VTCQkoNikgLyogQ05MIHVwcGVyIGJvdW5kICovCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMKPiA+IGluZGV4IDY3YTRkMDczNTI5MS4uN2UzOGVkODQyMWM3IDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gQEAgLTM2MDksMjAgKzM2MDksNiBAQCBz dGF0aWMgYm9vbCBza2xfbmVlZHNfbWVtb3J5X2J3X3dhKHN0cnVjdCBpbnRlbF9hdG9taWNfc3Rh dGUgKnN0YXRlKQo+ID4gIAlyZXR1cm4gZmFsc2U7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyBi b29sCj4gPiAtaW50ZWxfaGFzX3NhZ3Yoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ID4gLXsKPiA+IC0JaWYgKElTX0tBQllMQUtFKGRldl9wcml2KSB8fCBJU19DT0ZGRUVMQUtF KGRldl9wcml2KSB8fAo+ID4gLQkgICAgSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikgfHwgSVNfSUNF TEFLRShkZXZfcHJpdikpCj4gPiAtCQlyZXR1cm4gdHJ1ZTsKPiA+IC0KPiA+IC0JaWYgKElTX1NL WUxBS0UoZGV2X3ByaXYpICYmCj4gPiAtCSAgICBkZXZfcHJpdi0+c2Fndl9zdGF0dXMgIT0gSTkx NV9TQUdWX05PVF9DT05UUk9MTEVEKQo+ID4gLQkJcmV0dXJuIHRydWU7Cj4gPiAtCj4gPiAtCXJl dHVybiBmYWxzZTsKPiA+IC19Cj4gCj4gQXJnaC4gQWxsIEkgZXZlciB3YW50ZWQgd2FzIGEgdmVy c2lvbiBvZiBbMV0gdGhhdCByZW1vdmVkIHRoZSBTa3lsYWtlCj4gc3BlY2lhbCBjYXNpbmcgZm9y IEk5MTVfU0FHVl9OT1RfQ09OVFJPTExFRC4gSSBldmVuIHdyb3RlIHdoYXQgdGhlCj4gZnVuY3Rp b24gY291bGQgYmUgaW4gaXRzIGVudGlyZXR5Ogo+IAo+IAkgIHJldHVybiAoSVNfR0VOOV9CQyhk ZXZfcHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMCkgJiYgCj4gCQkgIGRldl9wcml2 LT5zYWd2X3N0YXR1cyAhPSBJOTE1X1NBR1ZfTk9UX0NPTlRST0xMRUQ7CgpXZWxsLCB0aGF0IHdv cmtzIGZvciBtZSBhcyB3ZWxsLgoKPiAKPiBJTU8gYWxsIGl0ZXJhdGlvbnMgc2luY2UgaGF2ZSBi ZWVuIHdvcnNlLgoKQnV0IEkgdGhvdWdodCB3aGlsZSBkb2luZyB0aGlzIEkgY291bGQgY29uc29s aWRhZGUgaXQgYWxvbmcgd2l0aCBhbGwKdGhlIG90aGVyIGhhc19mZWF0dXJlIGNhc2VzLgoKSSBi ZWxpZXZlIHdlIHNob3VsZCBlaXRoZXIgaGF2ZSBldmVyeXRoaW5nIGFzIGluZm8uaGFzX2ZlYXR1 cmUgb3IgZXZlcnl0aGluZwphcyBoYXNfZmVhdHVyZSgpLgoKZm9yIGluc3RhbmNlIGlmIHdlIGVu ZCB1cCBldmVyIGhhdmluZyAyIHBsYXRmb3JtcyBvZiBzYW1lIGdlbiB3aGVyZQpvbmUgaGFzX3Nh Z3YgYW5kIHRoZSBvdGhlciBkb2Vzbid0IHdlIHdvdWxkIGhhdmUgdGhhdCBpbiB0aGUgcGxhdGZv cm0KZGVmaW5pdGlvbiB3aGlsZSBtYWtpbmcgdXMgdG8gZGVmaW5lIGFub3RoZXIgY29kZW5hbWUg YW5kIGFkZCBpdCBoZXJlCm9yIGV2ZW4gd29yc2UgaWYgd2UgZG9uJ3QgaGF2ZSBhIGNvZGVuYW1l IGF2YWlsYWJsZSBsaWtlIENOTF9XSVRIX1BPUlRfRiA6LwoKQnV0IHllYXAsIGZvciBub3cgbGV0 J3MgbW92ZSB3aXRoIHlvdXIgc3VnZ2VzdGlvbi4KClRoYW5rcywKUm9kcmlnby4KCj4gCj4gQlIs Cj4gSmFuaS4KPiAKPiAKPiBbMV0gaHR0cDovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0 Y2gvbXNnaWQvMjAxODEwMTgyMzM0NDcuNTE4Ny05LXJvZHJpZ28udml2aUBpbnRlbC5jb20KPiAK PiAKPiAKPiA+IC0KPiA+ICAvKgo+ID4gICAqIFNBR1YgZHluYW1pY2FsbHkgYWRqdXN0cyB0aGUg c3lzdGVtIGFnZW50IHZvbHRhZ2UgYW5kIGNsb2NrIGZyZXF1ZW5jaWVzCj4gPiAgICogZGVwZW5k aW5nIG9uIHBvd2VyIGFuZCBwZXJmb3JtYW5jZSByZXF1aXJlbWVudHMuIFRoZSBkaXNwbGF5IGVu Z2luZSBhY2Nlc3MKPiA+IEBAIC0zNjM5LDEwICszNjI1LDExIEBAIGludGVsX2VuYWJsZV9zYWd2 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICB7Cj4gPiAgCWludCByZXQ7 Cj4gPiAgCj4gPiAtCWlmICghaW50ZWxfaGFzX3NhZ3YoZGV2X3ByaXYpKQo+ID4gKwlpZiAoIUhB U19TQUdWKGRldl9wcml2KSkKPiA+ICAJCXJldHVybiAwOwo+ID4gIAo+ID4gLQlpZiAoZGV2X3By aXYtPnNhZ3Zfc3RhdHVzID09IEk5MTVfU0FHVl9FTkFCTEVEKQo+ID4gKwlpZiAoZGV2X3ByaXYt PnNhZ3Zfc3RhdHVzID09IEk5MTVfU0FHVl9FTkFCTEVEIHx8Cj4gPiArCSAgICBkZXZfcHJpdi0+ c2Fndl9zdGF0dXMgPT0gSTkxNV9TQUdWX05PVF9DT05UUk9MTEVEKQo+ID4gIAkJcmV0dXJuIDA7 Cj4gPiAgCj4gPiAgCURSTV9ERUJVR19LTVMoIkVuYWJsaW5nIHRoZSBTQUdWXG4iKTsKPiA+IEBA IC0zNjc2LDEwICszNjYzLDExIEBAIGludGVsX2Rpc2FibGVfc2FndihzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgewo+ID4gIAlpbnQgcmV0Owo+ID4gIAo+ID4gLQlpZiAo IWludGVsX2hhc19zYWd2KGRldl9wcml2KSkKPiA+ICsJaWYgKCFIQVNfU0FHVihkZXZfcHJpdikp Cj4gPiAgCQlyZXR1cm4gMDsKPiA+ICAKPiA+IC0JaWYgKGRldl9wcml2LT5zYWd2X3N0YXR1cyA9 PSBJOTE1X1NBR1ZfRElTQUJMRUQpCj4gPiArCWlmIChkZXZfcHJpdi0+c2Fndl9zdGF0dXMgPT0g STkxNV9TQUdWX0RJU0FCTEVEIHx8Cj4gPiArCSAgICBkZXZfcHJpdi0+c2Fndl9zdGF0dXMgPT0g STkxNV9TQUdWX05PVF9DT05UUk9MTEVEKQo+ID4gIAkJcmV0dXJuIDA7Cj4gPiAgCj4gPiAgCURS TV9ERUJVR19LTVMoIkRpc2FibGluZyB0aGUgU0FHVlxuIik7Cj4gPiBAQCAtMzcyMSw3ICszNzA5 LDEwIEBAIGJvb2wgaW50ZWxfY2FuX2VuYWJsZV9zYWd2KHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdGF0ZSkKPiA+ICAJaW50IGxldmVsLCBsYXRlbmN5Owo+ID4gIAlpbnQgc2Fndl9ibG9ja190 aW1lX3VzOwo+ID4gIAo+ID4gLQlpZiAoIWludGVsX2hhc19zYWd2KGRldl9wcml2KSkKPiA+ICsJ aWYgKCFIQVNfU0FHVihkZXZfcHJpdikpCj4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiArCj4gPiAr CWlmIChkZXZfcHJpdi0+c2Fndl9zdGF0dXMgPT0gSTkxNV9TQUdWX05PVF9DT05UUk9MTEVEKQo+ ID4gIAkJcmV0dXJuIGZhbHNlOwo+ID4gIAo+ID4gIAlpZiAoSVNfR0VOOShkZXZfcHJpdikpCj4g Cj4gLS0gCj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK