From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4 1/8] drm/i915: Make sure fb gtt offsets stay within 32bits Date: Tue, 23 Oct 2018 22:16:07 +0300 Message-ID: <20181023191607.GY9144@intel.com> References: <20180925193714.25280-2-ville.syrjala@linux.intel.com> <20181023160201.9840-1-ville.syrjala@linux.intel.com> <154032058266.9962.2779486016415271875@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FF156E097 for ; Tue, 23 Oct 2018 19:16:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <154032058266.9962.2779486016415271875@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjMsIDIwMTggYXQgMDc6NDk6NDJQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOC0xMC0yMyAxNzowMjowMSkKPiA+IEZy b206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK PiA+IExldCdzIHRyeSB0byBtYWtlIHN1cmUgdGhlIGZiIG9mZnNldCBjb21wdXRhdGlvbnMgbmV2 ZXIgaGl0Cj4gPiBhbiBpbnRlZ2VyIG92ZXJmbG93IGJ5IG1ha2luZyBzdXJlIHRoZSBlbnRpcmUg ZmIgc3RheXMKPiA+IGJlbG93IDMyYml0cy4gZnJhbWVidWZmZXJfY2hlY2soKSBpbiB0aGUgY29y ZSBhbHJlYWR5IGRvZXMKPiA+IHRoZSBzYW1lIGNoZWNrLCBidXQgYXMgaXQgZG9lc24ndCBrbm93 IGFib3V0IHRpbGluZyBzb21lIHRoaW5ncwo+ID4gY2FuIHNsaXAgdGhyb3VnaC4gUmVwZWF0IHRo ZSBjaGVjayBpbiB0aGUgZHJpdmVyIHdpdGggdGlsaW5nCj4gPiB0YWtlbiBpbnRvIGFjY291bnQu Cj4gPiAKPiA+IHYyOiBVc2UgYWRkX292ZXJmbG93cygpIGFmdGVyIG1hc3NhZ2luZyBpdCB0byB3 b3JrIGZvciBtZSAoQ2hyaXMpCj4gPiB2MzogQ2FsbCBpdCBhZGRfb3ZlcmZsb3dfdCgpIHRvIG1h dGNoIG1pbl90KCkgJiBjby4gKENocmlzKQo+ID4gCj4gPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV91dGlscy5oICAgIHwgMTEgKysrKysrKy0tLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxOCArKysrKysrKysrKysrKysrKy0KPiA+ICAy IGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPiAKPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmggYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmgKPiA+IGluZGV4IDU4NThhNDNlMTlkYS4uOTcyNmRm MzdjNGM0IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5o Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3V0aWxzLmgKPiA+IEBAIC00NCwx NiArNDQsMTkgQEAKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX19zdHJpbmdpZnko eCksIChsb25nKSh4KSkKPiA+ICAKPiA+ICAjaWYgZGVmaW5lZChHQ0NfVkVSU0lPTikgJiYgR0ND X1ZFUlNJT04gPj0gNzAwMDAKPiA+IC0jZGVmaW5lIGFkZF9vdmVyZmxvd3MoQSwgQikgXAo+ID4g LSAgICAgICBfX2J1aWx0aW5fYWRkX292ZXJmbG93X3AoKEEpLCAoQiksICh0eXBlb2YoKEEpICsg KEIpKSkwKQo+ID4gKyNkZWZpbmUgYWRkX292ZXJmbG93c190KFQsIEEsIEIpIFwKPiA+ICsgICAg ICAgX19idWlsdGluX2FkZF9vdmVyZmxvd19wKChBKSwgKEIpLCAoVCkwKQo+ID4gICNlbHNlCj4g PiAtI2RlZmluZSBhZGRfb3ZlcmZsb3dzKEEsIEIpICh7IFwKPiA+ICsjZGVmaW5lIGFkZF9vdmVy Zmxvd3NfdChULCBBLCBCKSAoeyBcCj4gPiAgICAgICAgIHR5cGVvZihBKSBhID0gKEEpOyBcCj4g PiAgICAgICAgIHR5cGVvZihCKSBiID0gKEIpOyBcCj4gPiAtICAgICAgIGEgKyBiIDwgYTsgXAo+ ID4gKyAgICAgICAoVCkoYSArIGIpIDwgYTsgXAo+ID4gIH0pCj4gPiAgI2VuZGlmCj4gPiAgCj4g PiArI2RlZmluZSBhZGRfb3ZlcmZsb3dzKEEsIEIpIFwKPiA+ICsgICAgICAgYWRkX292ZXJmbG93 c190KHR5cGVvZigoQSkgKyAoQikpLCAoQSksIChCKSkKPiA+ICsKPiA+ICAjZGVmaW5lIHJhbmdl X292ZXJmbG93cyhzdGFydCwgc2l6ZSwgbWF4KSAoeyBcCj4gPiAgICAgICAgIHR5cGVvZihzdGFy dCkgc3RhcnRfXyA9IChzdGFydCk7IFwKPiA+ICAgICAgICAgdHlwZW9mKHNpemUpIHNpemVfXyA9 IChzaXplKTsgXAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXgg OTY5ZDIyY2E4ZGNkLi5lNTIwZmFjYzIzZTEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+ID4gQEAgLTIzNTEsMTAgKzIzNTEsMjYgQEAgc3RhdGljIGludCBpbnRl bF9mYl9vZmZzZXRfdG9feHkoaW50ICp4LCBpbnQgKnksCj4gPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpbnQgY29sb3JfcGxhbmUpCj4gPiAgewo+ID4gICAgICAgICBzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGZiLT5kZXYpOwo+ID4gKyAgICAg ICB1bnNpZ25lZCBpbnQgaGVpZ2h0Owo+ID4gIAo+ID4gICAgICAgICBpZiAoZmItPm1vZGlmaWVy ICE9IERSTV9GT1JNQVRfTU9EX0xJTkVBUiAmJgo+ID4gLSAgICAgICAgICAgZmItPm9mZnNldHNb Y29sb3JfcGxhbmVdICUgaW50ZWxfdGlsZV9zaXplKGRldl9wcml2KSkKPiA+ICsgICAgICAgICAg IGZiLT5vZmZzZXRzW2NvbG9yX3BsYW5lXSAlIGludGVsX3RpbGVfc2l6ZShkZXZfcHJpdikpIHsK PiA+ICsgICAgICAgICAgICAgICBEUk1fREVCVUdfS01TKCJNaXNhbGlnbmVkIG9mZnNldCAweCUw OHggZm9yIGNvbG9yIHBsYW5lICVkXG4iLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZmItPm9mZnNldHNbY29sb3JfcGxhbmVdLCBjb2xvcl9wbGFuZSk7Cj4gPiAgICAgICAgICAg ICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gPiArICAgICAgIH0KPiA+ICsKPiA+ICsgICAgICAgaGVp Z2h0ID0gZHJtX2ZyYW1lYnVmZmVyX3BsYW5lX2hlaWdodChmYi0+aGVpZ2h0LCBmYiwgY29sb3Jf cGxhbmUpOwo+ID4gKyAgICAgICBoZWlnaHQgPSBBTElHTihoZWlnaHQsIGludGVsX3RpbGVfaGVp Z2h0KGZiLCBjb2xvcl9wbGFuZSkpOwo+IAo+IGZiIGhlaWdodCBpcyBsaW1pdGVkIHRvIHUxNiBv ciB0aGVyZWFib3V0cz8KClRoZXJlYWJvdXRzLiBXb3VsZCBiZSA8PTE2ayBhZnRlciB0aGUgbGFz dCBwYXRjaCBpbiB0aGUgc2VyaWVzLgoKPiAKPiA+ICsKPiA+ICsgICAgICAgLyogQ2F0Y2ggcG90 ZW50aWFsIG92ZXJmbG93cyBlYXJseSAqLwo+ID4gKyAgICAgICBpZiAoYWRkX292ZXJmbG93c190 KHUzMiwgbXVsX3UzMl91MzIoaGVpZ2h0LCBmYi0+cGl0Y2hlc1tjb2xvcl9wbGFuZV0pLAo+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgIGZiLT5vZmZzZXRzW2NvbG9yX3BsYW5lXSkpIHsK PiA+ICsgICAgICAgICAgICAgICBEUk1fREVCVUdfS01TKCJCYWQgb2Zmc2V0IDB4JTA4eCBvciBw aXRjaCAlZCBmb3IgY29sb3IgcGxhbmUgJWRcbiIsCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0sIGZiLT5waXRjaGVzW2NvbG9yX3BsYW5l XSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbG9yX3BsYW5lKTsKPiA+ICsg ICAgICAgICAgICAgICByZXR1cm4gLUVSQU5HRTsKPiA+ICsgICAgICAgfQo+IAo+IFJldmlld2Vk LWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtQ2hyaXMKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==