From: Yongseok Koh <yskoh@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: [PATCH] build: disable compiler AVX512F support
Date: Tue, 23 Oct 2018 21:23:28 +0000 [thread overview]
Message-ID: <20181023212318.43082-1-yskoh@mellanox.com> (raw)
This is a workaround to prevent a crash, which might be caused by
optimization of newer gcc (7.3.0) on Intel Skylake.
Bugzilla ID: 97
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
config/x86/meson.build | 5 +++++
mk/rte.cpuflags.mk | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/config/x86/meson.build b/config/x86/meson.build
index 33efb5e547..e10ba872ac 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -47,6 +47,11 @@ endif
if cc.get_define('__AVX512F__', args: march_opt) != ''
dpdk_conf.set('RTE_MACHINE_CPUFLAG_AVX512F', 1)
compile_time_cpuflags += ['RTE_CPUFLAG_AVX512F']
+else
+# disable compiler's AVX512F support as a workaround for Bug 97
+ if cc.has_argument('-mavx512f')
+ machine_args += '-mno-avx512f'
+ endif
endif
dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
index 43ed84155b..8fdb0cc2c3 100644
--- a/mk/rte.cpuflags.mk
+++ b/mk/rte.cpuflags.mk
@@ -68,6 +68,11 @@ endif
ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),)
ifeq ($(CONFIG_RTE_ENABLE_AVX512),y)
CPUFLAGS += AVX512F
+else
+# disable compiler's AVX512F support as a workaround for Bug 97
+ifeq ($(shell $(CC) --target-help | grep -q mavx512f && echo 1), 1)
+MACHINE_CFLAGS += -mno-avx512f
+endif
endif
endif
--
2.11.0
next reply other threads:[~2018-10-23 21:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 21:23 Yongseok Koh [this message]
2018-11-01 23:11 ` [PATCH] build: disable compiler AVX512F support Thomas Monjalon
2018-11-02 12:42 ` [dpdk-stable] " Ferruh Yigit
2018-11-02 13:48 ` Ferruh Yigit
2018-11-02 20:59 ` Yongseok Koh
2018-11-02 21:46 ` Ferruh Yigit
2018-11-02 23:31 ` Yongseok Koh
2018-11-02 21:04 ` [PATCH v2] " Yongseok Koh
2018-11-05 14:06 ` Wiles, Keith
2018-11-06 21:30 ` Yongseok Koh
2018-11-07 9:04 ` Wiles, Keith
2018-11-08 15:59 ` AVX512 bug on SkyLake Thomas Monjalon
2018-11-08 17:21 ` Ferruh Yigit
2018-11-08 23:01 ` Yongseok Koh
2018-11-09 6:27 ` Christian Ehrhardt
2018-11-09 9:49 ` Ferruh Yigit
2018-11-09 11:35 ` Thomas Monjalon
2018-11-09 10:03 ` Ferruh Yigit
2018-11-09 13:17 ` [dpdk-stable] " Thomas Monjalon
2018-11-09 14:27 ` Thomas Monjalon
2018-11-09 20:06 ` Ferruh Yigit
2018-11-09 18:46 ` Stephen Hemminger
2018-11-10 2:13 ` [dpdk-stable] " Thomas Monjalon
2018-11-11 14:15 ` Ananyev, Konstantin
2018-11-11 18:15 ` Thomas Monjalon
2018-11-12 9:09 ` Christian Ehrhardt
2018-11-12 9:21 ` Thomas Monjalon
2018-11-12 9:26 ` Ananyev, Konstantin
2018-11-03 1:06 ` [PATCH v3] build: disable gcc AVX512F support Yongseok Koh
2018-11-04 20:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023212318.43082-1-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.