From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy Date: Wed, 24 Oct 2018 14:35:41 -0700 (PDT) Message-ID: <20181024.143541.2180259142654512809.davem@davemloft.net> References: <20181024153249.15374-1-dsahern@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, pupilla@libero.it, dsahern@gmail.com To: dsahern@kernel.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:41736 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726207AbeJYGF0 (ORCPT ); Thu, 25 Oct 2018 02:05:26 -0400 In-Reply-To: <20181024153249.15374-1-dsahern@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Wed, 24 Oct 2018 08:32:49 -0700 > From: David Ahern > > Marco reported an error with hfsc: > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 > Error: Attribute failed policy validation. > > Apparently a few implementations pass TCA_OPTIONS as a binary instead > of nested attribute, so drop TCA_OPTIONS from the policy. > > Fixes: 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes") > Reported-by: Marco Berizzi > Signed-off-by: David Ahern That's unfortunate... applied, thanks.