From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/6] drm/atomic: Add ->atomic_check() hook for private objects Date: Wed, 24 Oct 2018 10:45:36 +0200 Message-ID: <20181024084536.GG324@phenom.ffwll.local> References: <20181023231251.16883-1-lyude@redhat.com> <20181023231251.16883-4-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181023231251.16883-4-lyude@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lyude Paul Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: nouveau.vger.kernel.org T24gVHVlLCBPY3QgMjMsIDIwMTggYXQgMDc6MTI6NDhQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBDdXJyZW50bHk7IHByaXZhdGUgb2JqZWN0cyBhcmUgbW9zdGx5IHVzZWQganVzdCBmb3Ig ZHJpdmVyLXNwZWNpZmljCj4gYXRvbWljIHN0YXRlLCBidXQgbm90IGVudGlyZWx5LiBNU1QgYWxz byB1c2VzIHByaXZhdGUgb2JqZWN0cyBmb3IKPiBob2xkaW5nIGl0J3MgYXRvbWljIHN0YXRlLCBi dXQgaW4gb3JkZXIgdG8gbWFrZSBvdXIgTVNUIGhlbHBlcnMgc2FmZXIKPiBmb3IgYXRvbWljIHdl IG5lZWQgdG8gYmUgYWJsZSB0byBjaGVjayB0aGF0IHN0YXRlIGFmdGVyIHRoZSBkcml2ZXIgaGFz Cj4gcGVyZm9ybWVkIGl0J3Mgb3duIGNoZWNrcyBvbiB0aGUgYXRvbWljIHN0YXRlLiBTbywgYWRk IGFuIG9wdGlvbmFsCj4gLT5hdG9taWNfY2hlY2soKSBjYWxsYmFjayBpbnRvIGRybV9wcml2YXRl X3N0YXRlX2Z1bmNzIHRoYXQgZ2V0cyBjYWxsZWQKPiBhZnRlciB0aGUgZHJpdmVyJ3MgYXRvbWlj IGNoZWNrcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29t Pgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKSSB0aGluayB0 aGUgb3ZlcmFsbCBhaW0gaGVyZSBvZiBwdXR0aW5nIG1vcmUgb2YgdGhlIHZhbGlkYXRpb24gaW50 byB0aGUgZHAKbXN0IGhlbHBlciBtYWtlcyB0b25zIG9mIHNlbnNlLgoKSSdtIG5vdCBzdXJlIHdo ZXRoZXIgYWRkaW5nIGFuIGF0b21pY19jaGVjayBjYWxsYmFjayB0byBwcml2YXRlIHN0YXRlCm9i amVjdHMgbWFrZXMgc2Vuc2UuIFRoZXNlIGNhbiBiZSB1c2VkIGZvciBhbnl0aGluZywgYW5kIGRy aXZlcnMgZG8gdXNlCnRoZW0gZm9yIGFueXRoaW5nIHJlYWxseS4gU28gaXQncyBlbnRpcmVseSBp bXBvc3NpYmxlIHRvIGhhdmUganVzdCAxIHBsYWNlCndoZXJlIHlvdSBjYWxsIHRoZSAtPmF0b21p Y19jaGVjayBmb3IgYWxsIHByaXZhdGUgb2JqZWN0cy4gVGhpcyBkb2Vzbid0CndvcmsgZm9yIGFs bCB0aGUgb3RoZXIgbW9yZSBzdGFuZGFyZGl6ZWQgb2JqZWN0cyBlaXRoZXIsIGl0J3MgZ3VhcmFu dGVlZAp0byBmYWlsIGZvciBzb21ldGhpbmcgdGhhdCdzIDEwMCUgZ2VuZXJpYywgbm8gc3RhbmRh cmQgdXNlIGNhc2UuCgpBbHNvLCB5b3UncmUgcHV0dGluZyBoZWxwZXItbGV2ZWwgbG9naWMgKHRo ZSBvYmplY3QgYmFzZWQgLT5hdG9taWNfY2hlY2sKY2FsbGJhY2spIGludG8gdGhlIGNvcmUsIHRo YXQncyBtaWRsYXllciBtaXhpbmcuCgpJbnN0ZWFkIEkgdGhpbmsgYSBiZXR0ZXIgZGVzaWduIGlz IHRvIGp1c3Qgd3JpdGUgc29tZXRoaW5nIGZvciBkcCBtc3QuCldpdGggdGhlIHByaXZhdGUgc3Rh dGUgbWFjcm9zIGl0J3MgZWFzeSB0byBpdGVyYXRlIGp1c3Qgb3ZlciBhbGwgdGhlIG1zdApzdGF0 ZXMgKGZpbHRlciBmb3IgdGhlIG1zdCB2dGFibGUsIHlvdSBjb3VsZCB3cmFwIHRoYXQgaW50byBh IGhlbHBlciBtYWNybwp3aXRoIGZvcl9lYWNoX2lmIGV2ZW4pLiBBbmQgdGhlbiBleHBvc2Ugb25l IGZ1bmN0aW9uIGZyb20gbXN0IGhlbHBlcnMgdG8KZHJpdmVycyB0aGF0IHRoZXkncmUgc3VwcG9z ZWQgdG8gY2FsbCBmcm9tIHRoZWlyIGF0b21pY19jaGVjaywgYXQKZXhhY3RseSB0aGUgcmlnaHQg c3BvdC4gSSB0aGluayB0aGUgb3ZlcmxhcCBvZiAiZHJpdmVycyB0aGF0IHdhbnQgbXN0IiBhbmQK ImRyaXZlcnMgc2ltcGx5IGVub3VnaCB0aGV5IGRvbid0IG5lZWQgdGhlaXIgb3duIGF0b21pY19j aGVjayIgaXMgemVyby4KClRoaXMgd29uJ3QgaW1wb3NlIGFueSB0cmFwZG9vcnMgb24gcGVvcGxl IHRyeWluZyB0byB1c2UgcHJpdmF0ZSBvYmplY3RzIHRvCmUuZy4gbWFuYWdlIHBsYW5lIHNjYWxl ciBvciB0aGluZ3MgbGlrZSB0aGF0LgoKQW5kIHdlIGNvdWxkIHN0aWxsIGhvb2sgaXQgdXAgYnkg ZGVmYXVsdCBhbmQgZS5nLiBjYWxsIHRoZQpkcm1fZHBfbXN0X3RvcG9sb2d5X2F0b21pY19jaGVj aygpIGZyb20gZHJtX2F0b21pY19oZWxwZXJfY2hlY2soKSwgbWF5YmUKcmlnaHQgYWZ0ZXIgY2Fs bGluZyBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0KCkuIEJ1dCBub3QgZnJvbSB0aGUK c2FtZSwgdG8gZ2l2ZSBkcml2ZXJzIGEgYml0IG1vcmUgZmxleGliaWxpdHkgaW4gaG93IHRoZXkg aGFuZGxlIHRoaXMKKHNpbWlsYXIgdG8gaG93IHRoZSB6cG9zIHRoaW5nIHdvcmtzKS4KLURhbmll bAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8IDE0ICsrKysrKysrKysr KysrCj4gIGluY2x1ZGUvZHJtL2RybV9hdG9taWMuaCAgICAgfCAxNiArKysrKysrKysrKysrKysr Cj4gIDIgZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMu Ywo+IGluZGV4IDNkYmZiZGRhZTdlNi4uMmRiOWYyMTk3MzJiIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21p Yy5jCj4gQEAgLTk2Niw2ICs5NjYsOCBAQCBpbnQgZHJtX2F0b21pY19jaGVja19vbmx5KHN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0 Y19zdGF0ZTsKPiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uOwo+ICAJc3RydWN0IGRybV9j b25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gKwlzdHJ1Y3QgZHJtX3ByaXZhdGVfb2JqICpw cml2X29iajsKPiArCXN0cnVjdCBkcm1fcHJpdmF0ZV9zdGF0ZSAqcHJpdl9zdGF0ZTsKPiAgCWlu dCBpLCByZXQgPSAwOwo+ICAKPiAgCURSTV9ERUJVR19BVE9NSUMoImNoZWNraW5nICVwXG4iLCBz dGF0ZSk7Cj4gQEAgLTEwMDcsNiArMTAwOSwxOCBAQCBpbnQgZHJtX2F0b21pY19jaGVja19vbmx5 KHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCQl9Cj4gIAl9Cj4gIAo+ICsJZm9y X2VhY2hfbmV3X3ByaXZhdGVfb2JqX2luX3N0YXRlKHN0YXRlLCBwcml2X29iaiwgcHJpdl9zdGF0 ZSwgaSkgewo+ICsJCWlmICghcHJpdl9vYmotPmZ1bmNzLT5hdG9taWNfY2hlY2spCj4gKwkJCWNv bnRpbnVlOwo+ICsKPiArCQlyZXQgPSBwcml2X29iai0+ZnVuY3MtPmF0b21pY19jaGVjayhwcml2 X29iaiwgcHJpdl9zdGF0ZSk7Cj4gKwkJaWYgKHJldCkgewo+ICsJCQlEUk1fREVCVUdfQVRPTUlD KCJbUFJJVkFURTolcF0gYXRvbWljIGNoZWNrIG9uIHN0YXRlICVwIGZhaWxlZFxuIiwKPiArCQkJ CQkgcHJpdl9vYmosIHByaXZfc3RhdGUpOwo+ICsJCQlyZXR1cm4gcmV0Owo+ICsJCX0KPiArCX0K PiArCj4gIAlpZiAoIXN0YXRlLT5hbGxvd19tb2Rlc2V0KSB7Cj4gIAkJZm9yX2VhY2hfbmV3X2Ny dGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpIHsKPiAgCQkJaWYgKGRybV9h dG9taWNfY3J0Y19uZWVkc19tb2Rlc2V0KGNydGNfc3RhdGUpKSB7Cj4gZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvZHJtL2RybV9hdG9taWMuaCBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IGluZGV4 IGY5YjM1ODM0YzQ1ZC4uM2U1MDRlZWIxMTIyIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2Ry bV9hdG9taWMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IEBAIC0yMTYsNiAr MjE2LDIyIEBAIHN0cnVjdCBkcm1fcHJpdmF0ZV9zdGF0ZV9mdW5jcyB7Cj4gIAkgKi8KPiAgCXZv aWQgKCphdG9taWNfZGVzdHJveV9zdGF0ZSkoc3RydWN0IGRybV9wcml2YXRlX29iaiAqb2JqLAo+ ICAJCQkJICAgICBzdHJ1Y3QgZHJtX3ByaXZhdGVfc3RhdGUgKnN0YXRlKTsKPiArCj4gKwkvKioK PiArCSAqIEBhdG9taWNfY2hlY2s6Cj4gKwkgKgo+ICsJICogUGVyZm9ybSBhIGNoZWNrIG9mIHRo ZSBjdXJyZW50IHN0YXRlIG9mIHRoZSBwcml2YXRlIG9iamVjdCB0bwo+ICsJICogZW5zdXJlIHRo YXQgaXQncyB2YWxpZC4gVGhpcyBpcyBhbiBvcHRpb25hbCBjYWxsYmFjay4gSWYKPiArCSAqIGlt cGxlbWVudGVkLCBpdCB3aWxsIGJlIGNhbGxlZCBhZnRlciBhdG9taWMgY2hlY2tzIGhhdmUgYmVl bgo+ICsJICogcGVyZm9ybWVkIG9uIGFsbCBvZiB0aGUgcGxhbmVzLCBDUlRDcywgY29ubmVjdG9y cywgYW5kIHRoZSBuZXcKPiArCSAqICZkcm1fbW9kZV9jb25maWcgaW4gdGhlIGF0b21pYyBzdGF0 ZS4KPiArCSAqCj4gKwkgKiBSRVRVUk5TOgo+ICsJICoKPiArCSAqIDAgb24gc3VjY2VzcywgbmVn YXRpdmUgZXJyb3IgY29kZSBvbiBmYWlsdXJlLgo+ICsJICovCj4gKwlpbnQgKCphdG9taWNfY2hl Y2spKHN0cnVjdCBkcm1fcHJpdmF0ZV9vYmogKm9iaiwKPiArCQkJICAgIHN0cnVjdCBkcm1fcHJp dmF0ZV9zdGF0ZSAqc3RhdGUpOwo+ICB9Owo+ICAKPiAgLyoqCj4gLS0gCj4gMi4xNy4yCj4gCgot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==