* Attribute failed policy validation
@ 2018-10-24 9:56 Marco Berizzi
2018-10-24 13:07 ` Florian Westphal
0 siblings, 1 reply; 3+ messages in thread
From: Marco Berizzi @ 2018-10-24 9:56 UTC (permalink / raw)
To: netdev
Hi Folks,
I'm getting this message after the upgrade from linux 4.18
to 4.19
root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
Error: Attribute failed policy validation.
root@Calimero:~# lsmod | grep hfsc
sch_hfsc 24576 0
root@Calimero:~# tc -V
tc utility, iproute2-ss181023
Am I doing anything wrong?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Attribute failed policy validation
2018-10-24 9:56 Attribute failed policy validation Marco Berizzi
@ 2018-10-24 13:07 ` Florian Westphal
2018-10-24 14:58 ` David Ahern
0 siblings, 1 reply; 3+ messages in thread
From: Florian Westphal @ 2018-10-24 13:07 UTC (permalink / raw)
To: Marco Berizzi; +Cc: netdev, dsahern
Marco Berizzi <pupilla@libero.it> wrote:
[ CC David ]
> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> Error: Attribute failed policy validation.
caused by:
commit 8b4c3cdd9dd8290343ce959a132d3b334062c5b9
net: sched: Add policy validation for tc attributes
Looks like TCA_OPTIONS is NLA_BINARY in hfsc case, so
we can't enforce NLA_NESTED :-(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Attribute failed policy validation
2018-10-24 13:07 ` Florian Westphal
@ 2018-10-24 14:58 ` David Ahern
0 siblings, 0 replies; 3+ messages in thread
From: David Ahern @ 2018-10-24 14:58 UTC (permalink / raw)
To: Florian Westphal, Marco Berizzi; +Cc: netdev, dsahern
On 10/24/18 7:07 AM, Florian Westphal wrote:
> Marco Berizzi <pupilla@libero.it> wrote:
>
> [ CC David ]
>
>> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
>> Error: Attribute failed policy validation.
>
> caused by:
> commit 8b4c3cdd9dd8290343ce959a132d3b334062c5b9
> net: sched: Add policy validation for tc attributes
>
> Looks like TCA_OPTIONS is NLA_BINARY in hfsc case, so
> we can't enforce NLA_NESTED :-(
>
Yep. I'll send a fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-24 23:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24 9:56 Attribute failed policy validation Marco Berizzi
2018-10-24 13:07 ` Florian Westphal
2018-10-24 14:58 ` David Ahern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.