From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: [PATCH 1/3] i2c: sh_mobile: Remove dummy runtime PM callbacks Date: Wed, 24 Oct 2018 16:51:32 +0300 Message-ID: <20181024135134.28456-2-jarkko.nikula@linux.intel.com> References: <20181024135134.28456-1-jarkko.nikula@linux.intel.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-i2c@vger.kernel.org, Wolfram Sang , netdev@vger.kernel.org, "David S . Miller" , Sergei Shtylyov , linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, Yoshihiro Shimoda , Jarkko Nikula To: linux-pm@vger.kernel.org Return-path: Received: from mga11.intel.com ([192.55.52.93]:24935 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbeJXWTv (ORCPT ); Wed, 24 Oct 2018 18:19:51 -0400 In-Reply-To: <20181024135134.28456-1-jarkko.nikula@linux.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: Platform drivers don't need dummy runtime PM callbacks that just return success and non-NULL pm pointer in their struct device_driver in order to have runtime PM happening. This has changed since following commits: 05aa55dddb9e ("PM / Runtime: Lenient generic runtime pm callbacks") 543f2503a956 ("PM / platform_bus: Allow runtime PM by default") 8b313a38ecff ("PM / Platform: Use generic runtime PM callbacks directly") Signed-off-by: Jarkko Nikula --- Only build tested. --- drivers/i2c/busses/i2c-sh_mobile.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c index 818cab14e87c..a7a7a9c3bc7c 100644 --- a/drivers/i2c/busses/i2c-sh_mobile.c +++ b/drivers/i2c/busses/i2c-sh_mobile.c @@ -947,27 +947,9 @@ static int sh_mobile_i2c_remove(struct platform_device *dev) return 0; } -static int sh_mobile_i2c_runtime_nop(struct device *dev) -{ - /* Runtime PM callback shared between ->runtime_suspend() - * and ->runtime_resume(). Simply returns success. - * - * This driver re-initializes all registers after - * pm_runtime_get_sync() anyway so there is no need - * to save and restore registers here. - */ - return 0; -} - -static const struct dev_pm_ops sh_mobile_i2c_dev_pm_ops = { - .runtime_suspend = sh_mobile_i2c_runtime_nop, - .runtime_resume = sh_mobile_i2c_runtime_nop, -}; - static struct platform_driver sh_mobile_i2c_driver = { .driver = { .name = "i2c-sh_mobile", - .pm = &sh_mobile_i2c_dev_pm_ops, .of_match_table = sh_mobile_i2c_dt_ids, }, .probe = sh_mobile_i2c_probe, -- 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/3] i2c: sh_mobile: Remove dummy runtime PM callbacks From: Jarkko Nikula Message-Id: <20181024135134.28456-2-jarkko.nikula@linux.intel.com> Date: Wed, 24 Oct 2018 16:51:32 +0300 To: linux-pm@vger.kernel.org Cc: linux-i2c@vger.kernel.org, Wolfram Sang , netdev@vger.kernel.org, "David S . Miller" , Sergei Shtylyov , linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, Yoshihiro Shimoda , Jarkko Nikula List-ID: UGxhdGZvcm0gZHJpdmVycyBkb24ndCBuZWVkIGR1bW15IHJ1bnRpbWUgUE0gY2FsbGJhY2tzIHRo YXQganVzdCByZXR1cm4Kc3VjY2VzcyBhbmQgbm9uLU5VTEwgcG0gcG9pbnRlciBpbiB0aGVpciBz dHJ1Y3QgZGV2aWNlX2RyaXZlciBpbiBvcmRlcgp0byBoYXZlIHJ1bnRpbWUgUE0gaGFwcGVuaW5n LiBUaGlzIGhhcyBjaGFuZ2VkIHNpbmNlIGZvbGxvd2luZyBjb21taXRzOgoKMDVhYTU1ZGRkYjll ICgiUE0gLyBSdW50aW1lOiBMZW5pZW50IGdlbmVyaWMgcnVudGltZSBwbSBjYWxsYmFja3MiKQo1 NDNmMjUwM2E5NTYgKCJQTSAvIHBsYXRmb3JtX2J1czogQWxsb3cgcnVudGltZSBQTSBieSBkZWZh dWx0IikKOGIzMTNhMzhlY2ZmICgiUE0gLyBQbGF0Zm9ybTogVXNlIGdlbmVyaWMgcnVudGltZSBQ TSBjYWxsYmFja3MgZGlyZWN0bHkiKQoKU2lnbmVkLW9mZi1ieTogSmFya2tvIE5pa3VsYSA8amFy a2tvLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Ci0tLQpPbmx5IGJ1aWxkIHRlc3RlZC4KLS0tCiBk cml2ZXJzL2kyYy9idXNzZXMvaTJjLXNoX21vYmlsZS5jIHwgMTggLS0tLS0tLS0tLS0tLS0tLS0t CiAxIGZpbGUgY2hhbmdlZCwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9p MmMvYnVzc2VzL2kyYy1zaF9tb2JpbGUuYyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtc2hfbW9i aWxlLmMKaW5kZXggODE4Y2FiMTRlODdjLi5hN2E3YTljM2JjN2MgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvaTJjL2J1c3Nlcy9pMmMtc2hfbW9iaWxlLmMKKysrIGIvZHJpdmVycy9pMmMvYnVzc2VzL2ky Yy1zaF9tb2JpbGUuYwpAQCAtOTQ3LDI3ICs5NDcsOSBAQCBzdGF0aWMgaW50IHNoX21vYmlsZV9p MmNfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKmRldikKIAlyZXR1cm4gMDsKIH0KIAot c3RhdGljIGludCBzaF9tb2JpbGVfaTJjX3J1bnRpbWVfbm9wKHN0cnVjdCBkZXZpY2UgKmRldikK LXsKLQkvKiBSdW50aW1lIFBNIGNhbGxiYWNrIHNoYXJlZCBiZXR3ZWVuIC0+cnVudGltZV9zdXNw ZW5kKCkKLQkgKiBhbmQgLT5ydW50aW1lX3Jlc3VtZSgpLiBTaW1wbHkgcmV0dXJucyBzdWNjZXNz LgotCSAqCi0JICogVGhpcyBkcml2ZXIgcmUtaW5pdGlhbGl6ZXMgYWxsIHJlZ2lzdGVycyBhZnRl cgotCSAqIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBhbnl3YXkgc28gdGhlcmUgaXMgbm8gbmVlZAot CSAqIHRvIHNhdmUgYW5kIHJlc3RvcmUgcmVnaXN0ZXJzIGhlcmUuCi0JICovCi0JcmV0dXJuIDA7 Ci19Ci0KLXN0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2X3BtX29wcyBzaF9tb2JpbGVfaTJjX2Rldl9w bV9vcHMgPSB7Ci0JLnJ1bnRpbWVfc3VzcGVuZCA9IHNoX21vYmlsZV9pMmNfcnVudGltZV9ub3As Ci0JLnJ1bnRpbWVfcmVzdW1lID0gc2hfbW9iaWxlX2kyY19ydW50aW1lX25vcCwKLX07Ci0KIHN0 YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHNoX21vYmlsZV9pMmNfZHJpdmVyID0gewogCS5k cml2ZXIJCT0gewogCQkubmFtZQkJPSAiaTJjLXNoX21vYmlsZSIsCi0JCS5wbQkJPSAmc2hfbW9i aWxlX2kyY19kZXZfcG1fb3BzLAogCQkub2ZfbWF0Y2hfdGFibGUgPSBzaF9tb2JpbGVfaTJjX2R0 X2lkcywKIAl9LAogCS5wcm9iZQkJPSBzaF9tb2JpbGVfaTJjX3Byb2JlLAo=