From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v7 01/13] eal: add option register
	infrastructure
Date: Wed, 24 Oct 2018 16:01:57 +0200
Message-ID: <20181024140156.x4vyur6zxtbrrtny@bidouze.vm.6wind.com>
References: <20181022110014.82153-1-kevin.laatz@intel.com>
 <20181024132725.5142-1-kevin.laatz@intel.com>
 <20181024132725.5142-2-kevin.laatz@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org,
 shreyansh.jain@nxp.com, thomas@monjalon.net,
 mattias.ronnblom@ericsson.com, bruce.richardson@intel.com
To: Kevin Laatz <kevin.laatz@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com
 [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 8EFF654AE
 for <dev@dpdk.org>; Wed, 24 Oct 2018 16:02:17 +0200 (CEST)
Received: by mail-wr1-f67.google.com with SMTP id i4-v6so5704654wrr.13
 for <dev@dpdk.org>; Wed, 24 Oct 2018 07:02:17 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20181024132725.5142-2-kevin.laatz@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Kevin,

On Wed, Oct 24, 2018 at 02:27:13PM +0100, Kevin Laatz wrote:
> This commit adds infrastructure to EAL that allows an application to
> register it's init function with EAL. This allows libraries to be
> initialized at the end of EAL init.
> 
> This infrastructure allows libraries that depend on EAL to be initialized
> as part of EAL init, removing circular dependency issues.
> 
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

I think this is good enough,

Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

The only remaining issue is rte_option_init().
Sorry I missed your previous message and did not respond in time, I
would have opted for leaving a return value to at least be able to stop
the init on error. It is possible to force the callback type to return
an error value along with a string / hint describing the error. It
should not be hard to add it later, so not blocking IMO.

-- 
Gaëtan Rivet
6WIND