From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 24 Oct 2018 11:03:44 -0400 From: Mike Snitzer To: "Martin K. Petersen" Cc: Jens Axboe , Damien Le Moal , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, dm-devel@redhat.com, Christoph Hellwig , Matias Bjorling Subject: Re: [PATCH v4 00/11] Zoned block device support improvements Message-ID: <20181024150344.GB13487@redhat.com> References: <20181012100850.23316-1-damien.lemoal@wdc.com> <78778e22-9c5e-99d0-ef5c-85e04d03a4b7@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Tue, Oct 23 2018 at 10:26pm -0400, Martin K. Petersen wrote: > > Jens, > > > 2) The ordering of the signed-off-by. Someone told me that this is > > patchwork, but I absolutely hate it. SOB should go last, not before > > the reviewed-by. I fixed that up too. > > You keep mentioning this, but I don't recall ever seeing anything to > that effect. The rest of the kernel appears to be either arbitrary > ordering or favoring author SoB as the first tag. I've always felt the proper order is how Jens likes it too (all dm commits from me follow that order). Mike From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH v4 00/11] Zoned block device support improvements Date: Wed, 24 Oct 2018 11:03:44 -0400 Message-ID: <20181024150344.GB13487@redhat.com> References: <20181012100850.23316-1-damien.lemoal@wdc.com> <78778e22-9c5e-99d0-ef5c-85e04d03a4b7@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: "Martin K. Petersen" Cc: Jens Axboe , Damien Le Moal , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, Christoph Hellwig , Matias Bjorling List-Id: linux-scsi@vger.kernel.org On Tue, Oct 23 2018 at 10:26pm -0400, Martin K. Petersen wrote: > > Jens, > > > 2) The ordering of the signed-off-by. Someone told me that this is > > patchwork, but I absolutely hate it. SOB should go last, not before > > the reviewed-by. I fixed that up too. > > You keep mentioning this, but I don't recall ever seeing anything to > that effect. The rest of the kernel appears to be either arbitrary > ordering or favoring author SoB as the first tag. I've always felt the proper order is how Jens likes it too (all dm commits from me follow that order). Mike