All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>
Cc: Netdev <netdev@vger.kernel.org>,
	Jassi Brar <jaswinder.singh@linaro.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: Regression in 4.19 net/phy/realtek: garbled sysfs output
Date: Wed, 24 Oct 2018 22:12:19 +0200	[thread overview]
Message-ID: <20181024201219.GB19440@lunn.ch> (raw)
In-Reply-To: <5e989478-0d33-cd05-efa7-fe3ec54856ab@applied-asynchrony.com>

On Wed, Oct 24, 2018 at 09:36:02PM +0200, Holger Hoffstätte wrote:
> Hi,
> 
> Since 4.19 r8169 depends on phylib:
> 
> $lsmod | grep r8169
> r8169                  81920  0
> libphy                 57344  2 r8169,realtek
> 
> Unfortunately this now gives me the following sysfs error:
> 
> $cd /sys/module/realtek/drivers
> $ls -l
> ls: cannot access 'mdio_bus:RTL8201F 10/100Mbps Ethernet': No such file or directory
> total 0
> lrwxrwxrwx 1 root root 0 Oct 24 21:09 'mdio_bus:RTL8201CP Ethernet' -> '../../../bus/mdio_bus/drivers/RTL8201CP Ethernet'
> l????????? ? ?    ?    ?            ? 'mdio_bus:RTL8201F 10/100Mbps Ethernet'
> lrwxrwxrwx 1 root root 0 Oct 24 21:09 'mdio_bus:RTL8211 Gigabit Ethernet' -> '../../../bus/mdio_bus/drivers/RTL8211 Gigabit Ethernet'
> [..]
> 
> Apparently the forward slash in "10/100Mbps Ethernet" is interpreted as
> directory separator that leads nowhere, and was introduced in commit
> 513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions").
> 
> Would it be acceptable to change the name simply to "RTL8201F Ethernet"?

Hi Holger

Or use "RTL8201F Fast Ethernet"

I wonder if other drivers have similar problems?

davicom.c:      .name           = "Davicom DM9161B/C",
intel-xway.c:           .name           = "Intel XWAY PHY11G (PEF 7071/PEF 7072) v1.3",
intel-xway.c:           .name           = "Intel XWAY PHY11G (PEF 7071/PEF 7072) v1.4",
intel-xway.c:           .name           = "Intel XWAY PHY11G (PEF 7071/PEF 7072) v1.5 / v1.6",
intel-xway.c:           .name           = "Intel XWAY PHY22F (PEF 7061) v1.5 / v1.6",
smsc.c:	 .name	       = "SMSC LAN8710/LAN8720",

	 Andrew

  reply	other threads:[~2018-10-25  4:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 19:36 Regression in 4.19 net/phy/realtek: garbled sysfs output Holger Hoffstätte
2018-10-24 20:12 ` Andrew Lunn [this message]
2018-10-25  9:29   ` Holger Hoffstätte
2018-10-24 20:59 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181024201219.GB19440@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=holger@applied-asynchrony.com \
    --cc=jaswinder.singh@linaro.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.