From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start (rev2)
Date: Thu, 25 Oct 2018 13:32:37 -0000 [thread overview]
Message-ID: <20181025133237.11310.52183@emeril.freedesktop.org> (raw)
In-Reply-To: <20181025124542.21830-1-chris@chris-wilson.co.uk>
== Series Details ==
Series: drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start (rev2)
URL : https://patchwork.freedesktop.org/series/51362/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7c70af9afdbf drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18:
References: 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")
-:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")'
#18:
References: 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")
-:178: ERROR:LOCKING: recursive locking is bad, do not use this ever.
#178: FILE: drivers/gpu/drm/i915/i915_gem_userptr.c:108:
+ switch (mutex_trylock_recursive(m)) {
-:256: WARNING:LONG_LINE: line over 100 characters
#256: FILE: drivers/gpu/drm/i915/i915_gem_userptr.c:176:
+ unlock = __i915_mutex_lock_recursive(&mn->mm->i915->drm.struct_mutex);
total: 2 errors, 2 warnings, 0 checks, 380 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-25 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 12:45 [PATCH] drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start Chris Wilson
2018-10-25 13:32 ` Patchwork [this message]
2018-10-25 13:50 ` ✓ Fi.CI.BAT: success for drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start (rev2) Patchwork
2018-10-25 18:57 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-10-25 19:16 ` [PATCH] drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start Daniel Vetter
2018-10-25 19:39 ` Chris Wilson
2018-10-26 9:02 ` Daniel Vetter
2018-10-26 13:48 ` Daniel Vetter
2018-10-29 10:56 ` Chris Wilson
2018-11-06 10:48 ` Daniel Vetter
2018-10-25 21:04 ` Mark Janes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025133237.11310.52183@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.