From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v3 2/2] net: qcom/emac: add phy-handle support for ACPI Date: Thu, 25 Oct 2018 21:24:30 +0200 Message-ID: <20181025192430.GA16785@lunn.ch> References: <78719753-77bd-596a-dfc7-ccd676850283@kernel.org> <7935985e49270ad2948b2a52d26510bdf55572e6.1540459999.git.dongsheng.wang@hxt-semitech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: timur@kernel.org, yu.zheng@hxt-semitech.com, f.fainelli@gmail.com, netdev@vger.kernel.org To: Wang Dongsheng Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:43251 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727543AbeJZD6o (ORCPT ); Thu, 25 Oct 2018 23:58:44 -0400 Content-Disposition: inline In-Reply-To: <7935985e49270ad2948b2a52d26510bdf55572e6.1540459999.git.dongsheng.wang@hxt-semitech.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Oct 25, 2018 at 06:09:15PM +0800, Wang Dongsheng wrote: > Use "phy-handle" to porint an internal MDIO device port. Hi Dongsheng You are basically defining how all future ACPI based MAC drivers get access to their PHY. This needs to become part of the ACPI standard, etc. This code should not be hidden away in the emac driver. It needs to be placed somewhere public so other drivers can use it. And it needs good documentation, including an example of what needs to go into the ACPI tables, etc. Thanks Andrew